Re: [8u60] request for approval: 8072863: Replace fatal() with vm_exit_during_initialization() when an incorrect class is found on the bootclasspath

2015-04-27 Thread David Holmes
Approved. Thanks, David On 27/04/2015 11:43 PM, cheleswer sahu wrote: Hi! May I please have approval to backport this fix from JDK9 to JDK8. I have built the JDK-8 hotspot and tested already. JDK9 fix applies cleanly to JDK8. As I do not have an account for OPENJDK, David Buck will push the fi

Re: RFR (S) 8073705: more performance issues in class redefinition

2015-04-27 Thread serguei.spit...@oracle.com
On 4/27/15 1:25 PM, serguei.spit...@oracle.com wrote: On 4/27/15 1:05 PM, serguei.spit...@oracle.com wrote: Hi Coleen, Thank you for the review! On 4/27/15 10:49 AM, Coleen Phillimore wrote: Serguei, This looks nice. I thought this change was going to delay calling AdjustCpoolCacheAndVtab

RFR (XM) 8076579: Popping a stack frame after exception breakpoint sets last method param to exception

2015-04-27 Thread serguei.spit...@oracle.com
Please, review the jdk 9 fix for: https://bugs.openjdk.java.net/browse/JDK-8076579 9 hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8076579-JVMTI-pop.1 Summary: This bug is a regression that was introduced but the fix of: https://bugs.openjdk.java.net/browse

Re: RFR (S) 8073705: more performance issues in class redefinition

2015-04-27 Thread serguei.spit...@oracle.com
On 4/27/15 1:05 PM, serguei.spit...@oracle.com wrote: Hi Coleen, Thank you for the review! On 4/27/15 10:49 AM, Coleen Phillimore wrote: Serguei, This looks nice. I thought this change was going to delay calling AdjustCpoolCacheAndVtable until the end of the redefinition, rather than for

Re: RFR (S) 8073705: more performance issues in class redefinition

2015-04-27 Thread serguei.spit...@oracle.com
Hi Coleen, Thank you for the review! On 4/27/15 10:49 AM, Coleen Phillimore wrote: Serguei, This looks nice. I thought this change was going to delay calling AdjustCpoolCacheAndVtable until the end of the redefinition, rather than for each class, so was a bit confused by the change. I co

Re: RFR (S) 8073705: more performance issues in class redefinition

2015-04-27 Thread Coleen Phillimore
Serguei, This looks nice. I thought this change was going to delay calling AdjustCpoolCacheAndVtable until the end of the redefinition, rather than for each class, so was a bit confused by the change. Your change is a nice cleanup and improves MethodHandle method replacement performance.

[8u60] request for approval: 8072863: Replace fatal() with vm_exit_during_initialization() when an incorrect class is found on the bootclasspath

2015-04-27 Thread cheleswer sahu
Hi! May I please have approval to backport this fix from JDK9 to JDK8. I have built the JDK-8 hotspot and tested already. JDK9 fix applies cleanly to JDK8. As I do not have an account for OPENJDK, David Buck will push the fix into jdk8u/hs-dev/hotspot. BUGURL: https://bugs.openjdk.java.net/br

Re: RFR: 8078601: print_concurrent_locks should be guarded with INCLUDE_SERVICES

2015-04-27 Thread Stefan Karlsson
On 2015-04-24 23:49, David Holmes wrote: Looks good. Thanks Stefan. Thanks, David. StefanK David On 25/04/2015 12:41 AM, Stefan Karlsson wrote: Hi, Please review this patch to fix an incorrect usage of #if INCLUDE_ALL_GCS. http://cr.openjdk.java.net/~stefank/8078601/webrev.01/ https:/