Looks good!
Thanks,
/Staffan
> On 12 maj 2015, at 20:07, Jaroslav Bachorik
> wrote:
>
> Please, review the following simple change
>
> Issue : https://bugs.openjdk.java.net/browse/JDK-8029098
> Webrev: http://cr.openjdk.java.net/~jbachorik/8029098/webrev.00
>
> The 'ListenerScaleTest' is mea
Hi Dmitry,
You iterate the queue then, not the unfinalized list. That's more logical.
Holding the queue's lock may pause reference handler and finalizer
threads for the entire time of iteration. This can blow up the
application. Suppose one wants to diagnose the application because he
suspect
Looks good to me!
Shanliang
Jaroslav Bachorik wrote:
Please, review the following simple change
Issue : https://bugs.openjdk.java.net/browse/JDK-8029098
Webrev: http://cr.openjdk.java.net/~jbachorik/8029098/webrev.00
The 'ListenerScaleTest' is meant to check the proper scaling of the
MBean
Please, review the following simple change
Issue : https://bugs.openjdk.java.net/browse/JDK-8029098
Webrev: http://cr.openjdk.java.net/~jbachorik/8029098/webrev.00
The 'ListenerScaleTest' is meant to check the proper scaling of the
MBean notification dispatching. This doesn't make much sense fo
On 12.5.2015 18:46, Staffan Larsen wrote:
They only generate coredump in fastdebug mode, right?
I think so. But it is just a side effect and the test does not inspect
the coredump anyway.
Anyway: Looks good.
Thanks!
-JB-
/Staffan
On 12 maj 2015, at 17:36, Jaroslav Bachorik
wrote
Everybody,
Updated version:
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.03/
Now it iterates over queue and output result sorted by number of instances.
-Dmitry
On 2015-05-07 00:51, Derek White wrote:
> Hi Dmitry, Staffan,
>
> Lots of good comments here.
>
> On the topic of what
http://cr.openjdk.java.net/~aph/8078521-4/
Thanks,
Andrew.
They only generate coredump in fastdebug mode, right?
Anyway: Looks good.
/Staffan
> On 12 maj 2015, at 17:36, Jaroslav Bachorik
> wrote:
>
> Please, review the following test change
>
> Issue : https://bugs.openjdk.java.net/browse/JDK-8046869
> Webrev: http://cr.openjdk.java.net/~jbachorik/
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8046869
Webrev: http://cr.openjdk.java.net/~jbachorik/8046869/webrev.00
These two tests are timing out because they are deliberately crashing
the virtual machine. This crash used to lead to coredump genera
On 05/12/2015 03:47 PM, Andrew Haley wrote:
> On 04/28/2015 09:00 PM, Dmitry Samersoff wrote:
>> Thank you for the fix, I'll take a look at it
>
> Hi,
>
> Any thoughts? HSDB doesn't really do anything without this fix, and
> there is no doubt that the bottom two bits of a Symbol address must be
On 04/28/2015 09:00 PM, Dmitry Samersoff wrote:
> Thank you for the fix, I'll take a look at it
Hi,
Any thoughts? HSDB doesn't really do anything without this fix, and
there is no doubt that the bottom two bits of a Symbol address must be
masked out.
The only problem I have is deciding where to
11 matches
Mail list logo