Thanks Jon for the review and the pointer to the test. I'll get back to you
later this week with a suitable test.
-- Ramki
ysr1729
> On Jun 2, 2015, at 14:16, Jon Masamitsu wrote:
>
> Ramki,
>
> Changes look good.
>
> I'm guessing you tested by generating the
> perfdata by hand and verifyin
Hi Dmitry,
On 06/02/2015 01:12 PM, Dmitry Samersoff wrote:
Staffan,
Instead of hardcoding the field offsets, you can use
InstanceKlass::find_field and fieldDescriptor::offset to find the
offset at runtime.
Done. Please, see
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.11
In th
Ok, I'm going to keep this as one
webrev, but I did create
JDK-8081771 for the ProcessTool.java changes:
https://bugs.openjdk.java.net/browse/JDK-8081771
I will commit ProcessTool.java under JDK-8081771, and the rest of
the changes
Hi Coleen,
The change looks good to me.
Thanks,
Jiangli
On Jun 2, 2015, at 12:58 PM, Coleen Phillimore
wrote:
> Summary: Use the Events::log function to save redefined classes for output to
> the hs_err file.
>
> This change adds lines to the hs_err_pid file which names classes redefined:
>
Coleen,
The fix looks good.
But I have a question.
Would it be useful to log the beginning of a redefinition as well so
that it is known what class is currently being redefined?
Thanks,
Serguei
On 6/2/15 12:58 PM, Coleen Phillimore wrote:
Summary: Use the Events::log function to save redefin
Changes look good to me.
Misha
On 6/2/2015 11:55 AM, Chris Plummer wrote:
I'm going to have to separate out the ProcessTool.java changes into a
separate changeset (and CR). In the meantime, feel free to review what
I have below. The code won't be changing at all when I separate out
the Proces
Ramki,
Changes look good.
I'm guessing you tested by generating the
perfdata by hand and verifying the contents
of the perfdata. Do you think a test can
be written to verify the change? If you look at
test/gc/metaspace/TestMetaspacePerfCounters.java
in your repository I think that is an exa
Mikael,
The reason of placing get_filed_offset_by_name to the oop.inline is that
hotspot widely duplicate this code.
Symbol is used to identify a field within klass, not a klass them self
so I think it's OK to have it tied to the oopDesc.
-Dmitry
On 2015-06-02 15:06, Mikael Gerdin wrote:
> Hi D
Summary: Use the Events::log function to save redefined classes for
output to the hs_err file.
This change adds lines to the hs_err_pid file which names classes redefined:
Classes redefined (2 events):
Event: 11.867 Thread 0x7fd378199800 redefined class
name=RedefineRunningMethods$B, count
I'm going to have to separate out the ProcessTool.java changes into a
separate changeset (and CR). In the meantime, feel free to review what I
have below. The code won't be changing at all when I separate out the
ProcessTool.java changes.
thanks,
Chris
On 6/2/15 12:36 AM, Chris Plummer wrote
I need more reviewer.
Could you review?
http://cr.openjdk.java.net/~ysuenaga/JDK-8072913/webrev.02/
Thanks,
Yasumasa
2015/05/28 23:02 "Yasumasa Suenaga" :
> I'll sponsor it.
>>
>
> Thank you Jesper!
> I will send a chengeset after reviewing.
>
>
> Yasumasa
>
>
> On 2015/05/28 22:47, Jesper Wilh
Hi Dmitry,
On 2015-06-02 13:12, Dmitry Samersoff wrote:
Staffan,
Instead of hardcoding the field offsets, you can use
InstanceKlass::find_field and fieldDescriptor::offset to find the
offset at runtime.
Done. Please, see
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.11
I put th
Staffan,
> Instead of hardcoding the field offsets, you can use
> InstanceKlass::find_field and fieldDescriptor::offset to find the
> offset at runtime.
Done. Please, see
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.11
I put the function int get_filed_offset_by_name(Symbol*,Symbol*
[Adding core-libs-...@openjdk.java.net since this update includes
changes to jdk/test library code]
Please review the updated webrev:
Webrev: http://cr.openjdk.java.net/~cjplummer/8054386/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8054386
There were concerns about the new hotspot
14 matches
Mail list logo
