Hi Chris,
Hotspot change is good.
Only a couple of style nits with the tests (where are our Java style
guidelines ???). Taking CDSJDITest.java as an example:
If you are okay with this line length:
115 public static OutputAnalyzer executeAndLog(ProcessBuilder pb,
String logName) throws
Hi Chris,
I've replied with a thumbs up on another thread.
Thanks,
Serguei
On 6/3/15 4:23 PM, Chris Plummer wrote:
Hi Serguei,
I'll take care of the rename. Can I also put you down for the
ProcessTool.java changes, which are officially being reviewed on
another thread:
http://mail.openjd
Hi Serguei,
I'll take care of the rename. Can I also put you down for the
ProcessTool.java changes, which are officially being reviewed on another
thread:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-June/033892.html
thanks,
Chris
On 6/3/15 1:40 AM, serguei.spit...@oracle.com
> On Jun 3, 2015, at 12:22 PM, Peter Levart wrote:
>
>
> On 06/03/2015 08:36 PM, Mandy Chung wrote:
>>
>>
>> On 06/03/2015 08:29 AM, Dmitry Samersoff wrote:
>>> Updated webrev:
>>>
>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.13
>>
>> I reviewed the jdk change. The vers
Thank you, Serguei!
Coleen
On 6/3/15 2:16 PM, serguei.spit...@oracle.com wrote:
Coleen,
The fix is nice, thank you for the update.
The whole feature is going to be very useful for us!
Thanks,
Serguei
On 6/3/15 7:03 AM, Coleen Phillimore wrote:
Thank you Serguei for the comment. I thought
On 06/03/2015 08:36 PM, Mandy Chung wrote:
On 06/03/2015 08:29 AM, Dmitry Samersoff wrote:
Updated webrev:
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.13
I reviewed the jdk change. The version looks okay and some comments:
ReferenceQueue.java - you should eliminate the use
On 06/03/2015 08:29 AM, Dmitry Samersoff wrote:
Updated webrev:
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.13
I reviewed the jdk change. The version looks okay and some comments:
ReferenceQueue.java - you should eliminate the use of rawtype:
84 Reference rn = r.
Coleen,
The fix is nice, thank you for the update.
The whole feature is going to be very useful for us!
Thanks,
Serguei
On 6/3/15 7:03 AM, Coleen Phillimore wrote:
Thank you Serguei for the comment. I thought of putting the event log
first but really wanted it to tell which classes were al
Everyone,
Updated webrev:
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.13
Changes to oop.inline.hpp is reverted and find_field used directly is
diagnostic command.
-Dmitry
On 2015-06-03 11:48, Dmitry Samersoff wrote:
> Everyone,
>
> Updated webrev:
>
> http://cr.openjdk.java.net
Thank you Serguei for the comment. I thought of putting the event log
first but really wanted it to tell which classes were already
redefined. So I decided to improve the error message for printing the
VM_Operation to include the class being redefined.
With the following change, there's a
Looks good!
Lois
On 6/2/2015 3:58 PM, Coleen Phillimore wrote:
Summary: Use the Events::log function to save redefined classes for
output to the hs_err file.
This change adds lines to the hs_err_pid file which names classes
redefined:
Classes redefined (2 events):
Event: 11.867 Thread 0x000
On 2015-06-02 23:04, Dmitry Samersoff wrote:
Mikael,
The reason of placing get_filed_offset_by_name to the oop.inline is that
hotspot widely duplicate this code.
Symbol is used to identify a field within klass, not a klass them self
so I think it's OK to have it tied to the oopDesc.
Ok, I d
Everyone,
Updated webrev:
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.12
getFinalizerHistogram and FinalizerHistogramEntry moved to separate
package-private class. Hotspot code changed accordingly.
getFinalizerHistogram updated to use Peter's code.
-Dmitry
On 2015-06-03 09:06,
Chris,
It looks good in general.
I'd suggest to rename the folder:
|| test/com/sun/jdi/CDSJDITests
to:
test/com/sun/jdi/cds
There is no need to spell "JDI" as it is already a sub-folder of the
com/sun/jdi
and there is no need to spell "Tests" too as it is in the test repo.
Also, all the fold
14 matches
Mail list logo
