Re: jmx-dev RFR 8141591: javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2015-11-13 Thread Shanliang JIANG
> On 13 Nov 2015, at 09:04, Jaroslav Bachorik > wrote: > > On 13.11.2015 08:05, Shanliang JIANG wrote: >> Hi Jaroslav, >> >> The issue is that after a JMX client is terminated, its >> ClientNotifForwarder continues deliver a job to a user specific >> Executor, I think a better fix to not allow

Re: RFR(M): 8141529: Fix handling of _JAVA_SR_SIGNUM

2015-11-13 Thread Daniel D. Daugherty
On 11/13/15 6:38 AM, David Holmes wrote: On 13/11/2015 7:53 PM, Thomas Stüfe wrote: Hi Goetz, sorry for not looking at this earlier. This is a nice cleanup. Some remarks: http://cr.openjdk.java.net/~goetz/webrevs/8141529-NSIG/webrev.01/src/os/aix/vm/os_aix.cpp.udiff.html +if (sig >

Re: RFR(M): 8141529: Fix handling of _JAVA_SR_SIGNUM

2015-11-13 Thread David Holmes
On 13/11/2015 7:53 PM, Thomas Stüfe wrote: Hi Goetz, sorry for not looking at this earlier. This is a nice cleanup. Some remarks: http://cr.openjdk.java.net/~goetz/webrevs/8141529-NSIG/webrev.01/src/os/aix/vm/os_aix.cpp.udiff.html +if (sig > MAX2(SIGSEGV, SIGBUS) && // See 4355769. +

Re: RFR(M): 8141529: Fix handling of _JAVA_SR_SIGNUM

2015-11-13 Thread Thomas Stüfe
Hi Goetz, sorry for not looking at this earlier. This is a nice cleanup. Some remarks: http://cr.openjdk.java.net/~goetz/webrevs/8141529-NSIG/webrev.01/src/os/aix/vm/os_aix.cpp.udiff.html +if (sig > MAX2(SIGSEGV, SIGBUS) && // See 4355769. +sig < NSIG) { // Must be

Re: RFR (S): 8142482: Improve the support for prefix functions in unified logging

2015-11-13 Thread Per Liden
Hi Marcus, On 2015-11-11 15:19, Marcus Larsson wrote: Hi, Please review the following small patch to improve the support for prefixes in unified logging. Instead of the previous format and value/callback, a prefix is now defined as a function that receives the log buffer as argument, allowing

Re: RFR (XS): 8142483: Unified logging log instances cause warnings on windows when only static functions are used

2015-11-13 Thread Bengt Rutisson
Hi Marcus, On 2015-11-13 10:20, Marcus Larsson wrote: Hi, Please review the following small patch to avoid 'unused variable' warnings on windows when only static functions are used on a log instance. Using log instances like this saves us from specifying the log tags for every function call

RFR (XS): 8142483: Unified logging log instances cause warnings on windows when only static functions are used

2015-11-13 Thread Marcus Larsson
Hi, Please review the following small patch to avoid 'unused variable' warnings on windows when only static functions are used on a log instance. Using log instances like this saves us from specifying the log tags for every function call, so it is something we should not warn about. The patc

Re: RFR (S): 8142482: Improve the support for prefix functions in unified logging

2015-11-13 Thread Marcus Larsson
Thanks for reviewing! Marcus On 2015-11-13 09:20, Per Liden wrote: Hi Marcus, On 2015-11-11 15:19, Marcus Larsson wrote: Hi, Please review the following small patch to improve the support for prefixes in unified logging. Instead of the previous format and value/callback, a prefix is now def

Re: RFR (S): 8142482: Improve the support for prefix functions in unified logging

2015-11-13 Thread Marcus Larsson
Thanks for reviewing! Marcus On 2015-11-11 17:34, Bengt Rutisson wrote: Hi Marcus. On 2015-11-11 15:19, Marcus Larsson wrote: Hi, Please review the following small patch to improve the support for prefixes in unified logging. Instead of the previous format and value/callback, a prefix is