Looks good!
Thanks,
/Staffan
> On 23 nov. 2015, at 08:10, Amy Lu wrote:
>
> Below tests failed with latest nightly jtreg due to non-existing files in
> @build
>
> com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.java
> sun/tools/jmap/BasicJMapTest.java
> com/sun/jdi/DoubleAgentTest.java
>
Below tests failed with latest nightly jtreg due to non-existing files
in @build
com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.java
sun/tools/jmap/BasicJMapTest.java
com/sun/jdi/DoubleAgentTest.java
com/sun/jdi/SuspendNoFlagTest.java
Please review this patch to fix the typo in @build
bug
On 23/11/2015 07:10, Amy Lu wrote:
Below tests failed with latest nightly jtreg due to non-existing files
in @build
com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.java
sun/tools/jmap/BasicJMapTest.java
com/sun/jdi/DoubleAgentTest.java
com/sun/jdi/SuspendNoFlagTest.java
Please review this
On 23/11/2015 12:35 PM, Jini George wrote:
Hi David,
Thanks much for the review and for the suggestions offline. I have addressed
your comments and have a new webrev at:
http://cr.openjdk.java.net/~dsamersoff/sponsorship/jingeorg/JDK-7041183/webrev.02/
src/share/vm/services/management.cpp
Hi Rachel,
Code changes seem okay - thanks.
We will continue discussion re info vs debug elsewhere. :)
I think we will also have to address the problem of no-atomic logging of
multi-part logging statements sometime as well. Not a new problem but
perhaps exacerbated in UL and compounded by inc
Hi David,
Thanks much for the review and for the suggestions offline. I have addressed
your comments and have a new webrev at:
http://cr.openjdk.java.net/~dsamersoff/sponsorship/jingeorg/JDK-7041183/webrev.02/
(Thanks, Dmitry for hosting). Further comments are inlined below.
> -Original
