Re: RFR[ 9u-dev] JDK-8138745: Implement ExitOnOutOfMemory and CrashOnOutOfMemory in HotSpot

Sorry forgot the tests test/runtime/ErrorHandling/TestExitOnOutOfMemoryError.java This test is checking that new Object[Integer.MAX_VALUE]; caused the "Requested array size exceeds VM limit" failure _but_ it doesn't actually do anything to verify that the VM terminated because of the Exi

Re: RFR[ 9u-dev] JDK-8138745: Implement ExitOnOutOfMemory and CrashOnOutOfMemory in HotSpot

Hi, On 25/11/2015 10:40 PM, cheleswer sahu wrote: Hi, Please review the code changes for "https://bugs.openjdk.java.net/browse/JDK-8138745";. Web review link: http://cr.openjdk.java.net/~kevinw/8138745/webrev.00/ Enhancement Brief: ExitO

Re: RFR: 8143121: javax/management/remote/mandatory/loading/MethodResultTest.java fails intermittently

+1 for retrying several times and sleeping between retries. testlibrary.Utils.waitForCondition() is a good candidate for such things. best regards, Olivier Le 23/11/2015 13:05, Shanliang JIANG a écrit : We could repeat retrying until the test harness timeout, but add a sleep is definitively u

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

> On Nov 25, 2015, at 8:53 AM, Jaroslav Bachorik > wrote: > > Updated webrevs: > > http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top > http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/jdk > This looks fine to me. Is there any test referencing the packages in jdk.jvmstat.rm

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

Build changes look good to me now. /Erik On 2015-11-25 17:53, Jaroslav Bachorik wrote: On 25.11.2015 11:36, Magnus Ihse Bursie wrote: On 2015-11-25 10:39, Alan Bateman wrote: On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remo

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 25.11.2015 11:36, Magnus Ihse Bursie wrote: On 2015-11-25 10:39, Alan Bateman wrote: On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remote API and we would break compatibility (eg. JDK 8 jvmstat would not be able to query JVM

Re: RFR 8141526: Allow to collect stdout/stderr from the FinalizationRunner even before the process returns

Jaroslav, Looks good for me. PS: I found a bug in canPtraceAttachLinux not related to your changes - it's probably my mistake: 181 if (userName.equals("root")) { 182 return true; 183 } shouldn't be there. Could you file a separate CR and assign it to me? -Dmitry

Re: RFR: 8142979: Add programmatic enable/disable methods to Unified Logging

On 2015-11-25 14:17, Bengt Rutisson wrote: Hi Marcus, On 2015-11-25 13:13, Marcus Larsson wrote: Hi, Please review the following patch adding support for configuration of the stdout unified logging output from within the VM itself. The patch adds the configure_stdout() function, allowing

Re: RFR: 8142979: Add programmatic enable/disable methods to Unified Logging

Hi Marcus, On 2015-11-25 13:13, Marcus Larsson wrote: Hi, Please review the following patch adding support for configuration of the stdout unified logging output from within the VM itself. The patch adds the configure_stdout() function, allowing a set of tags to be set to the given level o

RFR[ 9u-dev] JDK-8138745: Implement ExitOnOutOfMemory and CrashOnOutOfMemory in HotSpot

Hi, Please review the code changes for "https://bugs.openjdk.java.net/browse/JDK-8138745";. Web review link: http://cr.openjdk.java.net/~kevinw/8138745/webrev.00/ Enhancement Brief: ExitOnOutOfMemoryError: When user enable this option,

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 2015-11-25 10:39, Alan Bateman wrote: On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remote API and we would break compatibility (eg. JDK 8 jvmstat would not be able to query JVM exposed via JDK 9 jstatd). You're right. there

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remote API and we would break compatibility (eg. JDK 8 jvmstat would not be able to query JVM exposed via JDK 9 jstatd). You're right. there might be an expectation on interop althou

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 2015-11-25 10:28, Jaroslav Bachorik wrote: On 25.11.2015 09:37, Erik Joelsson wrote: On 2015-11-25 09:11, Staffan Larsen wrote: On 24 nov. 2015, at 17:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * t

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 25.11.2015 09:37, Erik Joelsson wrote: On 2015-11-25 09:11, Staffan Larsen wrote: On 24 nov. 2015, at 17:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 25.11.2015 10:02, Alan Bateman wrote: On 24/11/2015 16:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top * jdk: http://cr.openjdk.java.ne

[ping] Re: RFR 8141526: Allow to collect stdout/stderr from the FinalizationRunner even before the process returns

On 6.11.2015 17:11, Jaroslav Bachorik wrote: [wider audience included] Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8141526 Webrev: top> http://cr.openjdk.java.net/~jbachorik/8141526/webrev.00 hotspot> http://cr.openjdk.java.net/~jbachorik/8141526/we

[ping] Re: jmx-dev RFR 8142398: ManagementAgent.status diagnostic command only outputs the specifically set properties

On 11.11.2015 16:52, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8142398 Webrev: http://cr.openjdk.java.net/~jbachorik/8142398/webrev.00 This patch adds the list of the default agent properties with the info whether the default v

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 2015-11-25 09:11, Staffan Larsen wrote: On 24 nov. 2015, at 17:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top * jdk: http://cr.open

PING: RFR: JDK-8140556: Add force rotation option to VM.log jcmd

PING: Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8140556/webrev.04/ Yasumasa On 2015/11/15 21:51, Yasumasa Suenaga wrote: PING: Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8140556/webrev.04/ Yasumasa On 2015/11/05 23:50, Yasumasa Suenaga wrote: _p

Re: RFR[ 9u-dev] JDK-8138745: Implement ExitOnOutOfMemory and CrashOnOutOfMemory in HotSpot

A couple of comments: debug.cpp: - When exiting due to ExitOnOutOfMemoryError I think we should print that we are exiting to tty. - Perhaps the exit value should be made unique so that one can see the cause of the exit? TestCrashOnOutOfMemoryError.java - L33: nit: Don’t use * imports, list all

RFR: 8142979: Add programmatic enable/disable methods to Unified Logging

Hi, Please review the following patch adding support for configuration of the stdout unified logging output from within the VM itself. The patch adds the configure_stdout() function, allowing a set of tags to be set to the given level on stdout. To disable logging the level is simply specifi

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

> On 24 nov. 2015, at 17:03, Jaroslav Bachorik > wrote: > > Please, review the following change > > Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 > Webrevs: > * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top > * jdk: http://cr.openjdk.java.net/~jbachorik/8043

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 24/11/2015 16:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top * jdk: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/jdk This p

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 25/11/2015 08:11, Staffan Larsen wrote: On 24 nov. 2015, at 17:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top * jdk: http://cr.openjd