Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

Hi Marcus, I had assumed from the JEP that multiple -Xlog arguments for different tags were already supported - so good to see that is now fixed. I'm unclear what the semantics are for combining multiple -Xlog arguments for the same tag (either directly or via implicit wildcards)? Most detai

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

> On Nov 26, 2015, at 2:12 AM, Jaroslav Bachorik > wrote: > > Mandy, > > On 25.11.2015 18:22, Mandy Chung wrote: >> >>> On Nov 25, 2015, at 8:53 AM, Jaroslav Bachorik >>> wrote: >>> >>> Updated webrevs: >>> >>> http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top >>> http://cr.open

Re: RFR: 8143121: javax/management/remote/mandatory/loading/MethodResultTest.java fails intermittently

Looks good ! Same remark as Jaroslav regarding testLibrary path. Olivier On 26/11/2015 12:59, Alexander Kulyakhtin wrote: Hi, Following the comments from Daniel, Jaroslav and Olivier I've changed the delay to 100 ms making it adjustable using the Utils.adjustTimeout() method. Webrev: htt

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

Thanks for reviewing, Staffan! Marcus On 2015-11-26 16:54, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 26 nov. 2015, at 16:17, Marcus Larsson wrote: Hi, New webrev after offline review with Bengt and Staffan: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/ Incremental:

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

Looks good! Thanks, /Staffan > On 26 nov. 2015, at 16:17, Marcus Larsson wrote: > > Hi, > > New webrev after offline review with Bengt and Staffan: > http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/ > > Incremental: > http://cr.openjdk.java.net/~mlarsson/8142952/webrev.00-01/ > > Chan

RE: RFR(L): 8140485: Class load and creation clean up

Hi Serguei and Coleen, Many thanks again for traversing this change. Serguei, I have updated to address (some of) your comments: " Both checks at the lines 83 ans 69 are late as tags is dereferenced at the line 81. Would it better to remove the line 81 and initialize the _length

Re: [preview] Adding java.lang.Runtime.getVMArguments() method

On 25.11.2015 04:11, Mandy Chung wrote: > On Nov 24, 2015, at 6:24 PM, David Holmes wrote: > > On 25/11/2015 10:06 AM, Mandy Chung wrote: >> >>> On Nov 24, 2015, at 3:45 PM, Peter Levart wrote: >>> >>> >>> >>> On 11/24/2015 05:49 PM, Jaroslav Bachorik wrote: Hi, while working on

Re: RFR: 8143121: javax/management/remote/mandatory/loading/MethodResultTest.java fails intermittently

Hi, Following the comments from Daniel, Jaroslav and Olivier I've changed the delay to 100 ms making it adjustable using the Utils.adjustTimeout() method. Webrev: http://cr.openjdk.java.net/~akulyakh/8143121_04/test/javax/management/remote/mandatory/loading/MethodResultTest.java.udiff.html

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

Thanks for reviewing, Bengt! Marcus On 2015-11-26 16:25, Bengt Rutisson wrote: Hi Marcus, On 2015-11-26 16:17, Marcus Larsson wrote: Hi, New webrev after offline review with Bengt and Staffan: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/ Incremental: http://cr.openjdk.java.net/~

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

Hi Marcus, On 2015-11-26 16:17, Marcus Larsson wrote: Hi, New webrev after offline review with Bengt and Staffan: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.00-01/ Looks good. Changes: * LogLevel::Unchanged was

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

Hi, New webrev after offline review with Bengt and Staffan: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.00-01/ Changes: * LogLevel::Unchanged was changed to LogLevel::NotMentioned. * Test improvements. I also looked a

Re: RFR: 8143121: javax/management/remote/mandatory/loading/MethodResultTest.java fails intermittently

Yes, looks good to me too :-) best regards, -- daniel On 26/11/15 12:59, Alexander Kulyakhtin wrote: Hi, Following the comments from Daniel, Jaroslav and Olivier I've changed the delay to 100 ms making it adjustable using the Utils.adjustTimeout() method. Webrev: http://cr.openjdk.java.net/~

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

Mandy, On 25.11.2015 18:22, Mandy Chung wrote: On Nov 25, 2015, at 8:53 AM, Jaroslav Bachorik wrote: Updated webrevs: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/jdk This looks fine to me. Is there any test referen

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 25/11/2015 16:53, Jaroslav Bachorik wrote: Updated webrevs: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/jdk Thanks to Erik J. for helping me with the build script! Updated version looks good to me. -Alan

Re: RFR: 8143121: javax/management/remote/mandatory/loading/MethodResultTest.java fails intermittently

On 26.11.2015 12:59, Alexander Kulyakhtin wrote: Hi, Following the comments from Daniel, Jaroslav and Olivier I've changed the delay to 100 ms making it adjustable using the Utils.adjustTimeout() method. Webrev: http://cr.openjdk.java.net/~akulyakh/8143121_04/test/javax/management/remote/mandat

Re: [preview] Adding java.lang.Runtime.getVMArguments() method

On 26.11.2015 12:48, Jaroslav Bachorik wrote: On 25.11.2015 04:11, Mandy Chung wrote: > On Nov 24, 2015, at 6:24 PM, David Holmes wrote: > > On 25/11/2015 10:06 AM, Mandy Chung wrote: >> >>> On Nov 24, 2015, at 3:45 PM, Peter Levart wrote: >>> >>> >>> >>> On 11/24/2015 05:49 PM, Jaroslav Bach