Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hello! An update and updated webrev. I've rewritten the two portions of code that had used ttyLockers to print in one function-call, since there is no locker equivalent in UL, plus the fact that it will be easier for users to look for one message's contents without the decorators interrupting

Re: RFR: 8145153: Convert TraceMonitorInflation to Unified Logging

Hi David, Thanks for the review! Updated webrev: http://cr.openjdk.java.net/~rprotacio/8145153.01/ On 12/10/2015 7:53 PM, David Holmes wrote: Hi Rachel, On 11/12/2015 8:21 AM, Rachel Protacio wrote: Hello! Please review another product flag logging change. This one's pretty small. Converts

Re: [PING] Re: RFR: 8144220: UL does not support full path names for log files on windows

Thanks Markus! On 2015-12-11 14:32, Markus Gronlund wrote: Hi Marcus, This looks good. Thanks Markus -Original Message- From: Marcus Larsson Sent: den 11 december 2015 13:49 To: serviceability-dev@openjdk.java.net Subject: [PING] Re: RFR: 8144220: UL does not support full path names f

Re: [PING] RFR: 8144220: UL does not support full path names for log files on windows

Thanks Staffan! On 2015-12-11 13:58, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 11 dec. 2015, at 13:49, Marcus Larsson wrote: Need another review for this. On 2015-12-03 11:11, Marcus Larsson wrote: Hi, New webrev: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.01/ Incre

RE: [PING] Re: RFR: 8144220: UL does not support full path names for log files on windows

Hi Marcus, This looks good. Thanks Markus -Original Message- From: Marcus Larsson Sent: den 11 december 2015 13:49 To: serviceability-dev@openjdk.java.net Subject: [PING] Re: RFR: 8144220: UL does not support full path names for log files on windows Need another review for this. On 2

Re: [PING] RFR: 8144220: UL does not support full path names for log files on windows

Looks good! Thanks, /Staffan > On 11 dec. 2015, at 13:49, Marcus Larsson wrote: > > Need another review for this. > > On 2015-12-03 11:11, Marcus Larsson wrote: >> Hi, >> >> New webrev: >> http://cr.openjdk.java.net/~mlarsson/8144220/webrev.01/ >> >> Incremental: >> http://cr.openjdk.java.ne

[PING] Re: RFR: 8144220: UL does not support full path names for log files on windows

Need another review for this. On 2015-12-03 11:11, Marcus Larsson wrote: Hi, New webrev: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.00-01/ Added more test cases to the test, and renamed it to TestQuotedLogOutputs.

Re: RFR: JDK-8145099 Better error message when SA can't attach to a process

> On 11 dec. 2015, at 11:54, Dmitry Samersoff > wrote: > > Staffan, > >> This is all platform specific code - and all the platforms are >> different. Of course, it would be good if all platforms reported good >> error message always - and we can continue working on that. > > OK. > >> It shou

Re: RFR: JDK-8145099 Better error message when SA can't attach to a process

Staffan, > This is all platform specific code - and all the platforms are > different. Of course, it would be good if all platforms reported good > error message always - and we can continue working on that. OK. > It should get filled in in the ptrace_attach() call. if ph->pid == thr->lwp_id at

Re: RFR: JDK-8145099 Better error message when SA can't attach to a process

> On 10 dec. 2015, at 23:20, Dmitry Samersoff > wrote: > > Staffan, > > 1. > > strerror_r comes in two versions - returning string (GNU) and returning > int (XSI) > > To make developers live more interesting GNU version doesn't guarantee > to fill buf with appropriate string, so you can't ju