Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

2016-01-13 Thread cheleswer sahu
Adding core-libs-dev and hotspot-runtime-dev team . On 1/14/2016 12:24 AM, Martin Buchholz wrote: You should include core-libs-dev (and perhaps hotspot-runtime-dev) in this thread. You're changing core library code. On Wed, Jan 13, 2016 at 2:25 AM, cheleswer sahu wrote: Hi, Please review th

Re: RFR(M): JDK-8141070 vm/services/management.cpp should be resilient to missing 'jdk.management' module

2016-01-13 Thread David Holmes
Hi Dmitry, On 14/01/2016 4:45 AM, Dmitry Samersoff wrote: Everybody, Please, review the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8141070/webrev.01/ The problem: Code in management.cpp throw NoClassDefFound exception if any of requested classes is missing. But, in upcoming modula

Re: JDK-8031753 : Review request

2016-01-13 Thread Harsha Wardhana B
Gentle reminder :) On Monday 11 January 2016 02:51 PM, Jaroslav Bachorik wrote: [adding JMX dev list] On 8.1.2016 10:44, Harsha Wardhana B wrote: Hi All, Please review the fix for, Issue : JDK-8031753 - JMXServiceURL should not use getLocalHost or its usage should be enh

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

2016-01-13 Thread Martin Buchholz
You should include core-libs-dev (and perhaps hotspot-runtime-dev) in this thread. You're changing core library code. On Wed, Jan 13, 2016 at 2:25 AM, cheleswer sahu wrote: > Hi, > > Please review the code changes for > "https://bugs.openjdk.java.net/browse/JDK-8130425";. > > Problem summary: Wh

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-13 Thread serguei.spit...@oracle.com
On 1/13/16 03:16, Jaroslav Bachorik wrote: On 12.1.2016 12:55, serguei.spit...@oracle.com wrote: On 1/12/16 03:49, Jaroslav Bachorik wrote: On 12.1.2016 11:47, serguei.spit...@oracle.com wrote: On 1/7/16 08:40, Daniel Fuchs wrote: Hi, This looks OK to me. I'm not sure I understand the full i

RFR(M): JDK-8141070 vm/services/management.cpp should be resilient to missing 'jdk.management' module

2016-01-13 Thread Dmitry Samersoff
Everybody, Please, review the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8141070/webrev.01/ The problem: Code in management.cpp throw NoClassDefFound exception if any of requested classes is missing. But, in upcoming modular JDK classes that not belong to java.lang.management (sun.mana

Re: RFR: JDK-8130063: Refactoring tmtools jstat and jstack tests to jtreg

2016-01-13 Thread Jaroslav Bachorik
Hi Alexander, On 12.1.2016 15:22, Alexander Kulyakhtin wrote: Hi, Could you, please, review the following test-only change CR: https://bugs.openjdk.java.net/browse/JDK-8130063 "Refactoring tmtools jstat and jstack tests to jtreg" WebRev: http://cr.openjdk.java.net/~akulyakh/8130063_01/ The

Re: RFR (M): 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

2016-01-13 Thread Andreas Eriksson
Hi, On 2015-12-29 21:27, Dmitry Samersoff wrote: Andreas, Great work. All but write_internal looks good for me (see below). HprofReader.java: Nit - length -= skipped; should be after if skipped == 0 heapDumper.cpp:480 1. For windows you can do : assert(len < (size_t)UINT_MAX, ... );

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

2016-01-13 Thread David Holmes
Hi Cheleswer, On 13/01/2016 8:25 PM, cheleswer sahu wrote: Hi, Please review the code changes for "https://bugs.openjdk.java.net/browse/JDK-8130425";. Problem summary: When a large TLS (Thread Local Storage) size is set for threads, JVM is throwing StackOverflow exception. Problem Identified

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-13 Thread Jaroslav Bachorik
On 13.1.2016 13:00, Daniel Fuchs wrote: On 13/01/16 12:16, Jaroslav Bachorik wrote: Thanks. I've added the explanation and also disambiguated the method name a bit. http://cr.openjdk.java.net/~jbachorik/8146015/webrev.01 It looks like no one else is going to jump in and verify the getAddresses

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-13 Thread Daniel Fuchs
On 13/01/16 12:16, Jaroslav Bachorik wrote: Thanks. I've added the explanation and also disambiguated the method name a bit. http://cr.openjdk.java.net/~jbachorik/8146015/webrev.01 It looks like no one else is going to jump in and verify the getAddressesForLocalHost() change (basically, excludi

Re: [ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-13 Thread Jaroslav Bachorik
On 12.1.2016 12:55, serguei.spit...@oracle.com wrote: On 1/12/16 03:49, Jaroslav Bachorik wrote: On 12.1.2016 11:47, serguei.spit...@oracle.com wrote: On 1/7/16 08:40, Daniel Fuchs wrote: Hi, This looks OK to me. I'm not sure I understand the full impact of the changes in getAddressesForLocal

RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

2016-01-13 Thread cheleswer sahu
Hi, Please review the code changes for "https://bugs.openjdk.java.net/browse/JDK-8130425";. Problem summary: When a large TLS (Thread Local Storage) size is set for threads, JVM is throwing StackOverflow exception. Problem Identified: As per investigation and a discussion we came to the co