RE: RFR [9] 8150168: jconsole AboutDialog should use the JDK specific Version API

Hi, Chris. I think that change is fine. I've added a note to JDK-8144062 (module for jdk.Version), indicating that this code may need to be changed depending on how that issue is resolved. Thanks, iris -Original Message- From: Chris Hegarty Sent: Thursday, February 18, 2016 5:42 AM

RFR(s): 8150026: Add the ability to log with variable log level

Hi, please review. This adds a write method to the UL log which takes the level as parameter. JBS: https://bugs.openjdk.java.net/browse/JDK-8150026 Webrev: http://cr.openjdk.java.net/~mlarsson/rehn/8150026/ Tested ok with rbt hotspot_all. Thanks! /Robbin

[8u-dev] RFR 8150070: TESTBUG: com/sun/jdi tests fail on Cygwin but pass on MKS

Hello Please review a test bug fix. The test fails because Cygwin PID returned by "$!" and Windows PID returned by "tasklist" are not the same. Need to use cygwin "ps". Bug: https://bugs.openjdk.java.net/browse/JDK-8150070 Webrev: http://cr.openjdk.java.net/~kshefov/8150070/webrev Thanks -Kon

Re: RFR [9] 8150168: jconsole AboutDialog should use the JDK specific Version API

On 18 Feb 2016, at 13:57, Alan Bateman wrote: > This looks okay but it's very possible this will need to change again soon > once a home for the Version class is found. Understood, but I am interested in breaking dependencies on sun.misc.Version, so progress can be made on finding it a new hom

Re: RFR [9] 8150168: jconsole AboutDialog should use the JDK specific Version API

This looks okay but it's very possible this will need to change again soon once a home for the Version class is found. -Alan On 18/02/2016 13:42, Chris Hegarty wrote: With the introduction of a JDK specific Version API, the console AboutDialog should no longer use sun.misc.Version. It should b

RFR [9] 8150168: jconsole AboutDialog should use the JDK specific Version API

With the introduction of a JDK specific Version API, the console AboutDialog should no longer use sun.misc.Version. It should be be updated to use the new JDK specific API. diff --git a/src/jdk.jconsole/share/classes/sun/tools/jconsole/AboutDialog.java b/src/jdk.jconsole/share/classes/sun/tools/

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

Hi Cheleswer, Looks good to me. Thanks Kevin (Also, as one of the comments was that there may be no real cost to using default stack sizes here (on most systems...?), having jdk.lang.processReaperUseDefaultStackSize gives us a way to test that widely, and one day the 32k may be able to disapp

Re: jmx-dev [ping] Re: RFR 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials (Round 2)

Hi Jaroslav, Looks good. BTW - shouldn't you take sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java out of the problem list as well? I see that 8147985 is fixed. best regards, -- daniel On 18/02/16 09:48, Jaroslav Bachorik wrote: Hi, On 17.2.2016 14:41, Daniel Fuchs wrote: Th

Re: RFR : JDK-8147610 - javax/management/mxbean/MXBeanLoadingTest1.java assumes URLClassLoader

Looks good! -JB- On 9.2.2016 07:30, Harsha Wardhana B wrote: Hi All, I request you to review fix for, Issue : JDK-8147610 - javax/management/mxbean/MXBeanLoadingTest1.java assumes URLClassLoader Webrev : http://cr.openjdk.java.net/~hb/8147610/werev.00/ The fix is simple and self-explanatory

Re: jmx-dev [ping] Re: RFR 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials (Round 2)

Hi, On 17.2.2016 14:41, Daniel Fuchs wrote: Thanks Jaroslav, that's great! If these certificates have an expiration date then it's possible that we will have to regenerate them from time to time... Thanks for checking on this. I've update the certificates to have expiration date 100 years fr

Re: RFR:8150067:Quarantine serviceability/tmtools/jstat/GcCapacityTest.java test

Looks good! Thanks, /Staffan > On 17 feb. 2016, at 16:54, Alexander Kulyakhtin > wrote: > > Hi, > > Could you, please, review this trivial test-only change (quarantining the > test): > > CR: https://bugs.openjdk.java.net/browse/JDK-8150067 > Webrev: > http://cr.openjdk.java.net/~akulyakh/8