Hi,
Could someone else also please review this?
On 02/29/2016 11:22 AM, Marcus Larsson wrote:
Hi Robbin,
On 02/18/2016 08:37 PM, Robbin Ehn wrote:
Hi, please review.
This adds a write method to the UL log which takes the level as
parameter.
JBS: https://bugs.openjdk.java.net/browse/JDK-8150
Looks good!
Erik
Den 03/03/16 kl. 01:15, skrev Markus Gronlund:
Greetings,
Could a please ask for reviews for the following simple fix to resolve
a test issue associated with
test/java/lang/instrument/NativeMethodPrefixAgent.java
Bug: https://bugs.openjdk.java.net/browse/JDK-8151100
Webr
Greetings,
Could a please ask for reviews for the following simple fix to resolve a test
issue associated with test/java/lang/instrument/NativeMethodPrefixAgent.java
Bug: https://bugs.openjdk.java.net/browse/JDK-8151100
Webrev/diff:
diff --git a/test/java/lang/instrument/NativeMet
Thanks Dan,
I missed that Andreas has started working on the bug and sent out a review.
Sorry about that. I will reassign back to Andreas.
Erik
On 2016-03-03 00:14, Daniel D. Daugherty wrote:
Just caught up on the bug updates so now I see that you (Erik G)
have taken over the bug...
I'm good
Just caught up on the bug updates so now I see that you (Erik G)
have taken over the bug...
I'm good with this fix also...
Dan
On 3/2/16 4:08 PM, Daniel D. Daugherty wrote:
Hi Erik,
I reviewed a different fix for the same bug from Andreas E.
earlier today.
Dan
On 3/2/16 3:18 PM, Markus Gro
Hi Erik,
I reviewed a different fix for the same bug from Andreas E.
earlier today.
Dan
On 3/2/16 3:18 PM, Markus Gronlund wrote:
Hi Erik,
I think this looks good.
Thanks for fixing.
Markus
-Original Message-
From: Erik Gahlin
Sent: den 2 mars 2016 23:08
To: serviceability-dev@open
Hi Erik,
I think this looks good.
Thanks for fixing.
Markus
-Original Message-
From: Erik Gahlin
Sent: den 2 mars 2016 23:08
To: serviceability-dev@openjdk.java.net
Subject: RFR(XS) serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
failing because expects HPROF JAVA PROFILE 1.0
Hi,
Could I have a review of a fix for
"8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
failing because expects HPROF JAVA PROFILE 1.0.1 file format"
https://bugs.openjdk.java.net/browse/JDK-8150986
It's a test update to accommodate the removal of 1.0.1 HPROF file format
su
Thanks you Erik!
Markus
From: Erik Gahlin
Sent: den 2 mars 2016 21:30
To: serviceability-dev@openjdk.java.net
Subject: Re: RFR(XXS): 8151053: com/sun/jdi/StepTest.java fails in 2016-03-01
JDK9-hs-rt nightly
Looks good. Not a reviewer.
Erik
On 2016-03-02 20:49, Markus Gronlund wrote:
Looks good. Not a reviewer.
Erik
On 2016-03-02 20:49, Markus Gronlund wrote:
Greetings,
Could a please ask for reviews for the following simple fix to resolve
a test issue associated with com/sun/jdi/StepTest.java
Bug: https://bugs.openjdk.java.net/browse/JDK-8151053
Comment:
Need to fil
Thank you Dan!
/Markus
From: Daniel D. Daugherty
Sent: den 2 mars 2016 21:25
To: Markus Gronlund; serviceability-dev
Subject: Re: RFR(XXS): 8151053: com/sun/jdi/StepTest.java fails in 2016-03-01
JDK9-hs-rt nightly
On 3/2/16 12:49 PM, Markus Gronlund wrote:
Greetings,
Could a pl
On 3/2/16 12:49 PM, Markus Gronlund wrote:
Greetings,
Could a please ask for reviews for the following simple fix to resolve
a test issue associated with com/sun/jdi/StepTest.java
Bug: https://bugs.openjdk.java.net/browse/JDK-8151053
Comment:
Need to filter out some classes that has moved
Thanks Dmitry.
- Andreas
On 2016-03-02 19:26, Dmitry Samersoff wrote:
Looks good for me!
On 2016-03-02 19:56, Andreas Eriksson wrote:
Hi,
Can I please have a review for this small test fix.
Bug: 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
failing because expects HPROF
Greetings,
Could a please ask for reviews for the following simple fix to resolve a test
issue associated with com/sun/jdi/StepTest.java
Bug: https://bugs.openjdk.java.net/browse/JDK-8151053
Comment:
Need to filter out some classes that has moved to another package
Patch is attach
Hi,
On 2016-03-02 19:10, Daniel D. Daugherty wrote:
On 3/2/16 9:56 AM, Andreas Eriksson wrote:
Hi,
Can I please have a review for this small test fix.
Bug: 8150986:
serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing
because expects HPROF JAVA PROFILE 1.0.1 file format
https:/
Looks good for me!
On 2016-03-02 19:56, Andreas Eriksson wrote:
> Hi,
>
> Can I please have a review for this small test fix.
>
> Bug: 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
> failing because expects HPROF JAVA PROFILE 1.0.1 file format
> https://bugs.openjdk.java.net/
On 3/2/16 9:56 AM, Andreas Eriksson wrote:
Hi,
Can I please have a review for this small test fix.
Bug: 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
failing because expects HPROF JAVA PROFILE 1.0.1 file format
https://bugs.openjdk.java.net/browse/JDK-8150986
Webrev: http:
Hi,
Can I please have a review for this small test fix.
Bug: 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
failing because expects HPROF JAVA PROFILE 1.0.1 file format
https://bugs.openjdk.java.net/browse/JDK-8150986
Webrev: http://cr.openjdk.java.net/~aeriksso/8150986/webr
It is not difficult to create webrev for this proposal.
However, this proposal affects to jstat output, and
I cannot access JPRT.
So I want to find sponsor for it at first.
Could somebody be a sponsor?
Yasumasa
On 2016/03/02 22:29, k...@kodewerk.com wrote:
Hi Yasumasa,
It all sounds reasona
Hi Yasumasa,
It all sounds reasonable and of course the impact on downstream tooling vs the
value of the change must be evaluated. In this case I think adding a CGC
counter makes sense especially in prep for G1 becoming default in 9.
Regards,
Kirk
> On Mar 2, 2016, at 6:58 AM, Yasumasa Suenaga
Hi Kirk,
Agree to you.
However, I use occasional FGC counter at CMS as below:
1. Check major collection occurrence
Some production systems have large memory as Java heap,
and they are not set GC log.
If their CPU usage becomes high, I want to check GC execution.
(Of cour
Hi Alexander,
You suggestion to fix JDK-8145552 in JDK 9 with its backport to JDK 8u
sounds reasonable.
I think we may close JDK-8150070 and make a backport request of
JDK-8145552 to JDK 8u when it is fixed in JDK 9.
-Konstantin
On 02/29/2016 02:18 PM, Alexander Kulyakhtin wrote:
Hi Konstan
Hi Yasumasa,
Good question. I’ve never considered CMS to be a Full GC. This implies that
there should be separate performance counters for CMS pause phases as it is
possible to have FGC. Of course a FGC during CMS maybe user triggered,
triggered outside a CMS cycle, interrupts a CMS cycle, or i
23 matches
Mail list logo
