Re: RFR(xs): 8151993: Remove inclusion of inline.hpp in log.hpp

> On Mar 16, 2016, at 8:33 AM, Robbin Ehn wrote: > > Hi, please review this small change. > > This also change allocation methods. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8151993/ > Webrev: http://cr.openjdk.java.net/~rehn/8151993/webrev/ > > Thanks! > > /Robbin ---

Re: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

On 18/03/2016 11:28 PM, Dmitry Samersoff wrote: David, Ignoring Dmitry's issue it still seems simpler/cleaner to just add the desired precision value to the %s than to split into two print statements. Or bite the bullet now and make the length immaterial by breaking the name into chunks. It's

Re: RFR(XS): 8152119: Event-based tracing to allow for tracing Klass definition

Hi Markus, On 18/03/2016 4:43 AM, Markus Gronlund wrote: Greetings, Kindly asking for reviews for the following change to allow for tracing Klass definitions. Bug: https://bugs.openjdk.java.net/browse/JDK-8152119 Webrev: http://cr.openjdk.java.net/~mgronlun/8152119/webrev01/ You either need

RFR : JDK-8151797 - java/lang/management/ThreadMXBean/ThreadLists.java : inconsistent results

Hello All, Please review fix for, Issue : JDK-8151797 - java/lang/management/ThreadMXBean/ThreadLists.java : inconsistent results Webrev : http://cr.openjdk.java.net/~hb/8151797/webrev.00/ Root-cause : call-site cleaner thread not started before counting threads via Thr

Re: RFR: JDK-8151674: STW phases at Concurrent GC should count in PerfCounter

On 03/10/2016 07:59 PM, Yasumasa Suenaga wrote: Hi all, This review request continues from: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2016-March/016774.html http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2016-March/016896.html I wonder that STW phases (Remark and Clea

RFR(xs): 8151993: Remove inclusion of inline.hpp in log.hpp

Hi, please review this small change. This also change allocation methods. Bug: https://bugs.openjdk.java.net/browse/JDK-8151993/ Webrev: http://cr.openjdk.java.net/~rehn/8151993/webrev/ Thanks! /Robbin

Re: RFR(S): JDK-8151991 jvmti diagnostics commands requires INCLUDE_SERVICES

On 17/03/2016 12:14 AM, Dmitry Samersoff wrote: Everybody, Please, review small fix. http://cr.openjdk.java.net/~dsamersoff/JDK-8151991/webrev.01/ New diagnostic command (JVMTI.agent_load) should be guarded by #if INCLUDE_SERVICES and don't brake minimal VM build. Initially I was confused as

RE: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

Hi David, -Original Message- From: David Holmes Sent: Friday, March 18, 2016 2:42 PM To: Cheleswer Sahu; hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater

Re: RFR(xs): 8151993: Remove inclusion of inline.hpp in log.hpp

Dear Robbin, It would be much nicer if the code was changed to call a new method in a cpp file (this is clearly a slow path) and the new method could use a bufferedStream to automatically expand the needed buffer. You would need to implement vprint on bufferedStream to make is expand when needed,

RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

Hi, Please review the code changes for https://bugs.openjdk.java.net/browse/JDK-8151442. Webrev Link: http://cr.openjdk.java.net/~csahu/8151442/ Bug Brief: In jstack thread dumps , thread name greater than 1996 characters doesn't close quotation marks properly. Problem Identifi

Re: RFR : JDK-8151797 - java/lang/management/ThreadMXBean/ThreadLists.java : inconsistent results

You should move the Arrays.stream trigger call to before the ManagementFactory.getThreadMXBean, otherwise the threads you get from ThreadMXBean will not match the threads you get from the ThreadGroups. > On 18 mars 2016, at 12:17, Harsha Wardhana B > wrote: > > Hello All, > > Please review f

Re: RFR(XS): 8152119: Event-based tracing to allow for tracing Klass definition

Looks good. Not a reviewer. Erik On 2016-03-17 19:43, Markus Gronlund wrote: Greetings, Kindly asking for reviews for the following change to allow for tracing Klass definitions. Bug: https://bugs.openjdk.java.net/browse/JDK-8152119 Webrev: http://cr.openjdk.java.net/~mgronlun/8152119/web

Re: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

On 18/03/2016 5:54 PM, Cheleswer Sahu wrote: Hi, Please review the code changes for https://bugs.openjdk.java.net/browse/JDK-8151442. Webrev Link: http://cr.openjdk.java.net/~csahu/8151442/ Bug Brief: In jstack thread dumps , thread name greater than 1996 characters doesn’t close quotation ma

[PATCH] JDK-8036559: Attach API does not allow root to connect to process owned by others

Hi, I've been working on an updated patch for JDK-8036559, where root does not have the ability to attach to unprivileged users' JVMs. I originally mentioned this problem back in 2013, and proposed a patch only for Linux [1]. The result was that the fix had to provide support for all affected

Re: RFR: JDK-8151674: STW phases at Concurrent GC should count in PerfCounter

Hi, I added a comment to JBS about G1 initial mark. I will upload new webrev after discussing for it. We discussed about it on JBS, and we decided not to count initial mark on G1 to CGC counter. [1] I uploaded new webrev. Could you review it? hotspot: http://cr.openjdk.java.net/~ysuenaga/J

RE: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

Thanks Dmitry for review. I will file CR and let you know once done. Cheleswer -Original Message- From: Dmitry Samersoff Sent: Friday, March 18, 2016 2:35 PM To: Cheleswer Sahu; hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: RFR[9u-dev]: 8151442

Re: RFR(xs): 8151993: Remove inclusion of inline.hpp in log.hpp

Hi Kim, On 03/16/2016 05:13 PM, Kim Barrett wrote: On Mar 16, 2016, at 8:33 AM, Robbin Ehn wrote: Hi, please review this small change. This also change allocation methods. Bug: https://bugs.openjdk.java.net/browse/JDK-8151993/ Webrev: http://cr.openjdk.java.net/~rehn/8151993/webrev/ Thanks!

Re: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

On 18/03/2016 10:03 PM, Cheleswer Sahu wrote: Hi David, -Original Message- From: David Holmes Sent: Friday, March 18, 2016 2:42 PM To: Cheleswer Sahu; hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: RFR[9u-dev]: 8151442: jstack doesn't close quotat

RE: RFR(XS): 8152119: Event-based tracing to allow for tracing Klass definition

Hi David, Thanks for noticing, of course it should go outside the INCLUDE_TRACE macro. I should have checked this better - cheers. Both tracing.hpp and traceMacro.hpp can be unconditionally included, but I think I will just move out the traceMacros.hpp. Agree it will look a bit strange, but ma

Re: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

Hello Cheleswer, It is possible to create a regression test for that? Dmitry On 18.03.2016 10:54, Cheleswer Sahu wrote: Hi, Please review the code changes for https://bugs.openjdk.java.net/browse/JDK-8151442. Webrev Link: http://cr.openjdk.java.net/~csahu/8151442/ Bug Brief: In jstack t

Re: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

David, > Ignoring Dmitry's issue it still seems simpler/cleaner to just add the > desired precision value to the %s than to split into two print > statements. Or bite the bullet now and make the length immaterial by > breaking the name into chunks. It's as easy to fix as to write the > RFE :) For

RFR(S): JDK-8151991 jvmti diagnostics commands requires INCLUDE_SERVICES

Everybody, Please, review small fix. http://cr.openjdk.java.net/~dsamersoff/JDK-8151991/webrev.01/ New diagnostic command (JVMTI.agent_load) should be guarded by #if INCLUDE_SERVICES and don't brake minimal VM build. -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg,

Re: [PATCH] JDK-8036559: Attach API does not allow root to connect to process owned by others

Elliott, I'll take care of the CR. But as soon as the changes have security implication we should carefully evaluate possible side effects. So it takes some time. -Dmitry On 2016-03-17 00:27, Elliott Baron wrote: > Hi, > > I've been working on an updated patch for JDK-8036559, where root doe

Re: RFR: JDK-8151674: STW phases at Concurrent GC should count in PerfCounter

On 3/18/2016 7:14 AM, Yasumasa Suenaga wrote: Hi, I added a comment to JBS about G1 initial mark. I will upload new webrev after discussing for it. We discussed about it on JBS, and we decided not to count initial mark on G1 to CGC counter. [1] I uploaded new webrev. Could you review it?

RFR(XS): 8152119: Event-based tracing to allow for tracing Klass definition

Greetings, Kindly asking for reviews for the following change to allow for tracing Klass definitions. Bug: https://bugs.openjdk.java.net/browse/JDK-8152119 Webrev: http://cr.openjdk.java.net/~mgronlun/8152119/webrev01/ This change complements the change associated with Klass creat