RE: RFR: JDK-8043571: com/sun/jdi/RepStep.java fails in RT_Baseline on all platforms with assert(_cur_stack_depth == count_frames()) failed: cur_stack_depth out of sync

Please hold off on this review (since I might have some modifications to the changes). Regds, Jini. From: Jini George Sent: Monday, April 25, 2016 2:29 PM To: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: RE: RFR: JDK-8043571:

Re: RFR(L): JDK-8154258 [TESTBUG] Various serviceability tests fail compilation

On 25 Apr 2016, at 12:50, Dmitry Samersoff wrote: > Everybody, > > Please review the changes. > > http://cr.openjdk.java.net/~dsamersoff/JDK-8154258/webrev.04/ Thank you Dmitry. Your changes look good to me. As a follow up, it would be nice to refactor the

Re: RFR: JDK-8155089: UL: Remove trailing comma from log decoration list

Yasumasa, Looks good for me. -Dmitry On 2016-04-26 16:08, Yasumasa Suenaga wrote: > Hi all, > > This review request relates [1]. > > We can check log configuration through VM.log list jcmd: > --- > Log output configuration: > #0: stdout vmoperation=debug,safepoint=info uptime,level,tags,

RFR: JDK-8155089: UL: Remove trailing comma from log decoration list

Hi all, This review request relates [1]. We can check log configuration through VM.log list jcmd: --- Log output configuration: #0: stdout vmoperation=debug,safepoint=info uptime,level,tags, #1: stderr all=warning uptime,level,tags, #2: gc.log gc=trace uptime,level,tags, --- Decorators

Re: RFR : JDK-8154166 - java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException

On Mon, Apr 25, 2016 at 9:27 AM, Harsha Wardhana B < harsha.wardhan...@oracle.com> wrote: > Hi, > > Please review below patch to disable concurrent GC option. > http://cr.openjdk.java.net/~hb/8154166/webrev.01/ > I'm sorry to be a PITA, but why it is not possible to use the @require tag? > > >

Re: RFR:8153992 (re-review, missed one file) : Some hotspot tests fail on compact2 due to an unnecessary test library dependency

Alexander, Looks good for me! -Dmitry On 2016-04-26 12:36, Alexander Kulyakhtin wrote: > Hi, > > I've missed one file in the changeset reviewed before, therefore the push > failed and I have to ask for a quick re-review. > > The missing change is here: >

RFR:8153992 (re-review, missed one file) : Some hotspot tests fail on compact2 due to an unnecessary test library dependency

Hi, I've missed one file in the changeset reviewed before, therefore the push failed and I have to ask for a quick re-review. The missing change is here: http://cr.openjdk.java.net/~akulyakh/8153992_02/test/testlibrary/jdk/test/lib/dcmd/FileJcmdExecutor.java.udiff.html I've verified that all

Re: RFR(s) 8154529: some places in the invoke.c that use InvokeRequest* not protected with invokerLock

Hi Severin, It looks good. Thank you for taking care. I can sponsor the fix after it is reviewed. Thanks, Serguei On 4/26/16 01:58, Severin Gehwolf wrote: Hi, Could somebody please review this patch for JDK-8154529. Some methods modifying values pointed to by the InvokeRequest pointer

RFR(s) 8154529: some places in the invoke.c that use InvokeRequest* not protected with invokerLock

Hi, Could somebody please review this patch for JDK-8154529. Some methods modifying values pointed to by the InvokeRequest pointer aren't holding the invokerLock. This can lead to some races. For example between invoker_doInvoke() and threadControl_popFrames(). Perhaps 

Re: RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()

Hi Serguei, Thanks! /Robbin On 04/26/2016 10:48 AM, serguei.spit...@oracle.com wrote: Hi Robin, Looks good. Thanks, Serguei On 4/20/16 04:47, Robbin Ehn wrote: Hi all, please review! print() method was changed in 8154041 to have outputStream argument, this renames print to print_on.

Re: RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()

Hi Robin, Looks good. Thanks, Serguei On 4/20/16 04:47, Robbin Ehn wrote: Hi all, please review! print() method was changed in 8154041 to have outputStream argument, this renames print to print_on. Since JvmtiBreakpoint extends GrowableElement print_on already exists as a virtual const

Re: RFR: JDK-8153191: UL: Separator in VM.log output is redundant

On 2016-04-25 14:54, Yasumasa Suenaga wrote: Thanks Dmitry, If this change is accepted, I will fix as below: - char delimiter = 0; for (...) { printf("%c%s", delimiter, LogDecorators::name(decorator)); delimiter = ','; } - If you make it a char then the string would

Re: RFR: JDK-8153191: UL: Separator in VM.log output is redundant

Hi, On 2016-04-25 14:19, Yasumasa Suenaga wrote: Hi Marcus, Please see http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-March/019237.html for the configuration string issue. It was sent out earlier today. Did you fix for trailing comma from decoration list? Comma for

Re: RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()

Thanks Staffan! /Robbin On 04/26/2016 10:18 AM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 20 apr. 2016, at 13:47, Robbin Ehn wrote: Hi all, please review! print() method was changed in 8154041 to have outputStream argument, this renames print to