Hi,
On 04/26/2016 03:08 PM, Yasumasa Suenaga wrote:
Hi all,
This review request relates [1].
We can check log configuration through VM.log list jcmd:
---
Log output configuration:
#0: stdout vmoperation=debug,safepoint=info uptime,level,tags,
#1: stderr all=warning uptime,level,tags,
#2:
Please hold off on this review (since I might have some modifications to the
changes).
Regds,
Jini.
From: Jini George
Sent: Monday, April 25, 2016 2:29 PM
To: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
Subject: RE: RFR: JDK-8043571: com/sun/jdi/RepStep.java
On 25 Apr 2016, at 12:50, Dmitry Samersoff wrote:
> Everybody,
>
> Please review the changes.
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8154258/webrev.04/
Thank you Dmitry. Your changes look good to me.
As a follow up, it would be nice to refactor the current testlibrary so
that the Un
Yasumasa,
Looks good for me.
-Dmitry
On 2016-04-26 16:08, Yasumasa Suenaga wrote:
> Hi all,
>
> This review request relates [1].
>
> We can check log configuration through VM.log list jcmd:
> ---
> Log output configuration:
> #0: stdout vmoperation=debug,safepoint=info uptime,level,tags,
>
Hi all,
This review request relates [1].
We can check log configuration through VM.log list jcmd:
---
Log output configuration:
#0: stdout vmoperation=debug,safepoint=info uptime,level,tags,
#1: stderr all=warning uptime,level,tags,
#2: gc.log gc=trace uptime,level,tags,
---
Decorators
Hi Serguei,
On Tue, 2016-04-26 at 02:35 -0700, serguei.spit...@oracle.com wrote:
> Hi Severin,
>
> It looks good.
> Thank you for taking care.
> I can sponsor the fix after it is reviewed.
Thanks for the review!
The hg exported changeset is here:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK
On Mon, Apr 25, 2016 at 9:27 AM, Harsha Wardhana B <
harsha.wardhan...@oracle.com> wrote:
> Hi,
>
> Please review below patch to disable concurrent GC option.
> http://cr.openjdk.java.net/~hb/8154166/webrev.01/
>
I'm sorry to be a PITA, but why it is not possible to use the @require tag?
>
>
>
Dmitry,
Thank you very much for the review.
Best regards,
Alexander
- Original Message -
From: dmitry.samers...@oracle.com
To: alexander.kulyakh...@oracle.com, serviceability-dev@openjdk.java.net
Sent: Tuesday, April 26, 2016 1:12:56 PM GMT +03:00 Iraq
Subject: Re: RFR:8153992 (re-review
Alexander,
Looks good for me!
-Dmitry
On 2016-04-26 12:36, Alexander Kulyakhtin wrote:
> Hi,
>
> I've missed one file in the changeset reviewed before, therefore the push
> failed and I have to ask for a quick re-review.
>
> The missing change is here:
> http://cr.openjdk.java.net/~akulyakh
Hi,
I've missed one file in the changeset reviewed before, therefore the push
failed and I have to ask for a quick re-review.
The missing change is here:
http://cr.openjdk.java.net/~akulyakh/8153992_02/test/testlibrary/jdk/test/lib/dcmd/FileJcmdExecutor.java.udiff.html
I've verified that all t
Hi Severin,
It looks good.
Thank you for taking care.
I can sponsor the fix after it is reviewed.
Thanks,
Serguei
On 4/26/16 01:58, Severin Gehwolf wrote:
Hi,
Could somebody please review this patch for JDK-8154529. Some methods
modifying values pointed to by the InvokeRequest pointer aren't
Hi Marcus,
If you make it a char then the string would be null terminated right in the
beginning.
Oh, thanks!
I will merge Dmitry's suggestion in this change request.
Thanks,
Yasumasa
On 2016/04/26 17:39, Marcus Larsson wrote:
On 2016-04-25 14:54, Yasumasa Suenaga wrote:
Thanks Dmitr
Hi,
Could somebody please review this patch for JDK-8154529. Some methods
modifying values pointed to by the InvokeRequest pointer aren't holding
the invokerLock. This can lead to some races. For example between
invoker_doInvoke() and threadControl_popFrames().
Perhaps com/sun/jdi/PopAndInvokeTes
Hi Serguei,
Thanks!
/Robbin
On 04/26/2016 10:48 AM, serguei.spit...@oracle.com wrote:
Hi Robin,
Looks good.
Thanks,
Serguei
On 4/20/16 04:47, Robbin Ehn wrote:
Hi all, please review!
print() method was changed in 8154041 to have outputStream argument,
this renames print to print_on.
Sinc
Hi Robin,
Looks good.
Thanks,
Serguei
On 4/20/16 04:47, Robbin Ehn wrote:
Hi all, please review!
print() method was changed in 8154041 to have outputStream argument,
this renames print to print_on.
Since JvmtiBreakpoint extends GrowableElement print_on already exists
as a virtual const met
On 2016-04-25 14:54, Yasumasa Suenaga wrote:
Thanks Dmitry,
If this change is accepted, I will fix as below:
-
char delimiter = 0;
for (...) {
printf("%c%s", delimiter, LogDecorators::name(decorator));
delimiter = ',';
}
-
If you make it a char then the string would
Hi,
On 2016-04-25 14:19, Yasumasa Suenaga wrote:
Hi Marcus,
Please see
http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-March/019237.html
for the configuration string issue. It was sent out earlier today.
Did you fix for trailing comma from decoration list?
Comma for decorat
Thanks Staffan!
/Robbin
On 04/26/2016 10:18 AM, Staffan Larsen wrote:
Looks good!
Thanks,
/Staffan
On 20 apr. 2016, at 13:47, Robbin Ehn wrote:
Hi all, please review!
print() method was changed in 8154041 to have outputStream argument, this
renames print to print_on.
Since JvmtiBreakpoin
Looks good!
Thanks,
/Staffan
> On 20 apr. 2016, at 13:47, Robbin Ehn wrote:
>
> Hi all, please review!
>
> print() method was changed in 8154041 to have outputStream argument, this
> renames print to print_on.
> Since JvmtiBreakpoint extends GrowableElement print_on already exists as a
> vir
19 matches
Mail list logo
