Jigsaw Enhancement RFR round #2: 8159147 Add ClassLoader parameter to new ClassFileTransformer transform method

2016-06-29 Thread serguei.spit...@oracle.com
Please, review the Jigsaw fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8159147 Just a sanity check is needed. This update has fixes related to the Mandy's comments on the ClassFileTransformer.java: - one of the @implSpec statements is corrected - null has been replaced

Re: Jigsaw Enhancement RFR round #1: 8156147 Add ClassLoader parameter to new ClassFileTransformer transform method

2016-06-29 Thread serguei.spit...@oracle.com
It occurred the bug id in subject has a typo: 8156147 => 8159147. I will send the RFR round #2 with the correct bug id. Thanks, Serguei On 6/29/16 17:12, Mandy Chung wrote: On Jun 29, 2016, at 4:39 PM, serguei.spit...@oracle.com wrote: On 6/29/16 15:47, serguei.spit...@oracle.com wrote: Hi

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

2016-06-29 Thread serguei.spit...@oracle.com
On 6/29/16 19:07, Daniel D. Daugherty wrote: On 6/29/16 6:21 PM, serguei.spit...@oracle.com wrote: Hi Dan, On 6/29/16 07:59, Daniel D. Daugherty wrote: On 6/29/16 2:53 AM, serguei.spit...@oracle.com wrote: On 6/29/16 01:45, Jesper Wilhelmsson wrote: 29 juni 2016 kl. 04:30 skrev David Holmes

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

2016-06-29 Thread Daniel D. Daugherty
On 6/29/16 6:21 PM, serguei.spit...@oracle.com wrote: Hi Dan, On 6/29/16 07:59, Daniel D. Daugherty wrote: On 6/29/16 2:53 AM, serguei.spit...@oracle.com wrote: On 6/29/16 01:45, Jesper Wilhelmsson wrote: 29 juni 2016 kl. 04:30 skrev David Holmes : On 29/06/2016 12:09 PM, serguei.spit...@ora

Re: Jigsaw Enhancement RFR round #1: 8156147 Add ClassLoader parameter to new ClassFileTransformer transform method

2016-06-29 Thread serguei.spit...@oracle.com
On 6/29/16 17:12, Mandy Chung wrote: On Jun 29, 2016, at 4:39 PM, serguei.spit...@oracle.com wrote: On 6/29/16 15:47, serguei.spit...@oracle.com wrote: Hi Mandy, Thank you for the review and comments. Nice catch on the @impleSpec. I'll make the changes. Thanks, Serguei On 6/29/16 12:45, Man

Re: Jigsaw Enhancement RFR round #1: 8156147 Add ClassLoader parameter to new ClassFileTransformer transform method

2016-06-29 Thread Mandy Chung
> On Jun 29, 2016, at 4:39 PM, serguei.spit...@oracle.com wrote: > > On 6/29/16 15:47, serguei.spit...@oracle.com wrote: >> Hi Mandy, >> >> Thank you for the review and comments. >> Nice catch on the @impleSpec. >> I'll make the changes. >> >> Thanks, >> Serguei >> >> >> On 6/29/16 12:45, Man

Re: Jigsaw Enhancement RFR round #1: 8156147 Add ClassLoader parameter to new ClassFileTransformer transform method

2016-06-29 Thread serguei.spit...@oracle.com
On 6/29/16 15:47, serguei.spit...@oracle.com wrote: Hi Mandy, Thank you for the review and comments. Nice catch on the @impleSpec. I'll make the changes. Thanks, Serguei On 6/29/16 12:45, Mandy Chung wrote: On Jun 28, 2016, at 4:06 AM, serguei.spit...@oracle.com wrote: Please, review the Ji

Re: Jigsaw Enhancement RFR round #1: 8156147 Add ClassLoader parameter to new ClassFileTransformer transform method

2016-06-29 Thread serguei.spit...@oracle.com
Hi Mandy, Thank you for the review and comments. Nice catch on the @impleSpec. I'll make the changes. Thanks, Serguei On 6/29/16 12:45, Mandy Chung wrote: On Jun 28, 2016, at 4:06 AM, serguei.spit...@oracle.com wrote: Please, review the Jigsaw fix for the enhancement: https://bugs.openjdk

Re: Jigsaw Enhancement RFR round #1: 8156147 Add ClassLoader parameter to new ClassFileTransformer transform method

2016-06-29 Thread Mandy Chung
> On Jun 28, 2016, at 4:06 AM, serguei.spit...@oracle.com wrote: > > Please, review the Jigsaw fix for the enhancement: > https://bugs.openjdk.java.net/browse/JDK-8159147 > > > Jdk webrev: > > http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8159147-Jigsaw-jli.jdk1/ > ClassFileTran

RFR(S): JDK-8159925 sun/tools/jps/TestJpsJar.java still fails after fix for JDK-8153278

2016-06-29 Thread Dmitry Samersoff
Everybody, Please review the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8159925/webrev.01/ The problem: If you run the test from symlinked location user.dir and the output of jps -l may not match to the value returned by File.getAbsolutePath() for the same jar file. Solution: Skip

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

2016-06-29 Thread Daniel D. Daugherty
On 6/29/16 2:53 AM, serguei.spit...@oracle.com wrote: On 6/29/16 01:45, Jesper Wilhelmsson wrote: 29 juni 2016 kl. 04:30 skrev David Holmes : On 29/06/2016 12:09 PM, serguei.spit...@oracle.com wrote: On 6/28/16 18:44, David Holmes wrote: On 29/06/2016 7:09 AM, serguei.spit...@oracle.com wrote

RFR:8153978 :New test to verify the modules info as returned by the JVMTI ((re-review)

2016-06-29 Thread Alexander Kulyakhtin
Sergey, Could you, please, re-review the new test you have already reviewed and approved before. I had to change Module.empty() to Module.of() due to the changes in the APIs. Otherwise the test is the same as before. CR: https://bugs.openjdk.java.net/browse/JDK-8153978 "New test to verify the

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

2016-06-29 Thread serguei.spit...@oracle.com
On 6/29/16 01:45, Jesper Wilhelmsson wrote: 29 juni 2016 kl. 04:30 skrev David Holmes : On 29/06/2016 12:09 PM, serguei.spit...@oracle.com wrote: On 6/28/16 18:44, David Holmes wrote: On 29/06/2016 7:09 AM, serguei.spit...@oracle.com wrote: On 6/28/16 14:02, Daniel D. Daugherty wrote: On 6/2

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

2016-06-29 Thread Jesper Wilhelmsson
29 juni 2016 kl. 04:30 skrev David Holmes : > >> On 29/06/2016 12:09 PM, serguei.spit...@oracle.com wrote: >>> On 6/28/16 18:44, David Holmes wrote: On 29/06/2016 7:09 AM, serguei.spit...@oracle.com wrote: > On 6/28/16 14:02, Daniel D. Daugherty wrote: >> On 6/28/16 2:11 PM, serguei.s