Re: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-07-13 Thread David Holmes
On 13/07/2016 9:06 PM, Mandy Chung wrote: On Jul 13, 2016, at 6:56 PM, Amit Sapre wrote: Hello, Please review the fix Bug ID : https://bugs.openjdk.java.net/browse/JDK-8151099 Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8151099/webrev.00/ Looks okay. You

Re: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-07-13 Thread Mandy Chung
> On Jul 13, 2016, at 6:56 PM, Amit Sapre wrote: > > Hello, > Please review the fix > > Bug ID : https://bugs.openjdk.java.net/browse/JDK-8151099 > Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8151099/webrev.00/ Looks okay. You could rename the method to

RFR : JDK-8158350 Table in ThreadInfo.from(CompositeData) may need updates for new stack trace attributes

2016-07-13 Thread Amit Sapre
Hello, Please review the javadoc update Bug ID : https://bugs.openjdk.java.net/browse/JDK-8158350 webrev : http://cr.openjdk.java.net/~hb/sponsorship/8158350/webrev.01/ Amit

RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-07-13 Thread Amit Sapre
Hello, Please review the fix Bug ID : https://bugs.openjdk.java.net/browse/JDK-8151099 Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8151099/webrev.00/ Amit