Re: RFR : 8131061 - Use of -Dcom.sun.management.snmp needs to be examined for modules

2016-08-24 Thread Harsha Wardhana B
Hi All, Please review modified webrev located at, http://cr.openjdk.java.net/~hb/8131061/webrev.02/ Regards Harsha On Wednesday 24 August 2016 11:28 AM, Harsha Wardhana B wrote: On Wednesday 24 August 2016 01:10 AM, Mandy Chung wrote: On Aug 23, 2016, at 8:21 AM, Daniel Fuchs wrote: O

Re: PING: RFR: JDK-8163581: Heap Parameters in HSDB cannot handle G1CollectedHeap

2016-08-24 Thread David Holmes
On 25/08/2016 12:19 AM, Yasumasa Suenaga wrote: Thanks Stefan! I'm waiting a second reviewer. Stefan has covered as the GC aspect (thanks!) I have Reviewed in the more general sense. Thanks, David Yasumasa On 2016/08/24 23:09, Stefan Johansson wrote: Hi Yasumasa, Your change looks goo

Re: RFR:8148103:add more tests for task "Update JDI and JDWP for modules"

2016-08-24 Thread serguei.spit...@oracle.com
Hi Alexander, It is great that you developed a test coverage for this feature. Just wanted to let you know that I'm reviewing your fix now. Did you get any other reviews yet? Thanks, Serguei On 8/12/16 05:55, Alexander Kulyakhtin wrote: Hi, Could you, please, review the following test-only c

Re: PING: RFR: JDK-8163581: Heap Parameters in HSDB cannot handle G1CollectedHeap

2016-08-24 Thread Yasumasa Suenaga
Thanks Stefan! I'm waiting a second reviewer. Yasumasa On 2016/08/24 23:09, Stefan Johansson wrote: Hi Yasumasa, Your change looks good. There might be more information that we want to add here in the future, but this is a good start. I would personally prefer the region info on its own l

Re: PING: RFR: JDK-8163581: Heap Parameters in HSDB cannot handle G1CollectedHeap

2016-08-24 Thread Stefan Johansson
Hi Yasumasa, Your change looks good. There might be more information that we want to add here in the future, but this is a good start. I would personally prefer the region info on its own line, but I don't have a very strong opinion. I can sponsor the change. Thanks, Stefan On 2016-08-23

Re: PING! Re: RFR(XS): JDK-8160923: sun/tools/jps/TestJpsJar.java fails due to ClassNotFoundException: jdk.testlibrary.ProcessTools

2016-08-24 Thread Dmitry Samersoff
Christian, Thank you for the review. Please see updated webrev: http://cr.openjdk.java.net/~dsamersoff/JDK-8160923/webrev.03/ I still have no ideas why this @build construction works with @run driver but doesn't work with @run main/othervm. Is there a chance to have all such knowledge document

Re: RFR: 8163150: SA: CLHSDB printmdo throws an exception with "java.lang.InternalError: missing reason for 22"

2016-08-24 Thread Staffan Larsen
Looks good. Thanks, /Staffan > On 23 aug. 2016, at 19:36, Jini Susan George wrote: > > I need one more reviewer, please ! > > Thanks, > Jini. > >> -Original Message- >> From: Jini Susan George >> Sent: Tuesday, August 23, 2016 11:48 AM >> To: Dmitry Samersoff; serviceability-dev@openj