Re: Fwd: Re: [PATCH] 6822627: NPE at ReferenceTypeImpl.constantPool

Forwarding to the open serviceability mailing list. Thanks, Serguei On 9/1/16 10:17, Dmitry Samersoff wrote: Egor, The fix looks good for me. -Dmitry On 2016-09-01 20:01, serguei.spit...@oracle.com wrote: I hope, we got a review from Dmitry. Dmitry, please, confirm. Thanks, Serguei On

Re: RFR: JDK-8164943: sun/tools/jhsdb/HeapDumpTest failed with Can't find library: /test/lib/share/classes

Sharath, Please remove 30 * @build jdk.testlibrary.* 31 * @build jdk.test.lib.apps.* as well. -Dmitry On 2016-09-01 07:37, Sharath Ballal wrote: > Please review this fix to change /test/lib/share/classes to /test/lib/ > in the test: > > > > Issue:

RE: JDK-8164943: sun/tools/jhsdb/HeapDumpTest failed with Can't find library: /test/lib/share/classes

Hi Sharath, This looks good, thanks for fixing this. Thanks, Christian From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Sharath Ballal Sent: Thursday, September 1, 2016 12:37 AM To: serviceability-dev@openjdk.java.net Subject: RFR:

Re: RFR(S): 8163994: Nightly test crashed in jvmtiAllocate

Thanks, Dmitry! Serguei On 9/1/16 03:55, Dmitry Samersoff wrote: Serguei, OK. Closing as a dup. -Dmitry On 2016-09-01 13:40, serguei.spit...@oracle.com wrote: Hi David, Thank you for the comment. Dmitry, It seems, Chris and David are not comfortable with current fix. Are you Ok to close

Re: RFR(S): 8163994: Nightly test crashed in jvmtiAllocate

Serguei, OK. Closing as a dup. -Dmitry On 2016-09-01 13:40, serguei.spit...@oracle.com wrote: > Hi David, > > Thank you for the comment. > > Dmitry, > > It seems, Chris and David are not comfortable with current fix. > Are you Ok to close this bug as a dup? > > Thanks, > Serguei > > > On

Re: RFR(S): 8163994: Nightly test crashed in jvmtiAllocate

Hi David, Thank you for the comment. Dmitry, It seems, Chris and David are not comfortable with current fix. Are you Ok to close this bug as a dup? Thanks, Serguei On 8/29/16 20:05, David Holmes wrote: Hi Serguei, On 30/08/2016 4:46 AM, serguei.spit...@oracle.com wrote: Chris and David,

Re: RFR: 8161448: 4 JNI exception pending defect groups in DiagnosticCommandImpl.c

On 1/09/2016 6:05 PM, Harsha Wardhana B wrote: Hi David, On Thursday 01 September 2016 01:14 PM, David Holmes wrote: Hi Harsha, Sorry these style issues are proving to be so painful, normally there would be more direct guidance from an existing team member. On 30/08/2016 4:51 PM, Harsha

Re: RFR:(S): 8164562: serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE

On 31/08/2016 1:45 AM, Mandy Chung wrote: Thanks Alejandro. A minor correction - the patch is pushed to jdk9/hs/hotspot which is the right repo to fix this issue. I think that was deliberate - to get both changes in the same repo ASAP. Hotspot testing is offline at the moment so we don't

Re: RFR: JDK-8165114: stale reference to hotspot test Test8028623.java

Looks good! Thanks, /Staffan > On 1 sep. 2016, at 10:00, Sharath Ballal wrote: > > Hello, > Please review this fix to remove stale test reference: > > Issue: https://bugs.openjdk.java.net/browse/JDK-8165114 > >

Re: PING: RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is never null.

On 01/09/2016 07:01, Amit Sapre wrote: Gentle reminder ! Bug Id : https://bugs.openjdk.java.net/browse/JDK-8164730 Webrev : http://cr.openjdk.java.net/~jgeorge/sponsorships/8164730/webrev.00/ Looks okay to me. A

Re: RFR: 8161448: 4 JNI exception pending defect groups in DiagnosticCommandImpl.c

Hi David, On Thursday 01 September 2016 01:14 PM, David Holmes wrote: Hi Harsha, Sorry these style issues are proving to be so painful, normally there would be more direct guidance from an existing team member. On 30/08/2016 4:51 PM, Harsha Wardhana B wrote: Hello, Please find below

RFR: JDK-8165114: stale reference to hotspot test Test8028623.java

Hello, Please review this fix to remove stale test reference: Issue: https://bugs.openjdk.java.net/browse/JDK-8165114 Webrev: http://cr.openjdk.java.net/~sballal/8165114/webrev.00/ -Sharath Ballal

Re: RFR: 8161448: 4 JNI exception pending defect groups in DiagnosticCommandImpl.c

Hi Harsha, Sorry these style issues are proving to be so painful, normally there would be more direct guidance from an existing team member. On 30/08/2016 4:51 PM, Harsha Wardhana B wrote: Hello, Please find below webrev addressing David's and Dmitry's comments.

Re: PING: RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is never null.

Hi Amit, Looks good to me! best regards, -- daniel On 01/09/16 07:01, Amit Sapre wrote: Gentle reminder ! *From:*Amit Sapre *Sent:* Tuesday, August 30, 2016 11:33 AM *To:* serviceability-dev *Subject:* RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is

PING: RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is never null.

Gentle reminder ! From: Amit Sapre Sent: Tuesday, August 30, 2016 11:33 AM To: serviceability-dev Subject: RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is never null. Hello, Please review this small code change and a