> Ok. Let me know what you think now after a bit more explanation.
I'm good with it. Thumbs up!
Dan
On 10/21/16 1:13 PM, Chris Plummer wrote:
Hi Dan,
Thanks for the review. Comments inline below:
On 10/21/16 7:59 AM, Daniel D. Daugherty wrote:
On 10/20/16 2:28 PM, Chris Plummer wrote:
He
Alexander,
Reviewed.
Thanks,
Serguei
On 10/21/16 06:25, Alexander Kulyakhtin wrote:
Hi Dmitry,
Thank you very much for the review/ I've changed the CR title.
Waiting for a (R)eviwer to approve this trivial one-line quarantine.
Best regards,
Alexander
- Original Message -
From: dmi
Hi Dan,
Thanks for the review. Comments inline below:
On 10/21/16 7:59 AM, Daniel D. Daugherty wrote:
On 10/20/16 2:28 PM, Chris Plummer wrote:
Hello,
Please review the following:
http://cr.openjdk.java.net/~cjplummer/8166679/webrev.00/webrev.hotspot/
src/cpu/aarch64/vm/frame_aarch64.cpp
On 10/20/16 2:28 PM, Chris Plummer wrote:
Hello,
Please review the following:
http://cr.openjdk.java.net/~cjplummer/8166679/webrev.00/webrev.hotspot/
src/cpu/aarch64/vm/frame_aarch64.cpp
So we're in a "if (StubRoutines::returns_to_call_stub()" block
and the assumption was that a frame
Looks good!
Thanks,
/Staffan
> On 21 Oct 2016, at 15:25, Alexander Kulyakhtin
> wrote:
>
> Hi Dmitry,
>
> Thank you very much for the review/ I've changed the CR title.
>
> Waiting for a (R)eviwer to approve this trivial one-line quarantine.
>
> Best regards,
> Alexander
>
> - Origina
Hi Dmitry,
Thank you very much for the review/ I've changed the CR title.
Waiting for a (R)eviwer to approve this trivial one-line quarantine.
Best regards,
Alexander
- Original Message -
From: dmitry.dmitr...@oracle.com
To: alexander.kulyakh...@oracle.com
Cc: serviceability-dev@openjd
Thanks Staffan!
/Robbin
On 10/21/2016 03:20 PM, Staffan Larsen wrote:
Looks good!
Thanks,
/Staffan
On 21 Oct 2016, at 14:01, Robbin Ehn wrote:
Hi again.
Correct http webrev location should be:
http://cr.openjdk.java.net/~rehn/8164501/01/webrev/
http://cr.openjdk.java.net/~rehn/8164501/01_
Hi Alexander,
can you please change bug title to "Quarantine AllModulesCommandTest.java
test". The change looks good.
Dmitry
- Original Message -
From: alexander.kulyakh...@oracle.com
To: serviceability-dev@openjdk.java.net
Sent: Friday, October 21, 2016 4:10:41 PM GMT +03:00 Iraq
Subje
Looks good!
Thanks,
/Staffan
> On 21 Oct 2016, at 14:01, Robbin Ehn wrote:
>
> Hi again.
>
> Correct http webrev location should be:
> http://cr.openjdk.java.net/~rehn/8164501/01/webrev/
> http://cr.openjdk.java.net/~rehn/8164501/01_inc/webrev/
>
> /Robbin
>
> On 10/21/2016 01:11 PM, Robbin
Thanks Dmitry,
I'll fix that comment before commit!
/Robbin
On 10/21/2016 02:46 PM, Dmitry Samersoff wrote:
Robbin,
Looks good for me.
Please, fix comment
* The length of the JDWP packet is 11 + data
to
* The length of the JDWP packet is sizeof(pktHeader) + data
-Dmitry
On 2016-10-21 15:
Hi,
Could you, please, review this trivial change (quarantining a test).
CR: https://bugs.openjdk.java.net/browse/JDK-8168479 "Backout the changes for
JDK-8168478"
Webrev: http://cr.openjdk.java.net/~akulyakh/8168479/
The test is being quarantining due to
https://bugs.openjdk.java.net/browse/J
Robbin,
Looks good for me.
Please, fix comment
* The length of the JDWP packet is 11 + data
to
* The length of the JDWP packet is sizeof(pktHeader) + data
-Dmitry
On 2016-10-21 15:01, Robbin Ehn wrote:
> Hi again.
>
> Correct http webrev location should be:
> http://cr.openjdk.java.net/~rehn
Hi again.
Correct http webrev location should be:
http://cr.openjdk.java.net/~rehn/8164501/01/webrev/
http://cr.openjdk.java.net/~rehn/8164501/01_inc/webrev/
/Robbin
On 10/21/2016 01:11 PM, Robbin Ehn wrote:
Hi Staffan, thanks for having a look.
On 10/21/2016 11:28 AM, Staffan Larsen wrote:
Hi Staffan, thanks for having a look.
On 10/21/2016 11:28 AM, Staffan Larsen wrote:
Can you change:
185 if (total_length < 11) {
to
185 if (total_length < sizeof(pktHeader) {
?
Yes, I'll then propose changing all 11 to sizeof(pktHeader).
Full: http://rehn-ws.se.oracle.com/cr_mirro
Can you change:
185 if (total_length < 11) {
to
185 if (total_length < sizeof(pktHeader) {
?
> On 21 Oct 2016, at 09:41, Robbin Ehn wrote:
>
> Hi all, please review!
>
> This patch makes sure pktHeader is not used uninitialized and that
> total_length is at least 11.
> The bug is
Everybody,
Please review a small modification of the fix for JDK-8134434:
http://cr.openjdk.java.net/~dsamersoff/JDK-8165496/webrev.04/
Its' possible that we come to rethrow_C when _exception_caught is
already cleared. We need not to set exception_detected in this
case.
-Dmitry
--
Dmitry Same
Hi all, please review!
This patch makes sure pktHeader is not used uninitialized and that total_length
is at least 11.
The bug is confidential, but subject and patch says alot.
Bug: https://bugs.openjdk.java.net/browse/JDK-8164501
Webrev: http://cr.openjdk.java.net/~rehn/8164501/webrev/
Thanks
17 matches
Mail list logo
