Re: RFR(S): JDK-8165496 assert(_exception_caught == false) failed: _exception_caught is out of phase

2016-10-25 Thread serguei.spit...@oracle.com
Hi Dmitry, Sorry, I do not see how this fixes the problem. What are you trying to solve by calling the set_exception_detected() conditionally? The _exception_detected flag at that point has to be set anyway, right? The root cause of this issue is that the assert is unreasonable and does not

RFR(XS): 8168662: Intrinsic support for event based tracing needs explicit control dependency

2016-10-25 Thread Markus Gronlund
Greetings, I recently integrated intrinsic support for event based tracing which was tracked in JDK-8166806 (https://bugs.openjdk.java.net/browse/JDK-8166806 ). Unfortunately, the changes for 8166806 led to issues seen in testing on SPARC and AARCH64 platforms in that the intrinsic code

Re: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-10-25 Thread Mandy Chung
+1 Mandy > On Oct 25, 2016, at 2:45 AM, Amit Sapre wrote: > > Thanks Mandy for the review. I incorporated your comments and updated changes > are available in this webrev. > http://cr.openjdk.java.net/~asapre/webrev/8151099/webrev.02/ > > PS: Also updated copyright

Re: RFR(XS): 8165881 - Backout JDK-8164913

2016-10-25 Thread Dmitry Samersoff
Yasumasa, > Should I change the Assignee on JBS (JDK-8165869) to you? Yes. Please do it. -Dmitry On 2016-10-25 12:29, Yasumasa Suenaga wrote: > Hi Dmitry, > >> It's hard to fix this issue without access to Oracle testing >> infrastructure. > > Agree. > I'm not an Oracle employee. Thus I

Re: RFR(XS): 8165881 - Backout JDK-8164913

2016-10-25 Thread David Holmes
On 25/10/2016 7:28 PM, Yasumasa Suenaga wrote: Hi David, The completion status will be 0 because we did manage to communicate with the target VM and process the DCmd request. It passes sis back up to the caller. So looking at JCmd.java I see: try (InputStream in =

RE: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-10-25 Thread Amit Sapre
Thanks Mandy for the review. I incorporated your comments and updated changes are available in this webrev. http://cr.openjdk.java.net/~asapre/webrev/8151099/webrev.02/ PS: Also updated copyright year for all modified files. Amit > -Original Message- > From: Mandy Chung > Sent:

Re: RFR(XS): 8165881 - Backout JDK-8164913

2016-10-25 Thread Yasumasa Suenaga
Hi Dmitry, It's hard to fix this issue without access to Oracle testing infrastructure. Agree. I'm not an Oracle employee. Thus I cannot access it. Should I change the Assignee on JBS (JDK-8165869) to you? Thanks, Yasumasa On 2016/10/25 15:09, Dmitry Samersoff wrote: Yasumasa, It's

Re: RFR(XS): 8165881 - Backout JDK-8164913

2016-10-25 Thread Dmitry Samersoff
Yasumasa, It's hard to fix this issue without access to Oracle testing infrastructure. I'm working on the issue but unfortunately I was caught by some internal problems so it progresses slowly than I expected. I'm sorry about it. -Dmitry On 2016-10-24 13:24, Yasumasa Suenaga wrote: > Hi