RFR[S] 8179769 serviceability/sa/TestCpoolForInvokeDynamic.java failing after changes for JDK-8171392

2017-05-11 Thread Ioi Lam
https://bugs.openjdk.java.net/browse/JDK-8179769 http://cr.openjdk.java.net/~iklam/jdk10/8179769-sa-cp-failures.v01/ Summary: In JDK-8171392 ( Move Klass pointers outside of ConstantPool entries so ConstantPool can be read-only), I changed how classes are stored in ConstantPool. However, I mis

Re: RFR: JDK-8179631: Fix Html5 errors in java.management, jdk.management, jdk.jdi and jdk.attach

2017-05-11 Thread Mandy Chung
> On May 10, 2017, at 11:35 AM, Kumar Srinivasan > wrote: > > Hi All, > > Please review fixes to make the API doc comments HTML5 clean, > there are no changes to the verbiage, and mostly fixes for the table > styles defined here: > http://hg.openjdk.java.net/jdk9/dev/langtools/rev/ee84b7d4433

Re: RFR: JDK-8179631: Fix Html5 errors in java.management, jdk.management, jdk.jdi and jdk.attach

2017-05-11 Thread Kumar Srinivasan
Hello, Ping!. Lets wrap this up soon, as we have to move to the next steps in the docs related work. Thanks Kumar Hi All, Please review fixes to make the API doc comments HTML5 clean, there are no changes to the verbiage, and mostly fixes for the table styles defined here: http://hg.openjdk

Re: RFR: JDK-8173664: Typo in https://java.net/downloads/heap-snapshot/hprof-binary-format.html

2017-05-11 Thread David Holmes
Looks good. Thanks, David On 11/05/2017 7:33 PM, Fairoz Matte wrote: Hi, Please find the updated webrev with suggested changes Webrev - http://cr.openjdk.java.net/~rpatil/8173664/webrev.01/ BugID: https://bugs.openjdk.java.net/browse/JDK-8173664 Thanks, Fairoz -Original Message- Fro

RE: RFR: JDK-8173664: Typo in https://java.net/downloads/heap-snapshot/hprof-binary-format.html

2017-05-11 Thread Fairoz Matte
Hi, Please find the updated webrev with suggested changes Webrev - http://cr.openjdk.java.net/~rpatil/8173664/webrev.01/ BugID: https://bugs.openjdk.java.net/browse/JDK-8173664 Thanks, Fairoz > -Original Message- > From: Fairoz Matte > Sent: Thursday, May 11, 2017 9:05 AM > To: David Ho

Re: RFR(M): JDK-8061228 Allow JDWP socket connector to accept connections from certain ip addresses only

2017-05-11 Thread Robbin Ehn
Hi, I find both your approaches acceptable regarding the version and StartListening11 vs AllowPeers. Personally I prefer not using version instead using sizeof as syscall does. E.g. http://man7.org/linux/man-pages/man2/bind.2.html But obviously this also require a new StartListeningXX method.