Re: Low-Overhead Heap Profiling

2017-05-16 Thread JC Beyler
Dear Robbin, Thank you for the answers, much appreciated :) Jc On Tue, May 16, 2017 at 5:20 AM, Robbin Ehn wrote: > Just a few answers, > > On 05/15/2017 06:48 PM, JC Beyler wrote: > >> Dear all, >> >> I've updated the webrev to: >>

Re: Low-Overhead Heap Profiling

2017-05-16 Thread Robbin Ehn
Just a few answers, On 05/15/2017 06:48 PM, JC Beyler wrote: Dear all, I've updated the webrev to: http://cr.openjdk.java.net/~rasbold/8171119/webrev.02/ I'll look at this later, thanks! Robbin, I believe I have addressed most of

Re: RFR : (JDK9) JDK-8179700 : Exceptions thrown in StartManagementAgent.java

2017-05-16 Thread Daniel Fuchs
Hi Amit, Can you point to the changeset (or the reason) which caused the exception to change? I'd like to make sure we don't have some regression lurking here... best regards, -- daniel On 16/05/2017 09:45, Amit Sapre wrote: Hello, Please review this trivial fix to StartManagementAgent

RFR : (JDK9) JDK-8179700 : Exceptions thrown in StartManagementAgent.java

2017-05-16 Thread Amit Sapre
Hello, Please review this trivial fix to StartManagementAgent test case. Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8179700/webrev.00/ Bug ID : https://bugs.openjdk.java.net/browse/JDK-8179700 Thanks, Amit