Re: [10] RFR 8181647: jhsdb jstack could not output thread name

2017-07-03 Thread chihiro ito
Hi Yasumasa, Thank you for review, again. According to JavaThread::print_on() in thread.cpp , stack address in thread dump shows top of page address. If so, can we calculate it as below? this.getLastJavaSP().andWithMask(~0xFFF) Yes, It is also correct. I modified source code to your simp

Re: Low-Overhead Heap Profiling

2017-07-03 Thread Thomas Schatzl
Hi,   here's a first cut of my thoughts of the latest changes. The compilation problems (at the bottom) prevented me to dig further into it a bit. Please strongly consider providing incremental webrevs, it takes some effort to find changes otherwise. On Tue, 2017-06-27 at 15:04 -0700, JC Beyler

Re: Low-Overhead Heap Profiling

2017-07-03 Thread Thomas Schatzl
Hi, On Wed, 2017-06-28 at 09:51 +0200, Robbin Ehn wrote: > Hi, > > On 06/21/2017 10:45 PM, JC Beyler wrote: > > > > Hi all, > > > > First off: Thanks again to Robbin and Thomas for their reviews :) > > > > Next, I've uploaded a new webrev: > > http://cr.openjdk.java.net/~rasbold/8171119/webrev

RE: RFR 8183123 : JDP packets have no processId context set

2017-07-03 Thread Langer, Christoph
Hi, Ping: Can we please get another review for this rather small JDK 10 fix? Thanks Christoph From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Andrew Leonard Sent: Donnerstag, 29. Juni 2017 15:57 To: serviceability-dev@openjdk.java.net Subject: RFR 818