[10] RFR: 8185164: GetOwnedMonitorInfo() returns incorrect owned monitor

2017-07-24 Thread Yasumasa Suenaga
Hi all, I tried to get owned monitors in MonitorContendedEnter JVMTI event handler. However GetOwnedMonitorInfo JVMTI function returns a monitor which is not yet owned. I attached reproducer to JBS. Please read README.md. I think GetOwnedMonitorInfo() should not return a pending monitor. I

RFR: JDK-8185154: jdwp-protocol.html contains unescaped entities

2017-07-24 Thread Jonathan Gibbons
Please review a simple fix to escape use of the < character in HTML fragments in the JDWP spec. In each case, the < is simply replaced by . JBS: https://bugs.openjdk.java.net/browse/JDK-8185154 Webrev: http://cr.openjdk.java.net/~jjg/8185154/webrev.00/make/data/jdwp/jdwp.spec.sdiff.html --

Re: RFR: JDK-8181895 javax management docs contain links to technotes

2017-07-24 Thread Roger Riggs
Hi Ujwal, The updated links look fine. Thanks, Roger On 7/24/2017 1:48 PM, Ujwal Vangapally wrote: Thanks for the review Roger. please see the webrev incorporating review comments. http://cr.openjdk.java.net/~uvangapally/webrev/2017/8181895/webrev.01/ -Ujwal. On 7/20/2017 2:16 AM, Roger

Re: RFR: JDK-8181895 javax management docs contain links to technotes

2017-07-24 Thread Ujwal Vangapally
Thanks for the review Roger. please see the webrev incorporating review comments. http://cr.openjdk.java.net/~uvangapally/webrev/2017/8181895/webrev.01/ -Ujwal. On 7/20/2017 2:16 AM, Roger Riggs wrote: Hi Ujwal, As Alan noted earlier, it would be helpful in the package javadoc of

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

2017-07-24 Thread Shafi Ahmad
Hi, > -Original Message- > From: Langer, Christoph [mailto:christoph.lan...@sap.com] > Sent: Monday, July 17, 2017 9:01 PM > To: Poonam Parhar > Cc: Shafi Ahmad ; serviceability- > d...@openjdk.java.net > Subject: RE: [10] RFR for

RFR(XS): 8185112: [TESTBUG] Servicability tests cannot parse float if non US locale.

2017-07-24 Thread Lindenmaier, Goetz
Hi, Some tests use Float.valueOf for String to float converting. If an other locale than US is used the test failed. We observed this on Mac. Changed to use NumberFormat to work with all locales. Please review this change. I please need a sponsor.