Re: RFR(S): [testbug] add @requires vm.cds to CDS tests in jdk test suite

2017-08-28 Thread David Holmes
Hi Goetz, On 28/08/2017 5:57 PM, Lindenmaier, Goetz wrote: Hi David, thanks for looking at my change! Should JDK-8185436 have made the changes to TEST.ROOT? I don't understand all the changes that have been added there. Did JDK-8185436 make VMProps.java dependent on WhitBox API but not provid

Re: RFR(M): 8061228 Allow JDWP socket connector to accept connections from certain ip addresses only

2017-08-28 Thread serguei.spit...@oracle.com
Hi Dan, Thank you a lot for review! On 8/28/17 11:00, Daniel D. Daugherty wrote: Resending with Dmitry's e-mail address included. Please delete the previous version. On 8/22/17 5:22 PM, serguei.s

Re: RFR(M): 8061228 Allow JDWP socket connector to accept connections from certain ip addresses only

2017-08-28 Thread serguei.spit...@oracle.com
On 8/28/17 12:41, Daniel D. Daugherty wrote: On 8/28/17 1:37 PM, serguei.spit...@oracle.com wrote: On 8/28/17 12:17, Daniel D. Daugherty wrote: On 8/22/17 5:22 PM, serguei.spit...@oracle.com wrote:

Re: RFR(M): 8061228 Allow JDWP socket connector to accept connections from certain ip addresses only

2017-08-28 Thread Daniel D. Daugherty
On 8/28/17 1:37 PM, serguei.spit...@oracle.com wrote: On 8/28/17 12:17, Daniel D. Daugherty wrote: On 8/22/17 5:22 PM, serguei.spit...@oracle.com wrote: Please, review another revision of the fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8061228 CSR: https://bugs.openjdk.ja

Re: RFR(M): 8061228 Allow JDWP socket connector to accept connections from certain ip addresses only

2017-08-28 Thread serguei.spit...@oracle.com
On 8/28/17 12:17, Daniel D. Daugherty wrote: On 8/22/17 5:22 PM, serguei.spit...@oracle.com wrote: Please, review another revision of the fix for the enhancement:   https://bugs.openjdk.java.net/browse/JDK-8061228

Re: RFR(M): 8061228 Allow JDWP socket connector to accept connections from certain ip addresses only

2017-08-28 Thread Daniel D. Daugherty
On 8/22/17 5:22 PM, serguei.spit...@oracle.com wrote: Please, review another revision of the fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8061228 CSR: https://bugs.openjdk.java.net/browse/CCC-8061228   The SCR is in the DRAFT state.   Joe suggested to consider this CSR appr

Re: RFR: JDK-8185003 JMX: Add a version of ThreadMXBean.dumpAllThreads with a maxDepth argument

2017-08-28 Thread mandy chung
On 8/28/17 10:40 AM, Ujwal Vangapally wrote: kindly see the updated webrev incorporating review comments. webrev : http://cr.openjdk.java.net/~uvangapally/webrev/2017/8185003/webrev.06/ This version looks good. Minor Nit: 52 throw new RuntimeException(" more than requ

Re: RFR(M): 8061228 Allow JDWP socket connector to accept connections from certain ip addresses only

2017-08-28 Thread Daniel D. Daugherty
Resending with Dmitry's e-mail address included. Please delete the previous version. On 8/22/17 5:22 PM, serguei.spit...@oracle.com wrote: Please, review another revision of the fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8061228 CSR: https://bugs.openjdk.java.net/browse

Re: RFR(M): 8061228 Allow JDWP socket connector to accept connections from certain ip addresses only

2017-08-28 Thread Daniel D. Daugherty
On 8/22/17 5:22 PM, serguei.spit...@oracle.com wrote: Please, review another revision of the fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8061228 CSR: https://bugs.openjdk.java.net/browse/CCC-8061228   The SCR is in the DRAFT state.   Joe suggested to consider this CSR appr

Re: RFR: JDK-8185003 JMX: Add a version of ThreadMXBean.dumpAllThreads with a maxDepth argument

2017-08-28 Thread Ujwal Vangapally
kindly see the updated webrev incorporating review comments. webrev : http://cr.openjdk.java.net/~uvangapally/webrev/2017/8185003/webrev.06/ Thanks Ujwal On 8/11/2017 11:41 PM, mandy chung wrote: On 8/9/17 10:15 AM, Ujwal Vangapally wrote: Thanks for the review Mandy, kindly see my c

Re: jcmd GC.run to invoke GC fails if -XX:+DisableExplicitGC is set.

2017-08-28 Thread Mikael Gerdin
Hi Kevin, On 2017-08-22 16:38, Kevin Walls wrote: Hi, jcmd GC.run to invoke GC fails if -XX:+DisableExplicitGC is set: this seems like a mistake? This behaviour is obstructive for a live app that _needs_ a GC, and was started with -XX:+DisableExplicitGC. DisableExplicitGC to protect from

RE: RFR(S): [testbug] add @requires vm.cds to CDS tests in jdk test suite

2017-08-28 Thread Lindenmaier, Goetz
Hi David, thanks for looking at my change! > Should JDK-8185436 have made the changes to TEST.ROOT? I don't > understand all the changes that have been added there. Did JDK-8185436 > make VMProps.java dependent on WhitBox API but not provide a means to > actually build VMProps properly?? 8185436