Re: RFR(S): 8186902: jcmd GC.run should not be blocked by DisableExplicitGC

Hi Kevin, It looks good to me. Thanks, Serguei On 8/29/17 04:41, Kevin Walls wrote: Hi, This is a small review request for: 8186902: jcmd GC.run should not be blocked by DisableExplicitGC https://bugs.openjdk.java.net/browse/JDK-8186902 jcmd GC.run to invoke GC fails if -XX:+DisableExplici

Re: RFR: JDK-8186932: Fix accessibility issues in the java.management module

> On Aug 29, 2017, at 1:45 PM, Jonathan Gibbons > wrote: > > Please review these relatively simple changes to fix accessibility issues in > the java.management module. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8186932 > Webrev: http://cr.openjdk.java.net/~jjg/8186932/webrev.00/ > API:

RFR: JDK-8186932: Fix accessibility issues in the java.management module

Please review these relatively simple changes to fix accessibility issues in the java.management module. JBS: https://bugs.openjdk.java.net/browse/JDK-8186932 Webrev: http://cr.openjdk.java.net/~jjg/8186932/webrev.00/ API: http://cr.openjdk.java.net/~jjg/8186932/api.00/java.management-summary.h

RE: Proposal: ModuleReferenceImpl.c to use ReleaseStringUTFChars not jvmtiDeallocate

Hi Steve, There are three development repos for jdk10: client, hs (hotspot) and jdk10. Where changes are submitted depends on the focus of the change. This goes along with the mailing lists it was discussed on. E.g. if you change in the gc, you get reviews on the hotspot-gc-dev mailing list and t

RFR(S): 8186902: jcmd GC.run should not be blocked by DisableExplicitGC

Hi, This is a small review request for: 8186902: jcmd GC.run should not be blocked by DisableExplicitGC https://bugs.openjdk.java.net/browse/JDK-8186902 jcmd GC.run to invoke GC fails if -XX:+DisableExplicitGC is set: this seems like a mistake as it is obstructive for a live app that needs a

RE: Proposal: ModuleReferenceImpl.c to use ReleaseStringUTFChars not jvmtiDeallocate

Hi Christoph / Serguei, I see from the bug that was created that the change has been pushed to a repository. Thanks for this. However, I may be confused as to the delivery/promote strategy for changes as this change was pushed to the 'hs' (hotspot) repository and not the 'jdk10' (Master + d

Re: jcmd GC.run to invoke GC fails if -XX:+DisableExplicitGC is set.

Hi Kevin, On 2017-08-29 11:14, Kevin Walls wrote: Hi Mikael, thanks yes, it could be a separate cmd GC.runForce... However I was thinking if you can get as far as having your jcmd executed, you really _do_ want to run that collection. Whatever behaviour you were protecting against when you

Re: jcmd GC.run to invoke GC fails if -XX:+DisableExplicitGC is set.

Hi Mikael, thanks yes, it could be a separate cmd GC.runForce... However I was thinking if you can get as far as having your jcmd executed, you really _do_ want to run that collection.  Whatever behaviour you were protecting against when you chose the command-line arguments, you would only ev

Re: RFR(M): 8061228 Allow JDWP socket connector to accept connections from certain ip addresses only

Hi Dan, Please, find the updated webrev's here:   http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8061228-jdi-transport.2/   http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8061228-jdi-transport.2.inc/ I think, I've resolved all y