Process::pid may throw SecurityException. You have to wrap the call
with doPrivileged. Process::pid can throw UOE on platform that doesn't
support this operation. RuntimeMXBean::getPid should specify when the
platform does not support this operation.
ProcessIdTest - can you also check if
Thanks for the review Roger, I will correct the copyright date.
Ujwal.
On 10/20/2017 7:37 PM, Roger Riggs wrote:
Hi Ujwal,
Looks fine.
Please correct the copyright date in ProcessIdTest. A new file
usually has only the current year.
Thanks, Roger
On 10/20/17 2:07 AM, Ujwal Vangapally
Hi Ujwal,
Looks fine.
Please correct the copyright date in ProcessIdTest. A new file usually
has only the current year.
Thanks, Roger
On 10/20/17 2:07 AM, Ujwal Vangapally wrote:
kindly see the new webrev incorporating review comments.
webrev:
Alan has hosted the patch for me :
http://cr.openjdk.java.net/~alanb/8189731/webrev/
Regards,
Ben Walsh
-Ben Walsh/UK/IBM wrote: -
To: serviceability-dev@openjdk.java.net
From: Ben Walsh/UK/IBM
Date: 19/10/2017 11:07
Subject: [PATCH] Unnecessary Amount Of Internal Class Conversion
Alan has hosted the patch for me : http://cr.openjdk.java.net/~alanb/8189731/webrev/Regards,Ben Walsh-Ben Walsh/UK/IBM wrote: -To: serviceability-dev@openjdk.java.netFrom: Ben Walsh/UK/IBMDate: 19/10/2017 11:07Subject: [PATCH] Unnecessary Amount Of Internal Class ConversionPer Alan's
kindly see the new webrev incorporating review comments.
webrev:
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.01/
Thanks,
Ujwal.
On 10/11/2017 3:50 PM, Ujwal Vangapally wrote:
Thanks for the review and suggestions Mandy, Roger.
kindly see my comments inline.
On
