Hi David,
My own feeling is that it is up to the OnAttach function to properly deal with
pending exceptions: report and/or clear them. The VM side just has to clear any
pending exception to avoid it causing problems for later code.
I removed the change to print pending exceptions in new web
Hi Dan,
Figured I'd better cast an eye over this again before it gets pushed :)
Only one thing (repeated many times) jumped out at me and apologies if
this has already been debated back and forth. I missed the exchange
where the for loop iteration was rewritten into this unusual form:
for (J
Hi Yasumasa,
I've been trying to leave these reviews to serviceability folk ...
I've gone back through the original RFR from September last year to see
what we did and what was left.
The current proposal raises some concern for me - and IIRC Dmitry was
also concerned about it last time: prin
We are already in a hybrid world of old-style and new-style options :-(
All the new module-related options added in JDK 9 are "new style",
following the guidelines of JEP 293.
It does not make sense to add "--" to some of the older tools, that may
be going away at some point, and while we may
PING:
Could you review it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8165736/webrev.03/
I want to merge this change to jdk 10. So I need a second reviewer.
Yasumasa
On 2017/11/16 21:09, Yasumasa Suenaga wrote:
Hi David, Serguei,
The test logic is adding it in AttachFailedTestBase.ja
PING:
Could you review it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8185796/webrev.04/
I want to merge this change to jdk 10. So I need a reviewer and sponsor.
Yasumasa
On 2017/11/14 9:58, Yasumasa Suenaga wrote:
PING:
Could you review it? We need a reviewer and sponsor.
http:/
