2017/12/02 8:43 "serguei.spit...@oracle.com" :
Hi Yasumasa,
The fix looks good.
Thank you for taking care about this issue.
Thanks Serguei!
One minor:
+throw new RuntimeException("Test ERROR (with -Xcomp=" +
withXcomp + ") "+ ex, ex);
A space is missed before '+ ex'.
No need in
Hi Yasumasa,
The fix looks good.
Thank you for taking care about this issue.
One minor:
+throw new RuntimeException("Test ERROR (with -Xcomp=" + withXcomp + ") "+ ex, ex);
A space is missed before '+ ex'.
No need in new webrev
Hi Sharath,
I confirmed this issue with jshell and ClhsdbJstack with this change.
You need to run the VM in current jdk/hs.
Thanks,
Yasumasa
On 2017/12/02 1:22, Sharath Ballal wrote:
Hi Yasumasa,
I tried jhsdb with a simple HelloWorld (with -Xcomp) and did not see any
exception.
Your app d
Hi Sharath,
It looks good.
Sorry if I'm late.
Thanks,
Serguei
On 12/1/17 03:33, Sharath Ballal wrote:
Can I have one more review please ?
Thanks,
Sharath
-Original Message-
From: Sharath Ballal
Sent: Friday, December 01, 2017 4:21 PM
To: Jini Susan George; serviceability-dev@openjd
Hi Yasumasa,
I tried jhsdb with a simple HelloWorld (with -Xcomp) and did not see any
exception.
Your app does anything else ?
Thanks,
Sharath
-Original Message-
From: Yasumasa Suenaga [mailto:yasue...@gmail.com]
Sent: Friday, December 01, 2017 7:26 PM
To: serviceability-dev@openjdk.ja
Hi Kumar,
I'm already looking at the issues from your other mail.
Detailed comments will follow.
I'll also check and fix the new tests you report.
I think we don't run the langtool tests, i.e. I know
we didn't run them before the repos were
merged. Obviously we should add them to our testing :
Hi,
Besides my private comments to you, there are 2-3 internal tests
which fail.
Have you run all the langtools tests ? There are 4 Windows tests
that fail with langtools:
jdk/javadoc/doclet/testHelpOption/TestHelpOption.java
jdk/javadoc/tool/CheckResourceKeys.java
jdk/javadoc/tool/ToolProvider
Hi all,
I saw NPE when I run jstack on clhsdb as below:
hsdb> jstack
Deadlock Detection:
No deadlocks found.
"NonBlockingInputStreamThread" #27 daemon prio=5 tid=0x7f0924674000
nid=0xf429 in Object.wait() [0x7f08cf6fd000]
java.lang.Thread.State: WAITING (on object
Thank you, Serguei!
- Jini.
On 12/1/2017 4:15 PM, serguei.spit...@oracle.com wrote:
Hi Jini,
New tests look Ok to me.
Thanks,
Serguei
On 12/1/17 00:23, Jini George wrote:
Had missed removing the unused line:
import jdk.test.lib.Platform;
from ClhsdbVmStructsDump.java (Thanks, Sharath, fo
Looks good.
Thanks,
Jini.
On 12/1/2017 4:21 PM, Sharath Ballal wrote:
Hi Jini,
Thanks for the review.
I have done the changes. I have left the file undeleted when there is a
failure.
Update webrev is http://cr.openjdk.java.net/~sballal/8192823/webrev.01/
Earlier the test has passed in JPRT
Can I have one more review please ?
Thanks,
Sharath
-Original Message-
From: Sharath Ballal
Sent: Friday, December 01, 2017 4:21 PM
To: Jini Susan George; serviceability-dev@openjdk.java.net
Subject: RE: RFR: JDK-8192823 - Testcase for 'clhsdb source' command
Hi Jini,
Thanks for the re
Looks good Jini.
Thanks,
Sharath
-Original Message-
From: Jini George
Sent: Friday, December 01, 2017 1:54 PM
To: serviceability-dev@openjdk.java.net
Subject: Re: RFR: JDK-8191538: SA: tests for clhsdb commands: vmstructsdump,
field, symboltable and symbol
Had missed removing the unu
Hi Jini,
Thanks for the review.
I have done the changes. I have left the file undeleted when there is a
failure.
Update webrev is http://cr.openjdk.java.net/~sballal/8192823/webrev.01/
Earlier the test has passed in JPRT and mach5. I will run them again now.
Thanks,
Sharath
-Original Me
Hi Jini,
New tests look Ok to me.
Thanks,
Serguei
On 12/1/17 00:23, Jini George wrote:
Had missed removing the unused line:
import jdk.test.lib.Platform;
from ClhsdbVmStructsDump.java (Thanks, Sharath, for pointing this out).
Revised webrev:
http://cr.openjdk.java.net/~jgeorge/8191538/web
Hi Sharath,
I feel it would be good to have at least 2 commands in the commands
source file. And it would be good to delete the commands source file
once the test has run and passed.
Other than these, it looks good to me.
Thanks,
Jini (Not a Reviewer).
On 12/1/2017 12:23 PM, Sharath Ballal
Had missed removing the unused line:
import jdk.test.lib.Platform;
from ClhsdbVmStructsDump.java (Thanks, Sharath, for pointing this out).
Revised webrev:
http://cr.openjdk.java.net/~jgeorge/8191538/webrev.02/
Thanks,
Jini.
On 12/1/2017 1:40 PM, Jini George wrote:
Thank you, Sharath, for th
Thank you, Sharath, for the review. The modified webrev is at:
http://cr.openjdk.java.net/~jgeorge/8191538/webrev.01/
Could I get one more pair of eyes to take a look at this ?
Thanks,
Jini.
On 11/30/2017 11:35 PM, Sharath Ballal wrote:
Hi Jini,
http://cr.openjdk.java.net/~jgeorge/8191538/
17 matches
Mail list logo
