Re: RFR: 8194143: remove unneeded casts in LocationImpl and MirrorImpl classes

Hi Egor, It occurred you do not have any openJDK status, even an author. So that I've committed and pushed your patch with: Contributed-by: egor.usha...@jetbrains.com Thanks, Serguei On 1/22/18 04:14, Egor Ushakov wrote: Serguei, here is the fixed webrev, sorry for the delay, it took

Re: RFR: JDK-8167253: com.sun.jdi invokeMethod has duplicated @throws for InvalidTypeException

Thanks Gary. The other duplicates were removed by JDK-8179538 "Update jdk.jdi to be HTML-5 friendly" David On 23/01/2018 3:43 AM, Gary Adams wrote: Here's a small fix to remove a duplicate InvalidTypeException. The other reported locations appear to have already been fixed.    Issue:

Re: RFR: 8193710 - jcmd -l and jps commands do not list Java processes running in Docker containers

Thanks Bob. Seems okay. David On 23/01/2018 3:20 AM, Bob Vandette wrote: Please review this change that resolves the detection of Java processes that are running in cgroup based containers. This latest (and hopefully final) update of this fix addresses comments from David Holmes and Mandy

Re: RFR: JDK-8167253: com.sun.jdi invokeMethod has duplicated @throws for InvalidTypeException

Hi Gary, +1 Thanks, Serguei On 1/22/18 11:00, Roger Riggs wrote: Hi Gary, Looks fine, Roger On 1/22/2018 12:43 PM, Gary Adams wrote: Here's a small fix to remove a duplicate InvalidTypeException. The other reported locations appear to have already been fixed.    Issue:

Re: RFR: JDK-8167253: com.sun.jdi invokeMethod has duplicated @throws for InvalidTypeException

Hi Gary, Looks fine, Roger On 1/22/2018 12:43 PM, Gary Adams wrote: Here's a small fix to remove a duplicate InvalidTypeException. The other reported locations appear to have already been fixed.    Issue: https://bugs.openjdk.java.net/browse/JDK-8167253    Webrev:

Re: RFR: 8193710 - jcmd -l and jps commands do not list Java processes running in Docker containers

On 1/22/18 9:20 AM, Bob Vandette wrote: : Webrev: http://cr.openjdk.java.net/~bobv/8193710/webrev.02/ Thanks for the update.  Looks good to me. It would be good to add a comment in PlatformSupport::getInstance to explain that PlatformSupport provides the default implementation that can

RFR: JDK-8167253: com.sun.jdi invokeMethod has duplicated @throws for InvalidTypeException

Here's a small fix to remove a duplicate InvalidTypeException. The other reported locations appear to have already been fixed. Issue: https://bugs.openjdk.java.net/browse/JDK-8167253 Webrev: http://cr.openjdk.java.net/~gadams/8167253/

RFR: 8193710 - jcmd -l and jps commands do not list Java processes running in Docker containers

Please review this change that resolves the detection of Java processes that are running in cgroup based containers. This latest (and hopefully final) update of this fix addresses comments from David Holmes and Mandy Chung. Bug: https://bugs.openjdk.java.net/browse/JDK-8193710 Webrev:

Re: RFR: 8194143: remove unneeded casts in LocationImpl and MirrorImpl classes

Serguei, here is the fixed webrev, sorry for the delay, it took forever to clone the repo. http://cr.openjdk.java.net/~avu/JDK-8194143/webrev.00/ Thanks, Egor On 17-Jan-18 20:37, serguei.spit...@oracle.com wrote: On 1/17/18 09:32, Egor Ushakov wrote: Is the link

Re: RFR: 8194249: SA: G1HeapRegionTable#getByAddress() returns incorrect HeapRegion

Hi Jini, Thank you for your review! I will update the copyright year in this changeset. I'm waiting for Reviewer and sponsor. Yasumasa On 2018/01/22 13:14, Jini George wrote: Hi Yasumasa, The changes look good to me. Please do update the copyright year to 2018. Thanks! Jini (Not a