Re: RFR: JDK-8175312: SA: clhsdb: Provide an improved heap summary for 'universe' for G1GC

2018-02-26 Thread Jini George
Gentle reminder! Thanks, Jini. On 2/14/2018 2:37 PM, Jini George wrote: Hello, (Including the SVC and GC groups) Requesting reviews for enabling the clhsdb 'universe' command to print out the various G1 regions (along with the type). JIRA ID:https://bugs.openjdk.java.net/browse/JDK-8175312

Re: RFR JDK-8198253: ThreadInfo.from(CompositeData) assigning fields incorrectly in JDK 9

2018-02-26 Thread mandy chung
CSR: https://bugs.openjdk.java.net/browse/JDK-8198732 Can you please review? Mandy On 2/23/18 4:50 PM, mandy chung wrote: Webrev at: http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8198253/webrev.01 This patch updates the spec to clarify what attributes are required since which release.

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-26 Thread David Holmes
The two-step send came in with: https://bugs.openjdk.java.net/browse/JDK-6401245 "Small JDWP packets with the socket transport causes slow debugging on linux 2.6.15 kernel and newer" David - On 27/02/2018 9:29 AM, serguei.spit...@oracle.com wrote: On 2/26/18 15:06, Chris Plummer wrote:

Re: RFR JDK-8198253: ThreadInfo.from(CompositeData) assigning fields incorrectly in JDK 9

2018-02-26 Thread mandy chung
On 2/26/18 4:23 PM, Jeremy Manson wrote: Hi Mandy, Thanks for taking this on!  I'm happy to see that you are happy to do cleanups I was too timid to do (like adding the Factory in the tests). I note a few places in the test code where static initializers can throw RuntimeExceptions.  When

Re: Thread Native ID Access

2018-02-26 Thread Jeremy Manson
Okay, I'll find time at some point to tinker with it. I'm going to wait until Mandy lands the fix to JDK-8198253, though. Jeremy On Fri, Feb 23, 2018 at 3:44 PM, Hohensee, Paul wrote: > I am. :) > > > > The process is to file an RFE and then a CSR associated with it. You file > the CSR from th

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-26 Thread serguei.spit...@oracle.com
On 2/26/18 15:06, Chris Plummer wrote: On 2/26/18 3:00 PM, daniil.x.ti...@oracle.com wrote: On 2/26/18 12:16 PM, Chris Plummer wrote: On 2/26/18 11:51 AM, daniil.x.ti...@oracle.com wrote: Hi David and Sergei, On 2/20/18 10:16 PM, serguei.spit...@oracle.com wrote: Hi David, On 2/20/18 20:

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-26 Thread Chris Plummer
On 2/26/18 3:00 PM, daniil.x.ti...@oracle.com wrote: On 2/26/18 12:16 PM, Chris Plummer wrote: On 2/26/18 11:51 AM, daniil.x.ti...@oracle.com wrote: Hi David and Sergei, On 2/20/18 10:16 PM, serguei.spit...@oracle.com wrote: Hi David, On 2/20/18 20:02, David Holmes wrote: Hi Daniil, Goo

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-26 Thread daniil . x . titov
On 2/26/18 12:16 PM, Chris Plummer wrote: On 2/26/18 11:51 AM, daniil.x.ti...@oracle.com wrote: Hi David and Sergei, On 2/20/18 10:16 PM, serguei.spit...@oracle.com wrote: Hi David, On 2/20/18 20:02, David Holmes wrote: Hi Daniil, Good find on this! What does the actual spec say about t

RFR: JDK-8193369: post_field_access does not work for some functions, possibly related to fast_getfield

2018-02-26 Thread Alex Menkov
Hi all, Please review a fix for JDK-8193369: post_field_access does not work for some functions, possibly related to fast_getfield The fix disables "fast" command generation when FieldAccess or FieldModification notifications are requested. jira: https://bugs.openjdk.java.net/browse/JDK-819

Re: 8u: RFR(S): 8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM

2018-02-26 Thread Stephen Fitch
Happy to see this get done (ahead of when I can get to it) feel free to take the JBS backport back into your name Christoph. s. On 2/26/18 11:22 AM, Chris Plummer wrote: I'm not sure the old code was doing anything useful by essentially checking for jdwpMajor == 0. When was it ever zero? Chri

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-26 Thread Chris Plummer
On 2/26/18 11:51 AM, daniil.x.ti...@oracle.com wrote: Hi David and Sergei, On 2/20/18 10:16 PM, serguei.spit...@oracle.com wrote: Hi David, On 2/20/18 20:02, David Holmes wrote: Hi Daniil, Good find on this! What does the actual spec say about the length of things and how they may be spli

Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

2018-02-26 Thread daniil . x . titov
Hi David and Sergei, On 2/20/18 10:16 PM, serguei.spit...@oracle.com wrote: Hi David, On 2/20/18 20:02, David Holmes wrote: Hi Daniil, Good find on this! What does the actual spec say about the length of things and how they may be split across multiple packets? Are we guaranteed that at mo

Re: 8u: RFR(S): 8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM

2018-02-26 Thread Chris Plummer
I'm not sure the old code was doing anything useful by essentially checking for jdwpMajor == 0. When was it ever zero? Chris On 2/26/18 2:28 AM, Volker Simonis wrote: Hi Christoph, I think the new code is wrong for "jdwpMajor == 0", which was correctly handled before. But I'm not sure if tha

Re: RFR JDK-8198253: ThreadInfo.from(CompositeData) assigning fields incorrectly in JDK 9

2018-02-26 Thread mandy chung
On 2/26/18 3:35 AM, Daniel Fuchs wrote: Hi Mandy, Nice to see this fixed. In ThreadInfoCompositeData::initV6CompositeType  425 if (name.equals(STACK_TRACE)) {  426 ot = new ArrayType<>(1, StackTraceElementCompositeData.v5CompositeType());  427   

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

2018-02-26 Thread Erik Helin
Hi Paul, a couple of comments on the patch: - memoryService.hpp: + 150 bool countCollection, + 151 bool allMemoryPoolsAffected = true); There is no need to use a default value for the parameter allMemoryPoolsAffected here. Skipping the default value a

Re: RFR JDK-8198253: ThreadInfo.from(CompositeData) assigning fields incorrectly in JDK 9

2018-02-26 Thread Daniel Fuchs
Hi Mandy, Nice to see this fixed. In ThreadInfoCompositeData::initV6CompositeType 425 if (name.equals(STACK_TRACE)) { 426 ot = new ArrayType<>(1, StackTraceElementCompositeData.v5CompositeType()); 427 } else if (name.equals(LO

Re: 8u: RFR(S): 8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM

2018-02-26 Thread Volker Simonis
Hi Christoph, I think the new code is wrong for "jdwpMajor == 0", which was correctly handled before. But I'm not sure if that is relevant at all nowadays and taking into account that this is a verbatim downport from 9 I don't think we have to do better in 8u. Otherwise looks good from my side.