PING: Re: RFR: JDK-8193369: post_field_access does not work for some functions, possibly related to fast_getfield

2018-03-08 Thread serguei.spit...@oracle.com
Hey guys, One more review is needed for this fix! Thanks, Serguei On 3/5/18 09:58, serguei.spit...@oracle.com wrote: Hi Alex, It looks good. Thank you for the update! Thanks, Serguei On 3/1/18 10:53, Alex Menkov wrote: Hi Serguei, Thank you for the feedback. Updated webrev:

Re: RFR : JDK-8071367 - JMX: Remove SNMP support

2018-03-08 Thread mandy chung
On 3/7/18 11:46 PM, Alan Bateman wrote: On 08/03/2018 07:27, Amit Sapre wrote: Hello, Please review the changes for removing SNMP support. Bug ID : https://bugs.openjdk.java.net/browse/JDK-8071367 Webrev : http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8071367/webrev.00

Re: RFR (XS): 8199010: attachListener.hpp: Fix potential null termination issue found by coverity scans

2018-03-08 Thread Chris Plummer
Hi Christoph, On 3/8/18 3:38 AM, Langer, Christoph wrote: Hi Chris, I went back to the original code in coverity and checked what it complains about. This is the original code: assert(strlen(name) <= name_length_max, "exceeds maximum name length"); strcpy(_name, name); Coverity

RFR: 8199323: hsdis could not be loaded which are located on long path

2018-03-08 Thread Yasumasa Suenaga
Hi all, Could you review and sponsor it? webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8199323/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8199323 Mach5 test result on submit repo: mach5-one-ysuenaga-JDK-8199323-20180308

RE: RFR (XS): 8199010: attachListener.hpp: Fix potential null termination issue found by coverity scans

2018-03-08 Thread Langer, Christoph
Hi Chris, I went back to the original code in coverity and checked what it complains about. This is the original code: assert(strlen(name) <= name_length_max, "exceeds maximum name length"); strcpy(_name, name); Coverity has various issues with this. First, it generally considers

RE: RFR: 8196337 Add commit methods that take all event properties as argument

2018-03-08 Thread Markus Gronlund
Hi Leo, Looks good, thanks for doing this. Sorry for the delay. Cheers Markus -Original Message- From: Leo Korinth Sent: den 13 februari 2018 12:26 To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8196337 Add commit methods that take all