Re: RFR(xxxs): 8203014: jcmd should output command list if no command is given

Thank you, Serguei! On Tue, May 15, 2018, 00:10 serguei.spit...@oracle.com < serguei.spit...@oracle.com> wrote: > Hi Thomas, > > I've added myself as a reviewer. > > Thanks, > Serguei > > > On 5/13/18 22:53, Thomas Stüfe wrote: > > I added a CSR: https://bugs.openjdk.java.net/browse/JDK-8203043 >

[svc] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

This review is being spread across four groups: langtools, core-libs, hotspot and serviceability. This is the specific review thread for serviceability - webrev: http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.serviceability.v1/ See below for full details - including annotated full w

Re: RFR(xxxs): 8203014: jcmd should output command list if no command is given

Hi Thomas, I've added myself as a reviewer. Thanks, Serguei On 5/13/18 22:53, Thomas Stüfe wrote: I added a CSR: https://bugs.openjdk.java.net/browse/JDK-8203043 Best Regards, Thomas On Sat, May 12, 2018 at 10:08 AM, Thomas Stüfe wrote: Hi, may I have reviews for this very small improvem

Re: RFR 8171119: Low-Overhead Heap Profiling

Hi Robbin and all, Thank you for your continuous help! Done then! Here is the new webrev: http://cr.openjdk.java.net/~jcbeyler/8171119/heap_event.20/ and the incremental is: http://cr.openjdk.java.net/~jcbeyler/8171119/heap_event.19_20/ Thanks again all! Jc On Mon, May 14, 2018 at 12:43 PM Ro

Re: RFR 8171119: Low-Overhead Heap Profiling

On 2018-05-14 21:37, JC Beyler wrote: Hi Robbin, I did this then, which should be explicit enough, no?        // If we want to be sampling, protect the allocated object with a Handle       // before doing the callback. The callback is done in the destructor of       // the JvmtiSampledObject

Re: RFR 8171119: Low-Overhead Heap Profiling

Hi JC, On 2018-05-14 17:09, JC Beyler wrote: Hi Robbin, First off: Thanks for looking! There were 3 comments here and I'll try to address all three :) From easy to more difficult: - The thread state keeping a pointer of the collector: yes I agree but it follows the other collector impleme

Re: RFR 8171119: Low-Overhead Heap Profiling

Hi Robbin, First off: Thanks for looking! There were 3 comments here and I'll try to address all three :) >From easy to more difficult: - The thread state keeping a pointer of the collector: yes I agree but it follows the other collector implementations and with Serguei we tried to keep that impl

Re: RFR 8171119: Low-Overhead Heap Profiling

Hi JC, I found a .19 which I looked at: src/hotspot/share/gc/shared/collectedHeap.inline.hpp CollectedHeap::allocate_memory This is the only place I found which calls the ~JvmtiSampledObjectAllocEventCollector It is not intuitive with creating a handle for the destructor, I suggest something li