Re: custom/fast heap dumper

2018-08-22 Thread JC Beyler
For what it's worth, when possible, I think it's easier to use the heap samples to understand leaks (it's often what our users end up doing; ie: hmm why is this heap allocation still remaining live?). You could also dump the heap samples at OOM and/or VM exit. I know it is not always comparable b

Re: custom/fast heap dumper

2018-08-22 Thread Bernd Eckenfels
Hello, I could imagine a fork-and-coredump Approach would be possible. This Limits the application pause to cloning the pagetables (not sure if there is a mode to avoid this). This does however put stress on the virtual Memory (and requires additional ram for the cloned structures). After the

Re: custom/fast heap dumper

2018-08-22 Thread David Holmes
Adding serviceability-dev to get more input. Cheers, David On 23/08/2018 5:58 AM, Ying Su wrote: Hi Krystal, Thank you very much for your valuable input! The online analysis would definitely help in a lot of cases. However there are still some cases getting a heap dump would help or ease the

Re: JDK-8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events

2018-08-22 Thread serguei.spit...@oracle.com
Hi Gary, It looks good. Thanks, Serguei On 8/22/18 09:54, Gary Adams wrote: Updated webrev:   http://cr.openjdk.java.net/~gadams/8034084/webrev.01/index.html On 8/15/18, 8:35 PM, David Holmes wrote: +1 Thanks, David On 15/08/2018 8:41 AM, Alex Menkov wrote: Hi Gary, I think check for Ra

Re: JDK-8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events

2018-08-22 Thread Alex Menkov
looks good. --alex On 08/22/2018 09:54, Gary Adams wrote: Updated webrev:   http://cr.openjdk.java.net/~gadams/8034084/webrev.01/index.html On 8/15/18, 8:35 PM, David Holmes wrote: +1 Thanks, David On 15/08/2018 8:41 AM, Alex Menkov wrote: Hi Gary, I think check for RawMonitorWait error

Re: RFR: JDK-8209604: [TEST] rewrite com/sun/jdi shell tests to java version - step2

2018-08-22 Thread serguei.spit...@oracle.com
Hi Alex, This looks good. Thank you for the update! Thanks, Serguei On 8/21/18 17:10, Alex Menkov wrote: Hi guys, Updated webrev: http://cr.openjdk.java.net/~amenkov/sh2java/step2/webrev.01/ changes (vs initial fix): - Eval*.java tests are updated, common methods are moved into JdbTest; - $

Re: RFR JDK-8170089: nsk/jdi/EventSet/resume/resume008: ERROR: suspendCounts don't match for : Common-Cleaner

2018-08-22 Thread Gary Adams
On 8/6/18, 3:16 PM, Chris Plummer wrote: On 8/6/18 11:41 AM, Gary Adams wrote: On 8/6/18, 1:56 PM, Chris Plummer wrote: On 8/6/18 4:16 AM, Gary Adams wrote: On 8/3/18, 6:38 PM, Chris Plummer wrote: Hi Gary, Overall it looks good. Is the EventHandler.isDisconnected() check needed? This just

Re: JDK-8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events

2018-08-22 Thread Gary Adams
Updated webrev: http://cr.openjdk.java.net/~gadams/8034084/webrev.01/index.html On 8/15/18, 8:35 PM, David Holmes wrote: +1 Thanks, David On 15/08/2018 8:41 AM, Alex Menkov wrote: Hi Gary, I think check for RawMonitorWait error should be moved into the loop or exit loop condition can be up

Re: RFR (S) 8201224: Make string buffer size dynamic

2018-08-22 Thread Ioi Lam
Hi Jc,   79 size_t len;   80 char * result;   81 const char * const format = "%s .%s :" JLONG_FORMAT;   82 char dummy = 0;   83   84 pMN = getMethodName(pJvmtiEnv, method);   85 if ( ! pMN )   86 return strdup("NONE");   87   88 len = snprintf(&dummy, sizeof(du