Hi JC,
I skimmed through this and it seems fine to me.
Thanks,
David
On 11/09/2018 9:13 AM, JC Beyler wrote:
Hi Alex,
Done! Anyone else motivated in looking at part 1 out of 4 to remove all
JNI_ENV* from our vmTestbase tests?
Webrev: http://cr.openjdk.java.net/~jcbeyler/8210385/webrev.01/
Thanks Dean. Sorry I'd already pushed it.
David
On 11/09/2018 9:25 AM, dean.l...@oracle.com wrote:
+1 for this change
+1 for learning new things :-)
dl
On 9/10/18 4:16 PM, serguei.spit...@oracle.com wrote:
I also tried to learn from your email exchange with Dean L.
Thanks,
Serguei
On 9/10
Hi,
Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8210560
webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/redefineClasses1/webrev.01/
New class (ClassTransformer) was developed to implement simple class
transformer for class redefinition (the same functionality as
implem
+1 for this change
+1 for learning new things :-)
dl
On 9/10/18 4:16 PM, serguei.spit...@oracle.com wrote:
I also tried to learn from your email exchange with Dean L.
Thanks,
Serguei
On 9/10/18 15:59, David Holmes wrote:
Thanks for the reviews Serguei and JC.
On 11/09/2018 8:10 AM, JC Beyl
I also tried to learn from your email exchange with Dean L.
Thanks,
Serguei
On 9/10/18 15:59, David Holmes wrote:
Thanks for the reviews Serguei and JC.
On 11/09/2018 8:10 AM, JC Beyler wrote:
Hi David,
Looks good to me (I'm not a reviewer but wanted to piggy-back and say
I actually learnt
Hi Alex,
Done! Anyone else motivated in looking at part 1 out of 4 to remove all
JNI_ENV* from our vmTestbase tests?
Webrev: http://cr.openjdk.java.net/~jcbeyler/8210385/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8210385
Thanks!
Jc
On Fri, Sep 7, 2018 at 2:07 PM Alex Menkov wrote
Thanks for the reviews Serguei and JC.
On 11/09/2018 8:10 AM, JC Beyler wrote:
Hi David,
Looks good to me (I'm not a reviewer but wanted to piggy-back and say I
actually learnt quite a bit with the conversation on the original webrev).
:) I've learnt a few things with these changes too.
Che
Hi David,
Looks good to me (I'm not a reviewer but wanted to piggy-back and say I
actually learnt quite a bit with the conversation on the original webrev).
Thanks!
Jc
On Mon, Sep 10, 2018 at 2:59 PM serguei.spit...@oracle.com <
serguei.spit...@oracle.com> wrote:
> Hi David,
>
> It looks good t
Hi David,
It looks good to me.
Thank you for taking care about it!
Thanks,
Serguei
On 9/10/18 14:31, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8210512
Webrev: http://cr.openjdk.java.net/~dholmes/8210512/webrev/
After the fix for JDK-8209361 where we modified JVM-TI to
Bug: https://bugs.openjdk.java.net/browse/JDK-8210512
Webrev: http://cr.openjdk.java.net/~dholmes/8210512/webrev/
After the fix for JDK-8209361 where we modified JVM-TI to treat an
unresolved CP klass entry to a loaded klass as a resolved CP entry, the
listed test starting failing due to findin
Hi Dean,
I'm withdrawing this RFR and changing to a test-bug.
Thanks for the pointer to the anonymous class code.
David
On 11/09/2018 3:33 AM, dean.l...@oracle.com wrote:
On 9/10/18 1:40 AM, David Holmes wrote:
Hi Dean,
On 10/09/2018 5:31 PM, dean.l...@oracle.com wrote:
Hi David. If a clas
On 9/10/18 1:40 AM, David Holmes wrote:
Hi Dean,
On 10/09/2018 5:31 PM, dean.l...@oracle.com wrote:
Hi David. If a class references its own fields or methods, and that
code is executed by the interpreter, then we should expect that
constant pool entry to be resolved, shouldn't we?
Yes
Like
Hi Dean,
On 10/09/2018 5:31 PM, dean.l...@oracle.com wrote:
Hi David. If a class references its own fields or methods, and that
code is executed by the interpreter, then we should expect that constant
pool entry to be resolved, shouldn't we?
Yes
Likewise the compiler will
treat it as resol
Hi David. If a class references its own fields or methods, and that
code is executed by the interpreter, then we should expect that constant
pool entry to be resolved, shouldn't we? Likewise the compiler will
treat it as resolved. If we treat is as unresolved, we run into the
case where we e
14 matches
Mail list logo
