I'm still not sure of your intent for
when you are fixing the various issues. I think you should commit
your webrev.00 and not do all these additional changes as part of
that.
Chris
On 9/12/18 6:28 PM, JC Beyler wrote:
Hi Jc,
+1
Thanks,
Serguei
On 9/7/18 14:07, Alex Menkov wrote:
Hi Jc,
The fix looks good.
The only note:
test/hotspot/jtreg/vmTestbase/nsk/jvmti/IsFieldSynthetic/isfldsin003/isfldsi
Hi Jc,
It looks good to me.
Thanks!
Serguei
On 9/11/18 10:54, JC Beyler wrote:
Hi all,
I am continuing the clean up of the testbase with the
n
It looks fine, but are you going to
make the incremental changes part of 8210665, or file a different
CR for them and fix all the files under it?
thanks,
Chris
On 9/12/18 4:30 PM, JC Beyler wrote:
Hi Jc,
It looks good.
Some minor comments:
http://cr.openjdk.java.net/%7Ejcbeyler/8210665/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw005/setfldw005.cpp.udiff.html
+fields[i].fid = env-> GetStaticFieldID(
Hi JC,
Overall I think your proposed ji05t001.cpp changes
are a good idea, but I would say "assignments in an
if" is the one I care about the most (but others seem to
disagree on this). If you think you will
get around to fixing "ass
+1 for the fix as a temporary workaround.
Actually that's look a bit strange as debuggee output is redirected.
So I'd expected it does not go through jdb log, and it should appear in
the test log with "debuggee.stdout>" prefix.
-alex
On 09/12/2018 12:35, Chris Plummer wrote:
Looks good. I fil
Hi Gary,
I think you should leave the yield() and NPE code out. I don't
think either are bug fixes, but just partial work arounds for
potential issues, and neither is addressing the core issues
brought up in this CR. They were part of your experiments for
Looks good.
Chris
On 9/12/18 8:20 AM, Gary Adams wrote:
Here's the updated webrev to avoid the NPE, but still
fail the test with more information about the premature
completed threads.
Issue: https://bugs.openjdk.java.net/browse/JDK-8210252
Webrev: http://cr.openjdk.java.net/~gadams/821025
The test is looking at a specific set
of locals. I don't think having extra locals is really a concern,
but a return statement should also work as well.
Yes, hard coded line numbers have been a problem many times in the
past. Usually it's changes to the cop
Looks good. I filed JDK-8210668 to address to root issue.
Chris
On 9/12/18 7:27 AM, Gary Adams wrote:
The print statements in the locals002 test have been observed to
interfere
with the output from commands, replies and prompts used in the
synchronization
of operations between the debugger and
Hi JC,
Just a couple of minor suggestions in ji05t001.cpp:
174 NSK_DISPLAY1("\nagent %s initializer: obtaining the JVMTI
env ...\n", (indx==0)?"A":"B");
I think I like this better as two lines.
204 if ((err =
jvmti
Hi Alex,
Looks good.
Thank you for the update!
Thanks,
Serguei
On 9/12/18 11:12, Alex Menkov wrote:
Hi Serguei,
Updated webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/redefineClasses1/webrev.03/
--alex
On 09/11/2018 22:15, serguei.spit...@oracle.com wrote:
Hi Alex,
It looks good.
J
Hi Serguei,
Updated webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/redefineClasses1/webrev.03/
--alex
On 09/11/2018 22:15, serguei.spit...@oracle.com wrote:
Hi Alex,
It looks good.
Just some minor comments.
http://cr.openjdk.java.net/~amenkov/sh2java/redefineClasses1/webrev.02/test/jdk
Hi Per,
I do not know this code but your need to call heapIterationFractionUpdate
seems to be a code smell that something else could be fixed, no?
Your webrev looks fine to me if I ignore the code smell that comes from
having to call the update call:
When I look at
src/jdk.hotspot.agent/share/cl
Here's an updated webrev including Chris's proposal for early
prompt print outs for commands that could be interrupted
by event processing before command prompt delivery.
Issue: https://bugs.openjdk.java.net/browse/JDK-8169718
Webrev: http://cr.openjdk.java.net/~gadams/8169718/webrev.02/
Cha
Here's the updated webrev to avoid the NPE, but still
fail the test with more information about the premature
completed threads.
Issue: https://bugs.openjdk.java.net/browse/JDK-8210252
Webrev: http://cr.openjdk.java.net/~gadams/8210252/webrev.00/
On 9/5/18, 3:16 PM, Gary Adams wrote:
After
The print statements in the locals002 test have been observed to interfere
with the output from commands, replies and prompts used in the
synchronization
of operations between the debugger and debuggee. This change will remove
the
print statements. A follow up bug will be filed for longer term
This patch avoids an assertion, and instead prints a warning, when
trying to show the "Object Histogram" when using ZGC. I also had to add
a call to heapIterationFractionUpdate() so that the update progress
frame is properly created, even when there are not heap regions to walk
over. Without th
19 matches
Mail list logo
