Thanks Serguei!
Coleen
On 9/18/18 4:04 PM, serguei.spit...@oracle.com wrote:
+1
Thanks,
Serguei
On 9/18/18 10:07 AM, Lois Foltan wrote:
Looks good & trivial.
Lois
On 9/18/2018 12:10 PM, coleen.phillim...@oracle.com wrote:
Summary: assert that Method being marked on stack hasn't been missed
+1
Thanks,
Serguei
On 9/18/18 10:07 AM, Lois Foltan wrote:
Looks good & trivial.
Lois
On 9/18/2018 12:10 PM, coleen.phillim...@oracle.com wrote:
Summary: assert that Method being marked on stack hasn't been missed
by previous metadata walk
Ran hs-tier1-7 with no failures, which is unfortuna
Thanks, Lois!
Coleen
On 9/18/18 1:07 PM, Lois Foltan wrote:
Looks good & trivial.
Lois
On 9/18/2018 12:10 PM, coleen.phillim...@oracle.com wrote:
Summary: assert that Method being marked on stack hasn't been missed
by previous metadata walk
Ran hs-tier1-7 with no failures, which is unfortuna
Hi David,
Thanks for the quick review and thoughts. I have now a new version here
that addresses your comments:
Webrev: http://cr.openjdk.java.net/~jcbeyler/8210842/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8210842
I've also inlined my answers/comments.
>
> > I've slowly starte
Thank you, JC and Thomas! I have pushed the change.
- Jini.
On 9/18/2018 10:59 PM, JC Beyler wrote:
I agree, thanks Jini for the clarification. And to talk about the other
case of pread in the file for completeness:
- The pread that tests <= 0 actually is correct: as you state it is in a
lo
Thanks for the review, Thomas!
- Jini.
On 9/18/2018 6:36 PM, Thomas Stüfe wrote:
Looks good. Thanks for fixing.
..Thomas
On Tue, Sep 18, 2018 at 1:52 PM, Jini George wrote:
Hi all,
Please review the small change for fixing the build failure in
src/jdk.hotspot.agent/linux/native/libsaproc/p
Hi JC,
Thank you for looking into this. Since we are reading the PT_INTERP
segment in this case to get the path of the dynamic linker, and since
p_filesz denotes the size of the segment (in this case, it would be the
size of the string denoting the path of the dynamic linker), if we end
up re
I think the abbreviated form - requiring the exact number of bytes
read - is fine in this case. If you want to do it really correct,
you'd have to read in a loop (since you may read fewer bytes due to IO
stalls) and handle EINTR. But the code before certainly did not care,
so the fix does not make
Looks good & trivial.
Lois
On 9/18/2018 12:10 PM, coleen.phillim...@oracle.com wrote:
Summary: assert that Method being marked on stack hasn't been missed
by previous metadata walk
Ran hs-tier1-7 with no failures, which is unfortunate because this
assert will tell me where the Method was miss
Any thoughts on this change? -B
On 9/11/18 3:41 PM, Brent Christian wrote:
Hi,
Please review this change to how the platform encoding is determined on
Mac when loading agents.
Webrev: http://cr.openjdk.java.net/~bchristi/8072130/webrev.01.cleanned/
Additional details in the bug report:
htt
Summary: assert that Method being marked on stack hasn't been missed by
previous metadata walk
Ran hs-tier1-7 with no failures, which is unfortunate because this
assert will tell me where the Method was missed from previous walk.
open webrev at http://cr.openjdk.java.net/~coleenp/8210861.01/w
Looks good. Thanks for fixing.
..Thomas
On Tue, Sep 18, 2018 at 1:52 PM, Jini George wrote:
> Hi all,
>
> Please review the small change for fixing the build failure in
> src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c with
> -Werror=unused-result.
>
> https://bugs.openjdk.java.net/browse
Hi all,
Please review the small change for fixing the build failure in
src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c with
-Werror=unused-result.
https://bugs.openjdk.java.net/browse/JDK-8210836
Webrev: http://cr.openjdk.java.net/~jgeorge/8210836/webrev.00/
A quick review would be ap
13 matches
Mail list logo
