Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

On 10/17/18 7:07 PM, David Holmes wrote: Hi Dean, This still seems racy to me. We increment all counts under the Threads_lock but we still decrement without the Threads_lock. So we can lose updates to the perfCounters.  117   _total_threads_count->inc();  118   Atomic::inc(&_atomic_threads_c

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

Thanks, Mandy! dl On 10/17/18 6:35 PM, Mandy Chung wrote: On 10/17/18 3:18 PM, dean.l...@oracle.com wrote: New webrevs, full and incremental: http://cr.openjdk.java.net/~dlong/8021335/webrev.6/ http://cr.openjdk.java.net/~dlong/8021335/webrev.6.diff/ I like it better without all the asser

Re: RFR (L) 8211899: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/scenarios/[E-M]

On 18/10/2018 11:57 AM, JC Beyler wrote: Hi all, @Serguei: no worries for the time taken, I am just two webrevs away from conquering the NSK_CPP_STUBs, I might have been a bit pushy for a review :-) I apologize! @David: It's not hotspot style but a lot of those files had that style. My CL a

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

Hi Dean, This still seems racy to me. We increment all counts under the Threads_lock but we still decrement without the Threads_lock. So we can lose updates to the perfCounters. 117 _total_threads_count->inc(); 118 Atomic::inc(&_atomic_threads_count); 119 int count = _atomic_threads_

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

On 10/17/18 3:18 PM, dean.l...@oracle.com wrote: New webrevs, full and incremental: http://cr.openjdk.java.net/~dlong/8021335/webrev.6/ http://cr.openjdk.java.net/~dlong/8021335/webrev.6.diff/ I like it better without all the asserts too. Looks good to me. Mandy

Re: RFR (S): 8211909: JDWP Transport Listener: dt_socket thread crash

Thanks Serguei! David On 18/10/2018 9:00 AM, serguei.spit...@oracle.com wrote: Hi David, Sorry for being late but just wanted to tell you that it looks good to me. Thank you for catching and taking care about it! Thanks, Serguei On 10/14/18 22:12, David Holmes wrote: Bug: https://bugs.open

Re: RFR (L) 8211899: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/scenarios/[E-M]

On 18/10/2018 6:01 AM, Hohensee, Paul wrote: Re spaces :).  There’s a bunch of places where “(jvmti_env”  should be “( jvmti_env”, but of course not all of them. I found a bunch. Why should there be a space after the '(' ? That's not hotspot-style. Neither is a space before ')'. David Oth

Re: RFR 8211736: jdb doesn't print prompt when breakpoint is hit and suspend policy is STOP_EVENT_THREAD

Hi Chris, Alex and JC, I created a separate issue to deal with "non-atomic" jdb output at https://bugs.openjdk.java.net/browse/JDK-8212626 . Please review an updated fix that includes the changes Alex suggested. Webrev: http://cr.openjdk.java.net/~dtitov/8211736/webrev.04 Issue: https://bugs.o

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

Thanks JC! dl On 10/17/18 5:06 PM, JC Beyler wrote: Hi Dean, The new webrev looks much better :) LGTM (not a reviewer though :-)). Thanks, Jc On Wed, Oct 17, 2018 at 3:19 PM > wrote: On 10/17/18 2:38 PM, Mandy Chung wrote: On 10/17/18 2:13 PM, dean.l.

Re: RFR 8211736: jdb doesn't print prompt when breakpoint is hit and suspend policy is STOP_EVENT_THREAD

Hi Chris, The previous email was accidentally fired before I managed to type anything in. Sorry for confusion. Jdb constantly reads new commands from System.in despite whether the breakpoint is hit and/or the prompt is printed. cat -n src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/T

Re: RFR 8211736: jdb doesn't print prompt when breakpoint is hit and suspend policy is STOP_EVENT_THREAD

On 10/17/18, 3:52 PM, "Chris Plummer" wrote: What is the jdb state for a breakpoint with SUSPEND_NONE? Can you actually type in commands even though no threads are suspended? Chris On 10/17/18 3:31 PM, Alex Menkov wrote: > Hi Daniil, Chris, > > As far a

Re: RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

Hi Gary, With the suggest tweaks below the fix looks good to me (modulo suggestions from Alex in the following message). I'm Okay with any approach related to the problem list. It looks wrong to keep the test problem listed with the same bug id. If we want to keep it then the bug id needs to be

Re: RFR (S): 8211909: JDWP Transport Listener: dt_socket thread crash

Hi David, Sorry for being late but just wanted to tell you that it looks good to me. Thank you for catching and taking care about it! Thanks, Serguei On 10/14/18 22:12, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8211909 webrev: http://cr.openjdk.java.net/~dholmes/821190

Re: RFR 8211736: jdb doesn't print prompt when breakpoint is hit and suspend policy is STOP_EVENT_THREAD

What is the jdb state for a breakpoint with SUSPEND_NONE? Can you actually type in commands even though no threads are suspended? Chris On 10/17/18 3:31 PM, Alex Menkov wrote: Hi Daniil, Chris, As far as I understand, the fix does not completely fixes all "non-atomic" output issues (at least

Re: RFR 8211736: jdb doesn't print prompt when breakpoint is hit and suspend policy is STOP_EVENT_THREAD

Sorry, I meant to address Daniil, not Alex. Sorry about any confusion. Chris On 10/17/18 10:47 AM, Chris Plummer wrote: Hi Alex, I think the tty buffering should be a separate bug fix, and I'd also like input from Gary on it since he had tried something similar at one point. It should probab

Re: RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

Hi Gary, - RedefineCrossEvent.java: you can drop "@modules jdk.jdi" as well. jdk.jdi is added to all test in the dir (it's specified in test/jdk/com/sun/jdi/TEST.properties) about InstanceFilter test - it's strange that RedefineCrossEvent fails while InstanceFilter does not. Maybe it's caus

Re: RFR (L) 8211899: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/scenarios/[E-M]

Hi Jc, ++LGTM. Sorry for being late. This takes a lot of efforts - thank you so much for being so patient! Thanks, Serguei On 10/11/18 11:03, Alex Menkov wrote: got it. LGTM. --alex On 10/10/2018 19:03, JC Beyler wrote: Hi Alex, Thanks for the review! Yes I had seen that too before send

Re: Restoring nsk/jvmti/scenarios/hotswap tests from ProblemList.txt

+1 --alex On 10/17/2018 11:10, Chris Plummer wrote: The changes look fine. thanks, Chris On 10/17/18 4:45 AM, Gary Adams wrote: While investigating other issues with hotswap tests I noticed 2 tests on the Problemlist that I think can be restored. I have not been able to reproduce the failu

Re: RFR 8211736: jdb doesn't print prompt when breakpoint is hit and suspend policy is STOP_EVENT_THREAD

Hi Daniil, Chris, As far as I understand, the fix does not completely fixes all "non-atomic" output issues (at least TTY.executeCommand still prints prompt separately), so I agree that handle it as separate issue would be better. Unfortunately I don't know Gary's ideas for the issue. About t

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

On 10/17/18 2:38 PM, Mandy Chung wrote: On 10/17/18 2:13 PM, dean.l...@oracle.com wrote: On 10/17/18 1:41 PM, Mandy Chung wrote: On 10/16/18 7:33 PM, David Holmes wrote: Hi Dean, Thanks for tackling this. I'm still struggling to fully grasp why we need both the PerfCounters and the regu

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

On 10/17/18 2:13 PM, dean.l...@oracle.com wrote: On 10/17/18 1:41 PM, Mandy Chung wrote: On 10/16/18 7:33 PM, David Holmes wrote: Hi Dean, Thanks for tackling this. I'm still struggling to fully grasp why we need both the PerfCounters and the regular counters. I get that we have to decr

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

On 10/17/18 1:41 PM, Mandy Chung wrote: On 10/16/18 7:33 PM, David Holmes wrote: Hi Dean, Thanks for tackling this. I'm still struggling to fully grasp why we need both the PerfCounters and the regular counters. I get that we have to decrement the live counts before ensure_join() has allow

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

On 10/16/18 7:33 PM, David Holmes wrote: Hi Dean, Thanks for tackling this. I'm still struggling to fully grasp why we need both the PerfCounters and the regular counters. I get that we have to decrement the live counts before ensure_join() has allowed Thread.join() to return, to ensure that

Re: 8196989: Revamp G1 JMX MemoryPool and GarbageCollector MXBean definitions

Hi Paul, I looked at this but it took time for me to "digest" it and I haven't entirely gone through the real GC changes :) My few remarks on the webrev itself are: - http://cr.openjdk.java.net/~phh/8196989/webrev.02/src/hotspot/share/services/memoryService.hpp.udiff.html - There is no n

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

On 10/16/18 7:33 PM, David Holmes wrote: Hi Dean, Thanks for tackling this. I'm still struggling to fully grasp why we need both the PerfCounters and the regular counters. I get that we have to decrement the live counts before ensure_join() has allowed Thread.join() to return, to ensure th

Re: Backport 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Ping. Reviews please, before the cutoff? Thanks, Paul From: hotspot-gc-dev on behalf of "Hohensee, Paul" Date: Friday, October 12, 2018 at 10:14 AM To: JC Beyler Cc: "serviceability-dev@openjdk.java.net" , "jdk8u-...@openjdk.java.net" , "hotspot-gc-...@openjdk.java.net" Subject: Re: Back

Re: RFR (L) 8211899: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/scenarios/[E-M]

Re spaces :). There’s a bunch of places where “(jvmti_env” should be “( jvmti_env”, but of course not all of them. I found a bunch. Otherwise, lgtm., no need for another webrev. Paul In hs104t002.cpp -if (! NSK_JVMTI_VERIFY ( NSK_CPP_STUB2(AddCapabilities, jvmti, -&ca

Re: RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

On 10/17/18 12:40 PM, gary.ad...@oracle.com wrote: On 10/17/18 2:04 PM, Chris Plummer wrote: Hi Gary, Can this be on one line now:   30  * @modules   31  *  jdk.jdi OK What are you blocking all jdk.* classes from redef when you pointed out that only jdk.internal.* is an issue? The

Re: RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

On 10/17/18 2:04 PM, Chris Plummer wrote: Hi Gary, Can this be on one line now:   30  * @modules   31  *  jdk.jdi OK What are you blocking all jdk.* classes from redef when you pointed out that only jdk.internal.* is an issue? The file I'm modifying already has some blocking checks

Re: Probable bug within sun.management.StackTraceElementCompositeData

Hi Mandy, Thanks for the pointer. I have not yet investigated the usage, but will check if we can use the official API instead. Thanks again for the quick response. -Sven Mandy Chung schrieb am Mi., 17. Okt. 2018, 19:50: > Hi Sven, > > This NetBeans SamplesOutputStream calls > sun.management.

Re: Restoring nsk/jvmti/scenarios/hotswap tests from ProblemList.txt

The changes look fine. thanks, Chris On 10/17/18 4:45 AM, Gary Adams wrote: While investigating other issues with hotswap tests I noticed 2 tests on the Problemlist that I think can be restored. I have not been able to reproduce the failure with hs102t002 It is marked in the ProblemList as re

Re: RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

Hi Gary, Can this be on one line now:   30  * @modules   31  *  jdk.jdi What are you blocking all jdk.* classes from redef when you pointed out that only jdk.internal.* is an issue? Is this also addressing JDK-8180804? If not, should it stay on the problem list until JDK-8180804 is

Re: Probable bug within sun.management.StackTraceElementCompositeData

Hi Sven, This NetBeans SamplesOutputStream calls sun.management.ThreadInfoCompositeData.toCompositeData which is an internal API.  It will be inaccessible when strong encapsulation is enabled. Have you looked into javax.management API to get the CompositeData directly? Mandy On 10/15/18 10:5

Re: RFR 8211736: jdb doesn't print prompt when breakpoint is hit and suspend policy is STOP_EVENT_THREAD

Hi Alex, I think the tty buffering should be a separate bug fix, and I'd also like input from Gary on it since he had tried something similar at one point. It should probably also include a multithread test to prove the fix is working (after first getting the test to fail without the changes).

RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

The RedefineCrossEvent test has been on been on the ProblemList for a very long time. In the past this test had some dependency on the Java EE modules, but they were deprecated for jdk9 and later removed completely in jdk11. This changeset to restore it, removes the corba module reference and

Re: Probable bug within sun.management.StackTraceElementCompositeData

I plan to request the backport to 11u. Mandy On 10/16/18 11:16 PM, Sven Reimers wrote: Hi, thanks for fixing. What about a backport to 11? Thanks -Sven Mandy Chung mailto:mandy.ch...@oracle.com>> schrieb am Mo., 15. Okt. 2018, 19:50: Hi Sven, It's indeed a bug in the order of

Restoring nsk/jvmti/scenarios/hotswap tests from ProblemList.txt

While investigating other issues with hotswap tests I noticed 2 tests on the Problemlist that I think can be restored. I have not been able to reproduce the failure with hs102t002 It is marked in the ProblemList as related to JDK-8203350, but that bug is about hs201t002. It is also marked as rela