RFR (M) 8213003: Remove more assignments in ifs for vmTestbase/[a-s]

2018-10-30 Thread JC Beyler
Hi all, I worked on updating my script and handling more assignments so I redid a second pass on the same files to get all the cases. Now, on those files the regex "if.* = " no longer shows any cases we would want to fix. Could I get a review for this webrev: Webrev:

Re: RFR 8195627: [Graal] nsk/jdi/VirtualMachine/redefineClasses/redefineclasses026 hangs with Graal in Xcomp mode

2018-10-30 Thread serguei . spitsyn
Hi Daniil, It looks good. Thanks! Serguei On 10/29/18 11:13 AM, Daniil Titov wrote: Please review the change that fixes the issue when the test hangs with Graal and XComp mode on. One of the test cases the test runs is to call com.sun.jdi.VirtualMachine.redefineClasses() while the target

Re: RFR 8195627: [Graal] nsk/jdi/VirtualMachine/redefineClasses/redefineclasses026 hangs with Graal in Xcomp mode

2018-10-30 Thread Vladimir Kozlov
Looks good. Thanks, Vladimir On 10/30/18 2:04 AM, serguei.spit...@oracle.com wrote: The Compiler team needs to review this as well, so added hotspot-compiler-dev mailing list. Thanks, Serguei On 10/29/18 11:13, Daniil Titov wrote: Please review the change that fixes the issue when the

Re: RFR: 8212933: Thread-SMR: requesting a VM operation whilst holding a ThreadsListHandle can cause deadlocks

2018-10-30 Thread Daniel D. Daugherty
On 10/29/18 9:31 PM, David Holmes wrote: Thanks for the explanation Robbin. The inline patch also seems fine. I hope the other reviewers noticed it. Yes, but I forgot to reply to it. Thumbs up. Dan David On 29/10/2018 7:05 PM, Robbin Ehn wrote: Hi David, On 29/10/2018 07:20, David

Re: RFR 8195627: [Graal] nsk/jdi/VirtualMachine/redefineClasses/redefineclasses026 hangs with Graal in Xcomp mode

2018-10-30 Thread serguei.spit...@oracle.com
The Compiler team needs to review this as well, so added hotspot-compiler-dev mailing list. Thanks, Serguei On 10/29/18 11:13, Daniil Titov wrote: Please review the change that fixes the issue when the test hangs with Graal and XComp mode on. One of the test cases the test runs is to call

RE: RFR : JDK-8211951 - Broken links in java.management files

2018-10-30 Thread Amit Sapre
Thanks Serguei & Alan for the reviews. Amit   From: Serguei Spitsyn Sent: Tuesday, October 30, 2018 12:53 AM To: Alan Bateman; Amit Sapre; serviceability-dev@openjdk.java.net Subject: Re: RFR : JDK-8211951 - Broken links in java.management files   Hi Amit, +1 Thanks, Serguei On 10/28/18