Re: RFR (M) 8213003: Remove more assignments in ifs for vmTestbase/[a-s]

Hi Chris, Yes that is correct, the webrev in this email thread would be postponed and done differently. Most likely we'd have to do smaller changes to extend ExceptionCheckingJni and work on replacing the NSK*VERIFY macros by using the ExceptionCheckingJni wrapper using something similar to the

Re: RFR 8203174: [Graal] JDI tests fail with Unexpected exception: com.sun.jdi.ObjectCollectedException

Hi Daniil, I thought the issue was that C2 was doing metadata allocations, and when it ran out of metaspace it did a GC (one that was not triggered by a failed object allocation). As a results we were getting objects GCs before the test ever got the chance to disable collection on them. I

Re: RFR (M) 8213003: Remove more assignments in ifs for vmTestbase/[a-s]

Hi JC, So assuming the change to move the assignment outside of the conditional is already in place, you are changing:    debugeeClass = jni->FindClass(DEBUGEE_CLASS_NAME); to      ExceptionCheckingJniEnvPtr

RFR 8203174: [Graal] JDI tests fail with Unexpected exception: com.sun.jdi.ObjectCollectedException

Please review the change that fixes several tests failing with com.sun.jdi.ObjectCollectedException when running with Graal. There main problem here is that with Graal on JVMCI Compiler threads in the target VM create a lot of objects and sporadically trigger GC that results in the objects

Re: RFR (XS) 8213246: Fix typo in vmTestbase failuire to failure

LGTM -- Igor - a Reviewer > On Nov 2, 2018, at 4:22 PM, Mikael Vidstedt > wrote: > > > Looks good. > > Cheers, > Mikael - not a Reviewer > >> On Nov 2, 2018, at 4:05 PM, JC Beyler > > wrote: >> >> Hi all, >> >> Could I get a review for a trivial typo fix: >>

Re: RFR (XS) 8213246: Fix typo in vmTestbase failuire to failure

On 11/2/18 7:05 PM, JC Beyler wrote: Hi all, Could I get a review for a trivial typo fix: Webrev: http://cr.openjdk.java.net/~jcbeyler/8213246/webrev.00/ test/hotspot/jtreg/vmTestbase/nsk/share/native/nsk_tools.cpp     No

Re: RFR (XS) 8213246: Fix typo in vmTestbase failuire to failure

Looks good. Cheers, Mikael - not a Reviewer > On Nov 2, 2018, at 4:05 PM, JC Beyler wrote: > > Hi all, > > Could I get a review for a trivial typo fix: > Webrev: http://cr.openjdk.java.net/~jcbeyler/8213246/webrev.00/ > > Bug:

RFR (XS) 8213246: Fix typo in vmTestbase failuire to failure

Hi all, Could I get a review for a trivial typo fix: Webrev: http://cr.openjdk.java.net/~jcbeyler/8213246/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8213246 Thanks, Jc

RFR (S) 8212931 HeapMonitorStatIntervalTest.java fails due average calculation

Hi all, Could I get a review for a bug in the calculation of the average size of an allocation? The solution is actually not to do the calculation at all. Instead, I just go in the cache and find an object with the right stacktrace and get its size (since all sizes should be equal because they

Re: RFR (M) 8213003: Remove more assignments in ifs for vmTestbase/[a-s]

Hi Chris, Here is what it would "look like", there is a bit more clean up to make it true for all methods, handling the "verbose" flag, etc but it should help see what I'm talking about: http://cr.openjdk.java.net/~jcbeyler/exception/ Basically: - The test now no longer needs the

Re: hprof format question

Hi Simon, I can file a bug on BufferInputStream with a bit more information about how you are using it or a failing test case. I was not able to reproduce it with a simple read of 1Mb buffers. Thanks, Roger On 11/01/2018 06:08 PM, Simon Roberts wrote: Oh, while on the topic of what I

Re: hprof format question

That's a fair question Alex. Given what I think I've discovered so far about this system, it might well be enough to move forward. To this point, I've been examining existing dumps taken over a period of a couple of weeks, and given what I now think I know, if I get more stats, that's probably

Re: hprof format question

Hi Simon, If you just need a count then would a class histogram suffice? jcmd GC.class_histogram and/or for older jdks jmap -histo[:live] thanks, Alex https://docs.oracle.com/javase/6/docs/technotes/tools/share/jmap.html *-histo[:live]*Prints a histogram of the heap. For each Java class,