Thanks a lot, Jc!
Serguei
On 11/7/18 21:55, JC Beyler wrote:
Hi Serguei,
If ever there was a doubt: looks good to me too now :)
Thanks!
Jc
On Wed, Nov 7, 201
Hi all,
Could I have a review for the extension and usage of the
ExceptionJniWrapper. This adds lines and filenames to the end of the
wrapper JNI methods, adds tracing, and throws an error if need be. I've
ported the gc/lock files to use the new TRACE_JNI_CALL add-on and I've
ported a few of the t
There is recovery code that cleans up old attach files,
but a permission denied error would prevent the clean
up operation from taking place. We're looking at a case of
a file owned by another user as well as a pid recycling
and failed clean up situation.
On 11/7/18 3:09 PM, Chris Plummer wrote:
Hi Chris,
Thank you for your comments.
Excluding of java.lang.String is not really required. It seems as it is
sufficient just to expect that the object created by other threads and included
in the result of referenceType.instances() and might be collected before we are
able to call disableCo
Hi Jc,
It is Okay if it is covered by different bugs.
Thanks,
Serguei
On 11/7/18 13:59, JC Beyler wrote:
Hi Serguei,
I have https://bugs.openjdk.java.net/browse/J
Hi Serguei,
I have https://bugs.openjdk.java.net/browse/JDK-8212960 open for that. I
like doing things in small contained steps for reviewing and sanity
checking. But if you want, I can run a script to fix all these cases now
and resent a RFR.
I created https://bugs.openjdk.java.net/browse/JDK-821
Hi Jc,
+1 LGTM.
One question:
Would it be convenient at the same time to fix missing spaces
around commas and comparisons in loops and conditions.
One more case is function call arguments but I did not see any
instances of it.
On 11/7/18 12:37,
serguei.spit...@oracle.com wrote:
Thank you a lot for review, Chris!
Serguei
On 11/7/18 12:35, Chris Plummer wrote:
Hi Serguei,
My review wasn't that thorough, but I think JC has g
Thank you a lot for review, Chris!
Serguei
On 11/7/18 12:35, Chris Plummer wrote:
Hi Serguei,
My review wasn't that thorough, but I think JC has given this
enough scrutiny so it looks ok ot me. Just one minor typo:
Hi Serguei,
My review wasn't that thorough, but I think JC has given this
enough scrutiny so it looks ok ot me. Just one minor typo:
344 printf("\n Success: locations of vars with slot #2
are NOT overlaped\n");
Should be "overla
Are you saying that the PID was
recycled, so the issue is a test run from long ago leaving behind
the file? If so, I thought there was something in the attach code
that cleaned up these PID files that were left behind. In general
I would not count this as an infra
Hi JC.
In Callbacks.cpp you missed the needed extra indent on the lines
following the "if":
406 if (!NSK_JVMTI_VERIFY(jvmti->GetFieldName(targetClass,
407 targetFields[field],
408 &objects_info[object].fields[field].name,
409 &objects_info[object].fields[field].signature,
410 NULL))
Hi Danil,
So this is the crux of the issue:
112 debuggee.suspend();
113
114 List baseReferences = new LinkedList<>();
115 // We need to ensure that the base references count is not
changed during the test.
116 // The instances of the class could be already c
Hi Jc,
Thank you a lot for looking at the update!
On 11/7/18 09:30, JC Beyler wrote:
Hi Serguei,
If there are no further suggestions on JDK-8210337,
I plan to close it out as cannot reproduce.
Similar bugs had been filed for the "Permission denied" error
from the openDoor request failure and each was attributed
to an infrastructure issue. e.g. another user with the same
pid left a temporary
Hi Chris and Serguei,
With recent builds I can no longer see any GC triggered by C1 compiler thread
due to running out of metaspace and JDK-8193126 seems as solved this particular
problem. Currently all observed GCs are triggered by JVMCI Compiler threads.
Please review a new version of the fi
Hi Jc,
The updated version of webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2018/8080406-jvmti-get-local.2/
I've resolved most of your comments.
I used macro definitions instead of templates you suggested.
Two reasons for it:
-
17 matches
Mail list logo
