Re: RFR 8205654: serviceability/dcmd/framework/HelpTest.java timed out

2018-11-10 Thread serguei.spit...@oracle.com
Hi Daniil, It looks Okay to me. Thanks, Serguei On 11/9/18 21:18, Daniil Titov wrote: Please review the change that fixes serviceability/dcmd/framework/* tests from a time out. The fix for JDK-8166642 made serviceability/dcmd/framework/* tests non-concurrent to ensure that they don't inter

Re: RFR (S) 8212931 HeapMonitorStatIntervalTest.java fails due average calculation

2018-11-10 Thread serguei.spit...@oracle.com
Hi Jc, Looks good. One minor comment. http://cr.openjdk.java.net/%7Ejcbeyler/8212931/webrev.00/test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java.frames.html  The "average" in comments is not needed anymore:

Re: RFR 8205654: serviceability/dcmd/framework/HelpTest.java timed out

2018-11-10 Thread gary.ad...@oracle.com
Looks good to me. You'll need the build directive in HelpTest and InvalidCommandTest. + * @build TestJavaProcess On 11/10/18 12:18 AM, Daniil Titov wrote: Please review the change that fixes serviceability/dcmd/framework/* tests from a time out. The fix for JDK-8166642 made serviceability/dc