Re: RFR 8215050: [TESTBUG] serviceability/tmtools/jstack/WaitNotifyThreadTest.java fails when run with flag -Xcomp

2018-12-08 Thread Patricio Chilano
Hi David, On 12/8/18 6:21 PM, David Holmes wrote: Hi Patricio, On 9/12/2018 9:04 am, Patricio Chilano wrote: Hi, Could you review this small fix for test serviceability/tmtools/jstack/WaitNotifyThreadTest.java ? After change 8214148 the test fails if the flag -Xcomp is used as explained in

Re: RFR 8215050: [TESTBUG] serviceability/tmtools/jstack/WaitNotifyThreadTest.java fails when run with flag -Xcomp

2018-12-08 Thread David Holmes
Hi Patricio, On 9/12/2018 9:04 am, Patricio Chilano wrote: Hi, Could you review this small fix for test serviceability/tmtools/jstack/WaitNotifyThreadTest.java ? After change 8214148 the test fails if the flag -Xcomp is used as explained in the bug details. The proposed change is to identifie

RFR 8215050: [TESTBUG] serviceability/tmtools/jstack/WaitNotifyThreadTest.java fails when run with flag -Xcomp

2018-12-08 Thread Patricio Chilano
Hi, Could you review this small fix for test serviceability/tmtools/jstack/WaitNotifyThreadTest.java ? After change 8214148 the test fails if the flag -Xcomp is used as explained in the bug details. The proposed change is to identified this special case and set the monitor address to match the

Re: RFR (round 6), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

2018-12-08 Thread Kim Barrett
mach5-one-rkennke-JDK-8214259-20181208-1149-13785: FAILED, Failed tests: 1 > > Build Details: 2018-12-08-1147316.roman.source > 1 Failed Test > Test TierPlatformKeywordsDescription Task > compiler/aot/calls/fromAot/AotInvokeDynamic2AotTest.java

Re: RFR (round 6), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

2018-12-08 Thread Roman Kennke
Anybody has an idea what's up with the test below? As far as I can tell, it passes when I run locally. Thanks, Roman mach5-one-rkennke-JDK-8214259-20181208-1149-13785: FAILED, Failed tests: 1 Build Details: 2018-12-08-1147316.roman.source 1 Failed Test TestTierPlatformKey

Re: RFR (round 6), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

2018-12-08 Thread Roman Kennke
Zhengyu's and Thomas' TaskQueue stuff landed in jdk/jdk and we integrated it into shenandoah/jdk and in the master patch and webrevs. I'm updating the webrevs in-place in: http://cr.openjdk.java.net/~rkennke/shenandoah-upstream/06/ This is going to be the final webrev that I intend to push on Mon

Re: RFR(XS): 8215042: Move serviceability/sa tests from tier1 to tier3.

2018-12-08 Thread David Holmes
Hi Leonid, My concern here, if we care about keeping the SA operational, is that in tier3 these tests will not be covered by the jdk/submit testing process. David On 8/12/2018 3:53 pm, Leonid Mesnik wrote: Hi Could you please review following fix which moves SA tests from tier1 to tier3. T

Re: RFR(XS): 8215042: Move serviceability/sa tests from tier1 to tier3.

2018-12-08 Thread gary.ad...@oracle.com
Looks OK to me. On 12/8/18 12:53 AM, Leonid Mesnik wrote: Hi Could you please review following fix which moves SA tests from tier1 to tier3. There are some bugs which cause intermittent failures of any test. SA tests fail intermittently are not stable enough for tier1. However failures are no