Re: RFR: JDK-8051349: nsk/jvmti/scenarios/sampling/SP06/sp06t003 fails in nightly

2018-12-15 Thread serguei.spit...@oracle.com
Hi Gary, Looks good. Thanks, Serguei On 12/15/18 12:24, gary.ad...@oracle.com wrote: Updated webrev:   http://cr.openjdk.java.net/~gadams/8051349/webrev.02/index.html On 12/15/18 8:15 AM

Re: RFR: JDK-8051349: nsk/jvmti/scenarios/sampling/SP06/sp06t003 fails in nightly

2018-12-15 Thread gary.ad...@oracle.com
Updated webrev:   http://cr.openjdk.java.net/~gadams/8051349/webrev.02/index.html On 12/15/18 8:15 AM, gary.ad...@oracle.com wrote: On 12/14/18 4:43 PM, Chris Plummer wrote: On 12/14/18 5:28 AM, Gary Adams wrote: BTW, I forgot to ask if you can fix the typo in the following comment:  345

Re: RFR (XS) 8215329: Modify ZGC requirement for HeapMonitorThreadTest.java

2018-12-15 Thread Per Liden
Just a follow up. After some further debugging, the real cause for this issue turned out to be a bug in JNI IsSameObject(). Fix currently out for review on hotspot-runtime-dev. https://bugs.openjdk.java.net/browse/JDK-8215451 cheers, Per On 12/14/2018 07:52 PM, JC Beyler wrote: Thanks all, t

Re: RFR: JDK-8051349: nsk/jvmti/scenarios/sampling/SP06/sp06t003 fails in nightly

2018-12-15 Thread gary.ad...@oracle.com
On 12/14/18 4:43 PM, Chris Plummer wrote: On 12/14/18 5:28 AM, Gary Adams wrote: BTW, I forgot to ask if you can fix the typo in the following comment:  345 /* check frame equalaty */ Yes, I fixed that one on Fri. I usually save the typos for the final webrev. On 12/13/18, 11:51