On Thu, 13 Dec 2018 at 17:19, Severin Gehwolf wrote:
>
> On Thu, 2018-12-13 at 15:49 +, Andrew Hughes wrote:
> > Ok, I presume that's not a change you're also going to make in
> > OpenJDK 12?
>
> Yes. I don't intend to change this in JDK 12. JDK 8 and JDK 9+ are not
> compatible in this regard
On 19/12/2018 3:19 am, Baesken, Matthias wrote:
Hello, here is an updated webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8215411.1/
sawindbg.cpp has been adjusted .
The exception cases mentioned now also call env->ReleaseByteArrayElements .
Looks good - thanks.
One minor styl
Hello!
Requesting reviews for:
http://cr.openjdk.java.net/~jgeorge/8215568/webrev.00/
BugID: https://bugs.openjdk.java.net/browse/JDK-8215568
No new failures with the SA tests (hs-tiers 1-5) with these changes. The
changes here include:
* Refactoring the SA tests which test clhsdb commands
Dear Jc,
Thanks a lot! I will update the webrev and ask for review separately ☺
BRs,
Lin
From: JC Beyler [mailto:jcbey...@google.com]
Sent: Wednesday, December 19, 2018 11:18 AM
To: 臧琳
Cc: serviceability-dev@openjdk.java.net
Subject: Re: [PATCH] 8214535: Extend JMap to support parallel an
Hi Lin,
Done:
>
> 1. Add dump to file support for jmap –histo
>
https://bugs.openjdk.java.net/browse/JDK-8215622
> 2. Add incremental dump for jmap –histo
>
https://bugs.openjdk.java.net/browse/JDK-8215623
> 3. Add parallel heap iteration for jmap –histo.
>
https://bugs.openjdk.ja
Dear JC,
Thanks for your comments, I totally like the idea to have 3 subtasks.
It seems that I don’t have access of JBS at present. May I ask your help
for that?
I think the 3 subtask could be:
1. Add dump to file support for jmap –histo
2. Add incremental dump for jma
Alex,
Thank you for the update!
It looks good.
There is another instance with incorrect spacing:
121 totRes=doPopFrame(false, Thread.currentThread());
No need in new webrev if you fix the above.
Thanks,
Serguei
On 12/18/18 6:01 PM, Alex Menkov wrote:
Hi Serguei,
Thank you for the review.
Hi Serguei,
Thank you for the review.
Updated webrev:
http://cr.openjdk.java.net/~amenkov/popframe_cleanup/webrev.02/
On 12/18/2018 16:49, serguei.spit...@oracle.com wrote:
Hi Alex,
A couple of minor comments.
http://cr.openjdk.java.net/~amenkov/popframe_cleanup/webrev.01/test/hotspot/jtreg/v
Hi Alex,
A couple of minor comments.
http://cr.openjdk.java.net/~amenkov/popframe_cleanup/webrev.01/test/hotspot/jtreg/vmTestbase/nsk/jvmti/PopFrame/popframe002.java.frames.html
http://cr.openjdk.java.net/~amenkov/popframe_cleanup/webrev.01/test/hotspot/jtreg/vmTestbase/nsk/jvmti/PopFrame/popfra
Hi all,
please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8215425
webrev:
http://cr.openjdk.java.net/~amenkov/popframe_cleanup/webrev.01/
The fix
- turns on detailed output for the tests and cleaned related stuff;
- for popframe002 deletes output from run() method as it caused
Hello, here is an updated webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8215411.1/
sawindbg.cpp has been adjusted .
The exception cases mentioned now also call env->ReleaseByteArrayElements .
Best regards, Matthias
> -Original Message-
> From: David Holmes
> Sent: Die
Hi Matthias,
On 18/12/2018 6:52 pm, Baesken, Matthias wrote:
Hi JC / David, thanks for the input .
I'm not really sure what you want me to change David, am I right that I can
keep the changes to
src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m
src/jdk.attach/windows/native/liba
Hi All,
I am preparing the patch for
https://bugs.openjdk.java.net/browse/JDK-8214535, and want to get your
suggestions.
To make the patch easier to review. I plan to make 3 patches as following:
1. one patch for enabling file dump of "jmap
-histo".(http://cr.openjdk.java.net/~xi
Hi JC / David, thanks for the input .
I'm not really sure what you want me to change David, am I right that I can
keep the changes to
src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m
src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c
but adjust
src/jdk.hotspot.agent
14 matches
Mail list logo
