Re: RFR: (XS): JDK-8213457: serviceability/sa/ClhsdbInspect.java time out

Hi Jini, It looks good to me. I hope you saw this test intermittently failing without the fix. Thanks, Serguei On 1/2/19 18:51, Jini George wrote: Hello! Requesting reviews for a small fix for fixing the timeout failures of the test: ClhsdbInspect.java by increasing the timeout value.

RFR: (XS): JDK-8213457: serviceability/sa/ClhsdbInspect.java time out

Hello! Requesting reviews for a small fix for fixing the timeout failures of the test: ClhsdbInspect.java by increasing the timeout value. BugID: https://bugs.openjdk.java.net/browse/JDK-8213457 Webrev: http://cr.openjdk.java.net/~jgeorge/8213457/webrev.00/index.html The fix has been tested

RE: [RFR]8215622: Add dump to file support for jmap histo

Dear Paul, Thanks a lot for your review! I am trying to remend the patch One problem is that in future, I will add more options for histo, such as “parallel”, “incremental”. so do you thinking option processing with loop in heap_inspection() in attachListener.cpp would be more

Re: RFR: JDK-8211343: nsk_jvmti_parseoptions should handle multiple suboptions

Hi Gary, Looks good to me. Thanks, Serguei On 12/31/18 10:06, gary.ad...@oracle.com wrote: Here's a revised webrev.   Webrev: http://bussund0416.us.oracle.com/export/users/gradams/work/webrevs/8211343/webrev.01/ Updates in this round of changes :   - replaced index() with strchr() to

Re: RFR(S): 8215975: [testbug] Adapt nsk tests to the PPC, S390 and AIX platforms.

I had no further comments. On 1/2/19, 10:47 AM, Lindenmaier, Goetz wrote: Hi Gary, as promised, I'll do a follow up fixing all these. But all the tests you mention are either not configured for aix (@requires linux etc) or are passing currently. So no need for action here. I just want to do

RE: RFR(S): 8215975: [testbug] Adapt nsk tests to the PPC, S390 and AIX platforms.

Hi Gary, as promised, I'll do a follow up fixing all these. But all the tests you mention are either not configured for aix (@requires linux etc) or are passing currently. So no need for action here. I just want to do a fix for the nsk tests. So can I consider my updated webrev as reviewed by

Re: RFR 8215398: -Xlog option usage => Invalid decorator '\temp\app_cds.log'.

Hi David, Thanks for the review.  I pushed the fix. I think the existing test works because the double quoted arguments are passed directly to the java process, with no intervening shell, and so the double quotes are not removed.  When running the same command from the Windows prompt, the