Re: Is RegisterMap updated?

2019-02-05 Thread Jini George
Hi David, Thank you for the explanation. From Java 9, there is the 'jhsdb' tool provided with the JDK, with which you can use the SA features. So, in this case, you can run it thus to see if you can reproduce the problem: jhsdb jstack --core --exe Thanks, Jini. On 2/2/2019 2:59 PM, Davi

Re: [RFR]8215622: Add dump to file support for jmap histo

2019-02-05 Thread serguei . spitsyn
Hi Lin, Thank you for the fix! It looks good in general. Should it come with a unit test for new flags? http://cr.openjdk.java.net/~xiaofeya/8215622/webrev.06/src/jdk.jcmd/share/classes/sun/tools/jmap/JMap.java.frames.html 154 // get the canonical path - important to avoid just 155 // passing

Re: RFR: JDK-8065773: JDI: UOE is not thrown, when redefineClasses changes a class modifier

2019-02-05 Thread David Holmes
On 5/02/2019 10:17 pm, Gary Adams wrote: On 2/4/19, 8:04 PM, David Holmes wrote: Hi Gary, On 5/02/2019 12:01 am, Gary Adams wrote: Two of the redefine classes tests (021, 023) have been on the ProblemList since they were first brought into the open repos. Both tests made an incorrect assumpti

Re: [RFR]8215622: Add dump to file support for jmap histo

2019-02-05 Thread David Holmes
On 6/02/2019 12:01 am, Hohensee, Paul wrote: Lin's OOTO (Chinese New Year) but pinged me to say that his company's OCA name is "Beijing Wodong Tianjun Information Technology Co. Ltd. - OpenJDK", which is on the list. Felix Yang (typo in the name, sorry) is a co-worker. Thanks for the info Pa

Re: [aarch64-port-dev ] RFR: 8209413: AArch64: NPE in clhsdb jstack command

2019-02-05 Thread Andrew Haley
On 2/5/19 5:55 PM, Nick Gasson (Arm Technology China) wrote: > The stack trace you sent below is incomplete, it's missing the frame for > Spinner.run (i.e. the AARCH64Frame object corresponding to the native wrapper > frame). Did you try on x86 or with the patch I posted? I'm not able to test >

Re: [aarch64-port-dev ] RFR: 8209413: AArch64: NPE in clhsdb jstack command

2019-02-05 Thread Nick Gasson (Arm Technology China)
Hi Andrew, I followed the same steps as the serviceabilty/sa/ClhsdbJstack.java test. You can see this failing in Linaro's results here: http://openjdk.linaro.org/jdkX/openjdk-jtreg-nightly-tests/builds/release/2019/028/JTwork-hotspot/serviceability/sa/ClhsdbJstack.jtr The stack trace you sent b

[aarch64-port-dev ] RFR: 8209413: AArch64: NPE in clhsdb jstack command

2019-02-05 Thread Andrew Haley
On 2/1/19 9:22 AM, Nick Gasson (Arm Technology China) wrote: > On AArch64, if you use "jhsdb clhsdb --pid=..." to attach a debugger to > a Java process, and then run "jstack -v" while any thread is executing a > native method, you will get a NullPointerException like this: This does not happen f

Re: [RFR]8215622: Add dump to file support for jmap histo

2019-02-05 Thread serguei.spit...@oracle.com
Hi Paul, I'll review the CSR. Thanks, Serguei On 2/5/19 06:02, Hohensee, Paul wrote: Looks good to me. David, who should review the CSR? Is there someone who "owns" jmap or perhaps the serviceability group lead

Re: [aarch64-port-dev ] RFR: 8209413: AArch64: NPE in clhsdb jstack command

2019-02-05 Thread Andrew Haley
On 2/1/19 9:22 AM, Nick Gasson (Arm Technology China) wrote: > On AArch64, if you use "jhsdb clhsdb --pid=..." to attach a debugger to > a Java process, and then run "jstack -v" while any thread is executing a > native method, you will get a NullPointerException like this: This does not happen f

Re: [RFR]8215622: Add dump to file support for jmap histo

2019-02-05 Thread Hohensee, Paul
Looks good to me. David, who should review the CSR? Is there someone who "owns" jmap or perhaps the serviceability group lead if there is such a person? Thanks, Paul On 1/30/19, 10:43 PM, "臧琳" wrote: Hi David, Paul, I have uploaded the refined webrev at http://cr.openjdk.

Re: [RFR]8215622: Add dump to file support for jmap histo

2019-02-05 Thread Hohensee, Paul
Lin's OOTO (Chinese New Year) but pinged me to say that his company's OCA name is "Beijing Wodong Tianjun Information Technology Co. Ltd. - OpenJDK", which is on the list. Felix Yang (typo in the name, sorry) is a co-worker. Paul On 2/5/19, 3:57 AM, "David Holmes" wrote: On 5/02/2019 9:

Re: RFR (M) 8139551: Scalability problem with redefinition - multiple code cache walks

2019-02-05 Thread coleen . phillimore
Yes, I can do that.  Thank you for reviewing this! Coleen On 2/5/19 1:50 AM, dean.l...@oracle.com wrote: Could you move this code: // Mark dependent AOT nmethods, which are only found via the class redefined. AOTLoader::mark_evol_dependent_methods(ik); into this function: C

Re: RFR: JDK-8065773: JDI: UOE is not thrown, when redefineClasses changes a class modifier

2019-02-05 Thread Gary Adams
On 2/4/19, 8:04 PM, David Holmes wrote: Hi Gary, On 5/02/2019 12:01 am, Gary Adams wrote: Two of the redefine classes tests (021, 023) have been on the ProblemList since they were first brought into the open repos. Both tests made an incorrect assumption about the access modifiers in class fil

Re: [RFR]8215622: Add dump to file support for jmap histo

2019-02-05 Thread David Holmes
On 5/02/2019 9:17 pm, Hohensee, Paul wrote: Hmm. Lin's posting webrevs via xiaofeya (Felix Wang), so technically Felix is publishing the code and so it's ok? Lin is being listed as Contributor so there needs to be an OCA signed. And what is Felix's status? I don't see him listed and don't kno

Re: [RFR]8215622: Add dump to file support for jmap histo

2019-02-05 Thread Hohensee, Paul
Hmm. Lin's posting webrevs via xiaofeya (Felix Wang), so technically Felix is publishing the code and so it's ok? Paul On 2/5/19, 1:29 AM, "David Holmes" wrote: Hi Paul, On 5/02/2019 6:38 pm, Hohensee, Paul wrote: > Lin works for JDPower, which afaik has signed the OCA.

Re: [RFR]8215622: Add dump to file support for jmap histo

2019-02-05 Thread David Holmes
Hi Paul, On 5/02/2019 6:38 pm, Hohensee, Paul wrote: Lin works for JDPower, which afaik has signed the OCA. I don't see them listed at: https://www.oracle.com/technetwork/community/oca-486395.html Thanks, David On 2/4/19, 12:42 AM, "David Holmes" wrote: Hi Lin, Sorry but

Re: [RFR]8215622: Add dump to file support for jmap histo

2019-02-05 Thread Hohensee, Paul
Lin works for JDPower, which afaik has signed the OCA. On 2/4/19, 12:42 AM, "David Holmes" wrote: Hi Lin, Sorry but can I just confirm that you have signed the OCA [1]? I don't see you listed individually and I can't tell what company you work for or whether your are cont

Re: PING: RFR: 8217845: SA should refer const values for JVMFlag from HotSpot

2019-02-05 Thread serguei.spit...@oracle.com
+1 Thanks, Serguei On 2/4/19 21:18, Jini George wrote: Looks ok to me. Thanks! -Jini. On 2/5/2019 10:25 AM, Yasumasa Suenaga wrote: Hi Jini, Thank you for your comment! I uploaded new webrev. Could you review again?    http://cr.openjdk.java.net/~ysuenaga/JDK-8217845/webrev.01/ Diff from