On 9/02/2019 11:29 pm, gary.ad...@oracle.com wrote:
I'm willing to do the leg work on cleaning up the tests, but I'll need
some help
identifying where the redefine operations are missing the
inner_class_flags checks.
src/hotspot/share/prims/jvmtiRedefineClasses.cpp
This code needs expanding:
Hi David,
Thank you for reviewing this change.
You are right, these tests should be run before pushing JDK-8218705. I
apologize for that. I run the usual set (tier1,tier2,tier3 and serviceability
tests) but it was not enough in this case.
Best regards,
Daniil
On 2/9/19, 4:31 AM, "David Holme
I'm willing to do the leg work on cleaning up the tests, but I'll need
some help
identifying where the redefine operations are missing the
inner_class_flags checks.
Is spec change or a CSR required when we change the current behavior to
be more strict?
On 2/8/19 9:24 PM, David Holmes wrote:
Hi Daniil,
The fix seems reasonable.
These tests should all have been run before pushing JDK-8205654.
Thanks,
David
--
On 9/02/2019 3:37 pm, Daniil Titov wrote:
Please review the change that fix the test failure.
The problem here is that the code in
sun.tools.common.ProcessArgumentMatch
Thanks All for reviewing the change and CSR, I am still OOTO now and I will
update the webrev later and ask your help for review again.
Happy Chinese New Year!
Cheers,
Lin
From: serguei.spit...@oracle.com
Sent: Wednesday, February 6, 2019 6:44:43 AM
To:
