jstack mixed mode and jhsdb stack mixed mode can not get expected result(stack trace is incomplete) on latest ubuntu or fedora or RHEL 8 beta

Hello,   I tried “jstack -m PID”in latest openjdk 8 64-bit and “jhsdb jstack –mixed –pid PID” in latest openjdk 11 64-bit on latest Ubuntu(18.04) and latest fedora (29) and RHEL 8 Beta. The stack traces returned are always incomplete like following output:   - 1479

Re: RFR: JDK-8149461: jmap kills process if non-java pid is specified in the command line

Gary, What is the overhead of doing the validation? How do we list VMs? Do we need to examine every running process to get the list of VMs? Wouldn't it be better to check the given process is a VM rather than checking all potential VM processes? I think there is an onus of responsibility on

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

Hi Stefan, Both changes look good to me! Thanks, Yasumasa 2019年2月15日(金) 2:12 Stefan Karlsson : > > Hi again, > > I've separated the live regions iteration refactoring into this patch: > https://cr.openjdk.java.net/~stefank/8219003/webrev.01/ > > And use this RFE for the ZGC specific parts: >

Re: RFR: JDK-8149461: jmap kills process if non-java pid is specified in the command line

Looks good to me. You could also take on Thomas' suggestion, but I'm not sure if there are any common use cases that it would be protecting us from accidentally killing a process (other than the ones you are already fixing). Chris On 2/14/19 11:12 AM, Gary Adams wrote: The following

Re: RFR(T) : 8209455 : [error-prone] JdkObsolete in jdk.management.agent

On 14/02/2019 19:02, Igor Ignatyev wrote: Thanks, JC! Alan, does webrev.01 look good to you? Yes, this looks much nicer. -Alan

Re: RFR: JDK-8149461: jmap kills process if non-java pid is specified in the command line

Hi Gary, thanks for taking this on. I have occasionally killed a foreign process with jcmd and it is a bit embarrassing :) I think your patch is okay, but I wonder whether a check directly in libattach would be simpler and cover all uses of the attach framework. Such a test could be e.g. simply

Re: RFR: JDK-8149461: jmap kills process if non-java pid is specified in the command line

The following commands present a similar kill process behavior: jcmd jinfo jmap jstack The following commands do not attach. jstat sun.jvmstat.monitor.MonitorException "not found" jps no pid arguments This update moves the checkJavaPid method into the

Re: RFR(T) : 8209455 : [error-prone] JdkObsolete in jdk.management.agent

Thanks, JC! Alan, does webrev.01 look good to you? -- Igor > On Feb 13, 2019, at 2:42 PM, Jean Christophe Beyler > wrote: > > Hi Igor, > > Looks good to me :) > Jc > > On Wed, Feb 13, 2019 at 11:24 AM Igor Ignatyev > wrote: > Hi Alan, > > actually,

Re: RFR(S): 8218941: jdb should support a dbgtrace command that acts the same as the dbgtrace command line option

+1 --alex On 02/13/2019 23:07, serguei.spit...@oracle.com wrote: Hi Chris, It looks good to me. Thanks, Serguei On 2/13/19 18:43, Chris Plummer wrote: Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218941/webrev https://bugs.openjdk.java.net/browse/JDK-8218941

Re: RFR: 8218734: SA: Incorrect and raw loads of OopHandles

Hi Jini, On 2019-02-14 18:11, Jini George wrote: Hi Stefan, Other than the getAddressField to getField change and the comments by Erik, I just have a couple of nits to add. 1. This line in VMOopHandle.java can be removed: 31 import sun.jvm.hotspot.runtime.VMObjectFactory; Done. 2. The

Re: RFR: JDK-8219002: Some comments and error messages refer to VMDisconnectException

+1 Thanks, Serguei On 2/14/19 09:07, Chris Plummer wrote: Looks good. Chris On 2/14/19 9:00 AM, Gary Adams wrote: Trivial cleanup of a misspelled exception :   VMDisconnectException   VMDisconnectedException   Webrev: http://cr.openjdk.java.net/~gadams/8219002/webrev.00   Issue:

Re: RFR: 8218734: SA: Incorrect and raw loads of OopHandles

Hi Stefan, Other than the getAddressField to getField change and the comments by Erik, I just have a couple of nits to add. 1. This line in VMOopHandle.java can be removed: 31 import sun.jvm.hotspot.runtime.VMObjectFactory; 2. The copyright year for some of the files need updation. This

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

Hi again, I've separated the live regions iteration refactoring into this patch: https://cr.openjdk.java.net/~stefank/8219003/webrev.01/ And use this RFE for the ZGC specific parts: https://cr.openjdk.java.net/~stefank/8218922/webrev.02/ Thanks, StefanK On 2019-02-14 14:39, Stefan Karlsson

Re: RFR: JDK-8149461: jmap kills process if non-java pid is specified in the command line

Hi Gary, What about the other tools that attach to a user specified process. Do they also have this issue? thanks, Chris On 2/14/19 8:35 AM, Gary Adams wrote: There is an old reported problem that using jmap on a process that is not running Java could cause the process to terminate. This

Re: RFR: JDK-8219002: Some comments and error messages refer to VMDisconnectException

Looks good. Chris On 2/14/19 9:00 AM, Gary Adams wrote: Trivial cleanup of a misspelled exception :   VMDisconnectException   VMDisconnectedException   Webrev: http://cr.openjdk.java.net/~gadams/8219002/webrev.00   Issue: https://bugs.openjdk.java.net/browse/JDK-8219002

RFR: JDK-8219002: Some comments and error messages refer to VMDisconnectException

Trivial cleanup of a misspelled exception : VMDisconnectException VMDisconnectedException Webrev: http://cr.openjdk.java.net/~gadams/8219002/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8219002

Re: RFR: 8218746: SA: Implement discontiguous bitmap for ZGC

On 2019-02-14 17:04, Jini George wrote: Hi Stefan, Looks good to me. Nit: Could you please modify the copyright year? And don't we have to add the copyright message to the new file ZExternalBitMap.java ? Thanks. I've gone through all my SA patches and updated the copyright year. StefanK

RFR: JDK-8149461: jmap kills process if non-java pid is specified in the command line

There is an old reported problem that using jmap on a process that is not running Java could cause the process to terminate. This is due to the SIGQUIT used when attaching to the process. It is a fairly simple operation to validate that the pid matches one of the known running Java processes

Re: RFR: 8218746: SA: Implement discontiguous bitmap for ZGC

Hi Stefan, Looks good to me. Nit: Could you please modify the copyright year? And don't we have to add the copyright message to the new file ZExternalBitMap.java ? Thanks! Jini. On 2/11/2019 7:25 PM, Stefan Karlsson wrote: Hi all, Please review this patch to implement a discontiuous

Re: RFR(S): 8218941: jdb should support a dbgtrace command that acts the same as the dbgtrace command line option

Do you mean for the non-english locales? If I understood correctly what I was told a while back, we don't localize anymore, so it shouldn't be necessary. Chris On 2/14/19 2:11 AM, gary.ad...@oracle.com wrote: Do you need placeholder entries in the translated TTYResources message files? On

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

Hi Yasumasa, On 2019-02-14 14:11, Yasumasa Suenaga wrote: Hi Stefan, Maybe this is enough to enable a bit more SA debugging capabilities when running with ZGC? What do you think, should we bring in this change? I think it should be brought this in. I filed same issue as JDK-8207843, but

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

Hi Stefan, Maybe this is enough to enable a bit more SA debugging capabilities when running with ZGC? What do you think, should we bring in this change? I think it should be brought this in. I filed same issue as JDK-8207843, but I've not yet worked. So I will close it as duplicate of your

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

If this patch is accepted we also need this patch to turn on the SA hprof implementation: http://cr.openjdk.java.net/~stefank/8218970/webrev.01/ StefanK On 2019-02-13 15:52, Stefan Karlsson wrote: Hi all, Please review / comment on this patch to enable a best-effort live heap region

Re: RFR(S): 8218941: jdb should support a dbgtrace command that acts the same as the dbgtrace command line option

Do you need placeholder entries in the translated TTYResources message files? On 2/13/19 9:43 PM, Chris Plummer wrote: Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218941/webrev https://bugs.openjdk.java.net/browse/JDK-8218941 Tested by running the following on

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

Thanks for taking a look at this! StefanK On 2019-02-14 10:58, Erik Österlund wrote: Hi Stefan, I think this makes things better. I like the cleanups and I like the partial support for heap parsing. I think we should bring this in, and it looks good to me. Of course we can always improve

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

Hi Stefan, I think this makes things better. I like the cleanups and I like the partial support for heap parsing. I think we should bring this in, and it looks good to me. Of course we can always improve this further at some point in the future to deal with broken Klass pointers better.

Re: RFR: 8218746: SA: Implement discontiguous bitmap for ZGC

On 2019-02-14 10:22, Erik Österlund wrote: Hi Stefan, At ZExternalBitMap line 22: * Maybe add a bounds check for offsets < 0 as well. At ZExternalBitMap line 45: * Remove weird whitespace in argument list. * Consider inverting the condition to early exit. Don't mind if you choose to do that

Re: RFR: 8218746: SA: Implement discontiguous bitmap for ZGC

Hi Stefan, At ZExternalBitMap line 22: * Maybe add a bounds check for offsets < 0 as well. At ZExternalBitMap line 45: * Remove weird whitespace in argument list. * Consider inverting the condition to early exit. Don't mind if you choose to do that or not. Otherwise looks good. Don't need

Re: RFR: 8218743: SA: Add support for large bitmaps

Thanks, Erik. Stefank On 2019-02-14 10:11, Erik Österlund wrote: Hi Stefan, Looks good. Thanks, /Erik On 2019-02-11 13:36, Stefan Karlsson wrote: Hi all, Please review this patch to add support for large bitmaps in the SA. http://cr.openjdk.java.net/~stefank/8218743/webrev.01/

Re: RFR: 8218733: SA: CollectedHeap provides broken implementation for used() and capacity()

Thanks, Erik. Stefank On 2019-02-14 09:38, Erik Österlund wrote: Hi Stefan, Looks good. Thanks, /Erik On 2019-02-11 09:13, Stefan Karlsson wrote: Hi all, Please review this patch to remove the broken implementation of CollectedHeap used() and capacity() and instead force all GCs to

Re: RFR: 8218734: SA: Incorrect and raw loads of OopHandles

On 2019-02-14 10:01, Erik Österlund wrote: Hi Stefan, Looks good. One thing though... At VMOopHandle.java line 38: * Remove weird double indentation * Remove weird double semicolon * Use Field instead of AddressField I'll fix. I don't think I need another webrev. Thanks for reviewing.

Re: RFR: 8218732: SA: Resolves ZPageAllocator::_physical incorrectly

Thanks, Erik. Stefank On 2019-02-14 09:26, Erik Österlund wrote: Hi Stefan, Given that the remark from Jini is fixed, this looks good. I don't need another webrev. Thanks, /Erik On 2019-02-11 19:09, Stefan Karlsson wrote: Hi Jini, On 2019-02-11 19:00, Jini George wrote: Hi Stefan,

Re: RFR: 8218743: SA: Add support for large bitmaps

Hi Stefan, Looks good. Thanks, /Erik On 2019-02-11 13:36, Stefan Karlsson wrote: Hi all, Please review this patch to add support for large bitmaps in the SA. http://cr.openjdk.java.net/~stefank/8218743/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8218743 I've added a minimal

Re: RFR: 8218731: SA: Use concrete class the as return type of VMObjectFactory.newObject

Thanks, Erik. Stefank On 2019-02-14 09:19, Erik Österlund wrote: Hi Stefan, This looks good and trivial. Thanks, /Erik On 2019-02-11 08:47, Stefan Karlsson wrote: Hi all, I propose this simple change to use the concrete class as the return type of VMObjectFactory.newObject.

Re: RFR: 8218734: SA: Incorrect and raw loads of OopHandles

Hi Stefan, Looks good. One thing though... At VMOopHandle.java line 38: * Remove weird double indentation * Remove weird double semicolon * Use Field instead of AddressField I don't think I need another webrev. Thanks, /Erik On 2019-02-11 09:39, Stefan Karlsson wrote: Hi all, Please

Re: RFR: 8218733: SA: CollectedHeap provides broken implementation for used() and capacity()

Hi Stefan, Looks good. Thanks, /Erik On 2019-02-11 09:13, Stefan Karlsson wrote: Hi all, Please review this patch to remove the broken implementation of CollectedHeap used() and capacity() and instead force all GCs to provide their own implementations.

Re: RFR: 8218732: SA: Resolves ZPageAllocator::_physical incorrectly

Hi Stefan, Given that the remark from Jini is fixed, this looks good. I don't need another webrev. Thanks, /Erik On 2019-02-11 19:09, Stefan Karlsson wrote: Hi Jini, On 2019-02-11 19:00, Jini George wrote: Hi Stefan, Looks good to me overall. One point though. physicalFieldOffset =

Re: RFR: 8218731: SA: Use concrete class the as return type of VMObjectFactory.newObject

Hi Stefan, This looks good and trivial. Thanks, /Erik On 2019-02-11 08:47, Stefan Karlsson wrote: Hi all, I propose this simple change to use the concrete class as the return type of VMObjectFactory.newObject. https://cr.openjdk.java.net/~stefank/8218731/webrev.01

Re: RFR(XS): 8218947: jdb threads command should print threadID in decimal, not hex

Hi Chris, On 14/02/2019 4:54 pm, Chris Plummer wrote: Hi David, I can update the man page. Can you point me to where it is in the source? I haven't been able to find it. It seems to be out of date in other ways also. Will send pointer separately as it's not part of OpenJDK. This is what