Hi,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8220352
http://cr.openjdk.java.net/~cjplummer/8220352/webrev.00/
The possible use of an invalid jni handle is being avoided by not
deleting the globalrefs as the test exits. This is the same fix that was
applied to JDK-
Thank you, Dean, for reviewing this change.
--Daniil
On 3/12/19, 5:00 PM, "serviceability-dev-boun...@openjdk.java.net on behalf of
dean.l...@oracle.com" wrote:
Looks good and trivial.
dl
On 3/12/19 4:46 PM, Daniil Titov wrote:
> Please review a trivial change that r
Looks good and trivial.
dl
On 3/12/19 4:46 PM, Daniil Titov wrote:
Please review a trivial change that removes test
vmTestbase/nsk/jvmti/scenarios/sampling/SP06/sp06t003, recently fixed in
8218167, from ProblemList-graal.txt
Webrev: http://cr.openjdk.java.net/~dtitov/8220244/webrev.01/
Bug:
Please review a trivial change that removes test
vmTestbase/nsk/jvmti/scenarios/sampling/SP06/sp06t003, recently fixed in
8218167, from ProblemList-graal.txt
Webrev: http://cr.openjdk.java.net/~dtitov/8220244/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8220244
Thanks!
--Daniil
Hi Daniel,
Since you have reviewed the first version of the webrev, just wanted to check
with you that you are OK with the new version of the fix. Please note that a
new enhancement [3] was created to cover the work related with hiding JVMCI
compiler (and probably some other) threads.
Referen
Summary: Add a function to call NSME in ResolvedMethodTable to replace
deleted methods.
Please review a backport of this bug to JDK 11 and 12. The JDK 12
backport required some manual merging in
ResolvedMethodTable::adjust_method_entries to account for some preceding
cleanup in the original.
Hi Stefan,
The fix looks good to me.
Testing the tiers 1-7 for different GC's has to be good enough.
Thanks,
Serguei
On 3/12/19 8:19 AM, Stefan Karlsson wrote:
Hi all,
Please review and/or comment on this change to remove
CodeCache::scavenge_root_nmehods_do from
VM_HeapWalkOperation::colle
Looks good to me.
dl
On 3/12/19 11:07 AM, Gary Adams wrote:
Still need 2 more reviewers ...
On 3/7/19, 9:45 AM, Daniel D. Daugherty wrote:
Gary,
Since the 'graal' label was recently removed, I also removed "[Graal]"
from the bug synopsis. Please make sure you update your commit mesg.
On 3
Hi Gary,
The fix looks good. However, since there are only two references
(debuggeeThread1 and debuggeeThread2) the test checks, an alternative to
catching and ignoring ObjectCollectedException could be just calling
disableCollection() on these two thread references when a breakpoint handle is
Hi Severin,
On 08/03/2019 13:20, Severin Gehwolf wrote:
On Fri, 2019-03-08 at 11:59 +, Daniel Fuchs wrote:
- please verify on your local box if testing both plain &
SSL with a Thread.sleep(1000) in between makes the test
more stable. If it does, then I'd prefer we go down
this r
Still need 2 more reviewers ...
On 3/7/19, 9:45 AM, Daniel D. Daugherty wrote:
Gary,
Since the 'graal' label was recently removed, I also removed "[Graal]"
from the bug synopsis. Please make sure you update your commit mesg.
On 3/7/19 8:19 AM, Gary Adams wrote:
While trying to reproduce the
Hi all,
Please review and/or comment on this change to remove
CodeCache::scavenge_root_nmehods_do from
VM_HeapWalkOperation::collect_simple_roots.
http://cr.openjdk.java.net/~stefank/8220342/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8220342
VM_HeapWalkOperation::collect_simple_root
On 12/03/2019 14:24, Gary Adams wrote:
Need one reviewer for this trivial correction .
Having had to do the same for java.logging, I can say that the
doc changes to package-info.java look good to me :-)
AFAICT the changes to the copyright notice look OK too.
best regards,
-- daniel
After
Need one reviewer for this trivial correction .
After pushing the GPL header update, the h3 to h2 tags will be updated.
The copyright will be changed with the headings, so I'll push that
change first.
JDK-8220474: Incorrect GPL header in
src/java.instrument/share/classes/java/lang/instrument/
Hold on! Sorry ...
On 12/03/2019 10:32 pm, David Holmes wrote:
Ship it!
Thanks,
David
On 12/03/2019 9:54 pm, Gary Adams wrote:
Need one reviewer for this trivial correction .
Issue: https://bugs.openjdk.java.net/browse/JDK-8220474
diff --git
a/src/java.instrument/share/classes/java/lang
Ship it!
Thanks,
David
On 12/03/2019 9:54 pm, Gary Adams wrote:
Need one reviewer for this trivial correction .
Issue: https://bugs.openjdk.java.net/browse/JDK-8220474
diff --git
a/src/java.instrument/share/classes/java/lang/instrument/package-info.java
b/src/java.instrument/share/classe
Need one reviewer for this trivial correction .
Issue: https://bugs.openjdk.java.net/browse/JDK-8220474
diff --git
a/src/java.instrument/share/classes/java/lang/instrument/package-info.java
b/src/java.instrument/share/classes/java/lang/instrument/package-info.java
---
a/src/java.instrument/
17 matches
Mail list logo
